Skip to contentSkip to conversation

mtd: nand: Allow NAND chip ids to be included standalone.

PATCH New Murali Nalajala 4 participants 12 messages Mar 8, 2011 – Apr 14, 2011

Subsystems (3)
Arm Qualcomm mailing list Memory technology devices (MTD) NAND flash
lore
Share & tools
lore

Murali Nalajala

author
#0 lore raw

PATCH v2 1/2 mtd: nand: Allow NAND chip ids to be included standalone.

Lets non-standard NAND drivers take advantage of known NAND chip information.

The initial development of msm nand driver, driver uses the supported NAND devices information as a hardcoded table. Remove the existing hardcoded supported flash device table and read the flash device information from the flash id table which are part of the mtd subsystem.

Signed-off-by Dima Zavin <[email protected]>
Signed-off-by Murali Nalajala <[email protected]>

---
Changes in V2
* Add more description to the commit text.

 drivers/mtd/nand/Kconfig |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)
drivers/mtd/nand/Kconfig +7 -3
index c895922..782275e 100644
@@ -1,3 +1,10 @@
+config MTD_NAND_IDS
+	tristate "Include chip ids for known NAND devices."
+	depends on MTD
+	help
+	  Useful for NAND drivers that do not use the NAND subsystem but
+	  still like to take advantage of the known chip information.
+
 config MTD_NAND_ECC
 	tristate
 

@@ -123,9 +130,6 @@ config MTD_NAND_OMAP_PREFETCH_DMA
 	 or in DMA interrupt mode.
 	 Say y for DMA mode or MPU mode will be used
 
-config MTD_NAND_IDS
-	tristate
-
 config MTD_NAND_RICOH
 	tristate "Ricoh xD card reader"
 	default n
Signature · 5 lines
1.7.1.1

--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
#1 lore raw

PATCH v2 1/2 mtd: nand: Allow NAND chip ids to be included standalone.

Quoted 7 lines · Murali Nalajala

Lets non-standard NAND drivers take advantage of known NAND chip information.

The initial development of msm nand driver, driver uses the supported NAND devices information as a hardcoded table. Remove the existing hardcoded supported flash device table and read the flash device information from the flash id table which are part of the mtd subsystem.

Why this initial version should be upstream? Why wouldn't you make it "standard" first?

Signature · 2 lines
Best Regards,
Artem Bityutskiy (????? ????????)
author
#2 lore raw

PATCH v2 1/2 mtd: nand: Allow NAND chip ids to be included standalone.

Quoted 4 lines · Artem Bityutskiy
Quoted 3 lines · Murali Nalajala

Lets non-standard NAND drivers take advantage of known NAND chip information.

Quoted 8 lines
Quoted 4 lines

The initial development of msm nand driver, driver uses the supported NAND devices information as a hardcoded table. Remove the existing hardcoded supported flash device table and read the flash device information from the flash id table which are part of the mtd subsystem.

Why this initial version should be upstream? Why wouldn't you make it "standard" first?

Currently we are not fully using the MTD nand subsystem. That's the intention author has introduced "non-standard" here!!!

Thanks,
Murali N

Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
author
#3 lore raw

PATCH v2 1/2 mtd: nand: Allow NAND chip ids to be included standalone.

Quoted 14 lines · Murali Nalajala
Quoted 4 lines · Artem Bityutskiy
Quoted 3 lines · Murali Nalajala

Lets non-standard NAND drivers take advantage of known NAND chip information.

Quoted 8 lines
Quoted 4 lines

The initial development of msm nand driver, driver uses the supported NAND devices information as a hardcoded table. Remove the existing hardcoded supported flash device table and read the flash device information from the flash id table which are part of the mtd subsystem.

Why this initial version should be upstream? Why wouldn't you make it "standard" first?

Quoted 6 lines

Currently we are not fully using the MTD nand subsystem. That's the intention author has introduced "non-standard" here!!!

Thanks,
Murali N

Any reviews comments on this change?

Thanks,
Murali N

Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
#4 lore raw

PATCH v2 1/2 mtd: nand: Allow NAND chip ids to be included standalone.

Quoted 15 lines · Murali Nalajala
Quoted 14 lines · Murali Nalajala
Quoted 12 lines · Artem Bityutskiy
Quoted 7 lines · Murali Nalajala

Lets non-standard NAND drivers take advantage of known NAND chip information.

The initial development of msm nand driver, driver uses the supported NAND devices information as a hardcoded table. Remove the existing hardcoded supported flash device table and read the flash device information from the flash id table which are part of the mtd subsystem.

Why this initial version should be upstream? Why wouldn't you make it "standard" first?

Quoted 8 lines
Quoted 6 lines

Currently we are not fully using the MTD nand subsystem. That's the intention author has introduced "non-standard" here!!!

Thanks,
Murali N

Any reviews comments on this change?

No, I think you should "sell" your driver better than that. Indeed,

Q: "Why this initial version should be upstream? Why wouldn't you make it "standard" first?"
A: Currently we are not fully using the MTD nand subsystem. That's the intention author has introduced "non-standard" here!!!

Signature · 2 lines
Best Regards,
Artem Bityutskiy (????? ????????)
author
#5 lore raw

PATCH v2 1/2 mtd: nand: Allow NAND chip ids to be included standalone.

Quoted 23 lines · Artem Bityutskiy
Quoted 22 lines · Murali Nalajala
Quoted 20 lines · Murali Nalajala
Quoted 4 lines · Artem Bityutskiy
Quoted 3 lines · Murali Nalajala

Lets non-standard NAND drivers take advantage of known NAND chip information.

Quoted 8 lines
Quoted 4 lines

The initial development of msm nand driver, driver uses the supported NAND devices information as a hardcoded table. Remove the existing hardcoded supported flash device table and read the flash device information from the flash id table which are part of the mtd subsystem.

Why this initial version should be upstream? Why wouldn't you make it "standard" first?

Currently we are not fully using the MTD nand subsystem. That's the intention author has introduced "non-standard" here!!!

Thanks,
Murali N

Quoted 9 lines
Quoted 1 line

Any reviews comments on this change?

No, I think you should "sell" your driver better than that. Indeed,

Q: "Why this initial version should be upstream? Why wouldn't you make it "standard" first?"
A: Currently we are not fully using the MTD nand subsystem. That's the intention author has introduced "non-standard" here!!!

The driver (msm_nand.c) is in align to MTD specification. But this commit text is bit misleading, initially the driver didn't make use of nand flash devices information from the flash id table which are part of the MTD subsystem. Hence we have enabled this config option to make use of it.

Thanks,
Murali N

Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
author
#6 lore raw

PATCH v2 1/2 mtd: nand: Allow NAND chip ids to be included standalone.

Quoted 35 lines · Murali Nalajala
Quoted 24 lines · Artem Bityutskiy
Quoted 23 lines · Murali Nalajala
Quoted 21 lines · Murali Nalajala
Quoted 4 lines · Artem Bityutskiy
Quoted 3 lines · Murali Nalajala

Lets non-standard NAND drivers take advantage of known NAND chip information.

Quoted 9 lines
Quoted 5 lines

The initial development of msm nand driver, driver uses the supported NAND devices information as a hardcoded table. Remove the existing hardcoded supported flash device table and read the flash device information from the flash id table which are part of the mtd subsystem.

Why this initial version should be upstream? Why wouldn't you make it "standard" first?

Currently we are not fully using the MTD nand subsystem. That's the intention author has introduced "non-standard" here!!!

Thanks,
Murali N

Quoted 9 lines
Quoted 1 line

Any reviews comments on this change?

No, I think you should "sell" your driver better than that. Indeed,

Q: "Why this initial version should be upstream? Why wouldn't you make it "standard" first?"
A: Currently we are not fully using the MTD nand subsystem. That's the intention author has introduced "non-standard" here!!!

Quoted 9 lines

The driver (msm_nand.c) is in align to MTD specification. But this commit text is bit misleading, initially the driver didn't make use of nand flash devices information from the flash id table which are part of the MTD subsystem. Hence we have enabled this config option to make use of it.

Thanks,
Murali N

Hi,
Still you have any issues/comments?

Thanks,
Murali N

Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
#7 lore raw

PATCH v2 1/2 mtd: nand: Allow NAND chip ids to be included standalone.

Quoted 1 line · Murali Nalajala

Still you have any issues/comments?

No, not so far, just have not time now to look closer.

Signature · 2 lines
Best Regards,
Artem Bityutskiy (????? ????????)
author
#8 lore raw

PATCH v2 1/2 mtd: nand: Allow NAND chip ids to be included standalone.

Quoted 6 lines · Artem Bityutskiy
Quoted 1 line · Murali Nalajala

Still you have any issues/comments?

No, not so far, just have not time now to look closer.

Did anybody got a chance to go through the patch?

Thanks,
Murali N

Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
#9 lore raw

PATCH v2 1/2 mtd: nand: Allow NAND chip ids to be included standalone.

Quoted 8 lines · Murali Nalajala
Quoted 6 lines · Artem Bityutskiy
Quoted 1 line · Murali Nalajala

Still you have any issues/comments?

No, not so far, just have not time now to look closer.

Did anybody got a chance to go through the patch?

Could you start with trying to get an ack or reviewed-by from some maintainer form Codeaurora, e.g., David Brown? Unfortunately, MTD community does not have enough people who'd actively review other's work.

Signature · 2 lines
Best Regards,
Artem Bityutskiy (????? ????????)
#10 lore raw

PATCH v2 1/2 mtd: nand: Allow NAND chip ids to be included standalone.

In reply to Murali Nalajala
Acked-by Dima Zavin <[email protected]>
Quoted 50 lines · Murali Nalajala

Lets non-standard NAND drivers take advantage of known NAND chip information.

The initial development of msm nand driver, driver uses the supported NAND devices information as a hardcoded table. Remove the existing hardcoded supported flash device table and read the flash device information from the flash id table which are part of the mtd subsystem.

Signed-off-by Dima Zavin <[email protected]>
Signed-off-by Murali Nalajala <[email protected]>

---
Changes in V2
* Add more description to the commit text.

?drivers/mtd/nand/Kconfig | ? 10 +++++++---
?1 files changed, 7 insertions(+), 3 deletions(-)

drivers/mtd/nand/Kconfig +7 -0
index c895922..782275e 100644
@@ -1,3 +1,10 @@
+config MTD_NAND_IDS
+ ? ? ? tristate "Include chip ids for known NAND devices."
+ ? ? ? depends on MTD
+ ? ? ? help
+ ? ? ? ? Useful for NAND drivers that do not use the NAND subsystem but
+ ? ? ? ? still like to take advantage of the known chip information.
+

?config MTD_NAND_ECC
? ? ? ?tristate

drivers/mtd/nand/Kconfig +0 -0
@@ -123,9 +130,6 @@ config MTD_NAND_OMAP_PREFETCH_DMA

? ? ? ? or in DMA interrupt mode.
? ? ? ? Say y for DMA mode or MPU mode will be used

drivers/mtd/nand/Kconfig +0 -3
-config MTD_NAND_IDS
- ? ? ? tristate
-

?config MTD_NAND_RICOH
? ? ? ?tristate "Ricoh xD card reader"
? ? ? ?default n
--
1.7.1.1

--
Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

#11 lore raw

PATCH v2 1/2 mtd: nand: Allow NAND chip ids to be included standalone.

In reply to Murali Nalajala
Quoted 10 lines · Murali Nalajala

Lets non-standard NAND drivers take advantage of known NAND chip information.

The initial development of msm nand driver, driver uses the supported NAND devices information as a hardcoded table. Remove the existing hardcoded supported flash device table and read the flash device information from the flash id table which are part of the mtd subsystem.

Signed-off-by Dima Zavin <[email protected]>
Signed-off-by Murali Nalajala <[email protected]>
Acked-by David Brown <[email protected]>
Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.