Skip to contentSkip to conversation

blk-cgroup: Lower minimum weight from 100 to 10.

PATCH RESEND Applied Justin TerAvest 2 participants 2 messages Mar 8, 2011

Subsystems (2)
Documentation Block layer
lore
Share & tools
lore

Justin TerAvest

author
#0 lore raw

PATCH RESEND 1/1 blk-cgroup: Lower minimum weight from 100 to 10.

We've found that we still get good, useful isolation at weights this low. I'd like to adjust the minimum so that any other changes can take these values into account.

Signed-off-by Justin TerAvest <[email protected]>
Acked-by Vivek Goyal <[email protected]>
---
 Documentation/cgroups/blkio-controller.txt |    2 +-
 block/blk-cgroup.h                         |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Documentation/cgroups/blkio-controller.txt +1 -1
index 4ed7b5c..24314fd 100644
@@ -140,7 +140,7 @@ Proportional weight policy files
 	- Specifies per cgroup weight. This is default weight of the group
 	  on all the devices until and unless overridden by per device rule.
 	  (See blkio.weight_device).
-	  Currently allowed range of weights is from 100 to 1000.
+	  Currently allowed range of weights is from 10 to 1000.
 
 - blkio.weight_device
 	- One can specify per cgroup per device rules using this interface.
block/blk-cgroup.h +1 -1
index ea4861b..57e7234 100644
@@ -240,7 +240,7 @@ static inline char *blkg_path(struct blkio_group *blkg) { return NULL; }
 
 #endif
 
-#define BLKIO_WEIGHT_MIN	100
+#define BLKIO_WEIGHT_MIN	10
 #define BLKIO_WEIGHT_MAX	1000
 #define BLKIO_WEIGHT_DEFAULT	500
Signature · 1 line
1.7.3.1
Applied
#1 lore raw
Quoted 3 lines · Justin TerAvest

We've found that we still get good, useful isolation at weights this low. I'd like to adjust the minimum so that any other changes can take these values into account.

Thanks, applied.

Signature · 1 line
Jens Axboe