Skip to contentSkip to conversation

OMAP4: Intialize IVA Device in addition to DSP device.

PATCH New Shweta Gulati 3 participants 4 messages Mar 10, 2011 – Mar 11, 2011

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OMAP4: Intialize IVA Device in addition to DSP device.

OMAP4 has two different Devices IVA and DSP. DSP is bound with MPU for DVFS and IVA has its own well defined OPPs. This Patch adds IVA init to 'omap2_init_processor_devices' and make sure that API 'omap2_set_init_voltage' is called for apt dev pointer.

It fixes Error logs:

omap2_set_init_voltage: Invalid parameters!
omap2_set_init_voltage: Unable to put vdd_iva to its init voltage

Tested on OMAP4430 SDP Board.
Baseline:
http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
Branch :pm-core

---
 arch/arm/mach-omap2/pm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/pm.c +1 -0
index 30af335..49486f5 100644
@@ -89,6 +89,7 @@ static void omap2_init_processor_devices(void)
 	if (cpu_is_omap44xx()) {
 		_init_omap_device("l3_main_1", &l3_dev);
 		_init_omap_device("dsp", &dsp_dev);
+		_init_omap_device("iva", &iva_dev);
 	} else {
 		_init_omap_device("l3_main", &l3_dev);
 	}
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 OMAP4: Intialize IVA Device in addition to DSP device.

Quoted 10 lines

-----Original Message-----
From: linux-arm-kernel-bounces at lists.infradead.org [mailto:linux-arm- kernel-bounces at lists.infradead.org] On Behalf Of Shweta Gulati
Sent: Thursday, March 10, 2011 11:52 AM
To: linux-omap at vger.kernel.org
Cc: Shweta Gulati; linux-arm-kernel at lists.infradead.org
Subject: [PATCH] OMAP4: Intialize IVA Device in addition to DSP device.

OMAP4 has two different Devices IVA and DSP. DSP is bound with MPU for DVFS and IVA has its own well defined OPPs.

DSP is not in MPU voltage domain. DSP(Tesla) and IVAHD are in the same voltage domain. Pls correct this in the commit log.

Vishwa

Quoted 40 lines

This Patch adds IVA init to 'omap2_init_processor_devices' and make sure that API 'omap2_set_init_voltage' is called for apt dev pointer.

It fixes Error logs:

omap2_set_init_voltage: Invalid parameters!
omap2_set_init_voltage: Unable to put vdd_iva to its init voltage

Tested on OMAP4430 SDP Board.
Baseline:
http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-
pm.git
Branch :pm-core

---
 arch/arm/mach-omap2/pm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/pm.c +1 -1
index 30af335..49486f5 100644
@@ -89,6 +89,7 @@ static void omap2_init_processor_devices(void)
 	if (cpu_is_omap44xx()) {
 		_init_omap_device("l3_main_1", &l3_dev);
 		_init_omap_device("dsp", &dsp_dev);
+		_init_omap_device("iva", &iva_dev);
 	} else {
 		_init_omap_device("l3_main", &l3_dev);
 	}
--

1.7.0.4

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw

PATCH 1/1 OMAP4: Intialize IVA Device in addition to DSP device.

Few cosmetic comments follow:
Vishwanath Sripathy wrote, on 03/10/2011 02:36 PM:

Quoted 8 lines
Quoted 8 lines

-----Original Message-----
From: linux-arm-kernel-bounces at lists.infradead.org [mailto:linux-arm- kernel-bounces at lists.infradead.org] On Behalf Of Shweta Gulati
Sent: Thursday, March 10, 2011 11:52 AM
To: linux-omap at vger.kernel.org
Cc: Shweta Gulati; linux-arm-kernel at lists.infradead.org
Subject: [PATCH] OMAP4: Intialize IVA Device in addition to DSP device.

Quoted 4 lines
Quoted 2 lines

OMAP4 has two different Devices IVA and DSP. DSP is bound with MPU for DVFS and IVA has its own well defined OPPs.

DSP is not in MPU voltage domain. DSP(Tesla) and IVAHD are in the same voltage domain. Pls correct this in the commit log.

True for OMAP4 - DSP and MPU DVFS are independent, in OMAP3, they were scaled together ;)

[...]

Quoted 3 lines
Quoted 3 lines

This Patch adds IVA init to 'omap2_init_processor_devices' and make sure that API 'omap2_set_init_voltage' is called for apt dev pointer.

set_init_voltage error is just one symptom of the problem. infact, if we wanted to do anything with iva - e.g. dvfs, we would'nt have been able to without the device being registered.

Quoted 2 lines
Quoted 2 lines

It fixes Error logs:

"This also fixes the following error seen during boot as omap2_set_init_voltage can now find the iva device" is better than the "This patch...."?

Quoted 3 lines
Quoted 3 lines

omap2_set_init_voltage: Invalid parameters!
omap2_set_init_voltage: Unable to put vdd_iva to its init voltage

Thanks for catching and fixing this - I had noticed this in my SR 1.5 testing(should have posted as well), but had'nt tried to dig further.

Quoted 6 lines
Quoted 6 lines

Tested on OMAP4430 SDP Board.
Baseline:
http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-
pm.git
Branch :pm-core

Do you really want this information in commit log? I suggest you move this to the diffstat section.

Quoted 18 lines
Quoted 18 lines
---
  arch/arm/mach-omap2/pm.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/pm.c +1 -0
index 30af335..49486f5 100644
@@ -89,6 +89,7 @@ static void omap2_init_processor_devices(void)
  	if (cpu_is_omap44xx()) {
  		_init_omap_device("l3_main_1",&l3_dev);
  		_init_omap_device("dsp",&dsp_dev);
+		_init_omap_device("iva",&iva_dev);
  	} else {
  		_init_omap_device("l3_main",&l3_dev);
  	}
Signature · 2 lines
Regards,
Nishanth Menon
#3 lore raw

PATCH 1/1 OMAP4: Intialize IVA Device in addition to DSP device.

Hi,

Quoted 11 lines · Nishanth Menon

Few cosmetic comments follow:
Vishwanath Sripathy wrote, on 03/10/2011 02:36 PM:

Quoted 9 lines
Quoted 9 lines

-----Original Message-----
From: linux-arm-kernel-bounces at lists.infradead.org [mailto:linux-arm- kernel-bounces at lists.infradead.org] On Behalf Of Shweta Gulati
Sent: Thursday, March 10, 2011 11:52 AM
To: linux-omap at vger.kernel.org
Cc: Shweta Gulati; linux-arm-kernel at lists.infradead.org
Subject: [PATCH] OMAP4: Intialize IVA Device in addition to DSP device.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

OMAP4 has two different Devices IVA and DSP. DSP is bound with MPU for DVFS and IVA has its own well defined OPPs.

DSP is not in MPU voltage domain. DSP(Tesla) and IVAHD are in the same voltage domain. Pls correct this in the commit log.

True for OMAP4 - DSP and MPU DVFS are independent, in OMAP3, they were scaled together ;)

Will correct the Commit log.

Quoted 9 lines

[...]

Quoted 4 lines
Quoted 4 lines

This Patch adds IVA init to 'omap2_init_processor_devices' and make sure that API 'omap2_set_init_voltage' is called for apt dev pointer.

set_init_voltage error is just one symptom of the problem. infact, if we wanted to do anything with iva - e.g. dvfs, we would'nt have been able to without the device being registered.

Yes, Fair enough need to rephrase whole Log.

Quoted 6 lines
Quoted 2 lines
Quoted 2 lines

It fixes Error logs:

"This also fixes the following error seen during boot as omap2_set_init_voltage can now find the iva device" is better than the "This patch...."?

Will do.

Quoted 8 lines
Quoted 3 lines
Quoted 3 lines

? ? ? ?omap2_set_init_voltage: Invalid parameters!
? ? ? ?omap2_set_init_voltage: Unable to put vdd_iva to its init voltage

Thanks for catching and fixing this - I had noticed this in my SR 1.5 testing(should have posted as well), but had'nt tried to dig further.

Quoted 1 line
Quoted 1 line
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines

Tested on OMAP4430 SDP Board.
Baseline:
http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-
pm.git
Branch :pm-core

Do you really want this information in commit log? I suggest you move this to the diffstat section.

Will do.

Quoted 25 lines
Quoted 6 lines
Quoted 6 lines

---
?arch/arm/mach-omap2/pm.c | ? ?1 +
?1 files changed, 1 insertions(+), 0 deletions(-)

Quoted 12 lines

arch/arm/mach-omap2/pm.c static void omap2_init_processor_devices(void) · line 95

Quoted 12 lines
arch/arm/mach-omap2/pm.c +1 -0
index 30af335..49486f5 100644
@@ -89,6 +89,7 @@ static void omap2_init_processor_devices(void)
 ? ? ? ?if (cpu_is_omap44xx()) {
 ? ? ? ? ? ? ? ?_init_omap_device("l3_main_1",&l3_dev);
 ? ? ? ? ? ? ? ?_init_omap_device("dsp",&dsp_dev);
+ ? ? ? ? ? ? ? _init_omap_device("iva",&iva_dev);
 ? ? ? ?} else {
 ? ? ? ? ? ? ? ?_init_omap_device("l3_main",&l3_dev);
 ? ? ? ?}

--
Regards,
Nishanth Menon

Signature · 3 lines
Thanks,
Regards,
Shweta