transmission: add recipe for 2.22 version

PATCH In review Lukas-David Gorris 3 participants 4 messages Mar 11, 2011

lore

Share & tools

lore

Lukas-David Gorris

author

2011-03-11 01:14 UTC #0 lore raw

PATCH 1/1 transmission: add recipe for 2.22 version

Depends on the the previously sent libevent bump.

From: Lukas-David Gorris <[email protected]>
Date: Fri, 11 Mar 2011 02:00:56 +0100
Subject: [oe] [PATCH] transmission: add recipe for 2.22 version

---
 recipes/transmission/transmission_2.22.bb |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
 create mode 100644 recipes/transmission/transmission_2.22.bb

(quoted diff) +0 -0

b/recipes/transmission/transmission_2.22.bb
new file mode 100644
index 0000000..e9a7891

recipes/transmission/transmission_2.22.bb new file +8 -0

@@ -0,0 +1,9 @@
+require transmission.inc
+
+DEPENDS += "libevent"
+
+PR = ${INC_PR}.1
+
+SRC_URI[archive.md5sum] = "6499986bf769276310b00bda1090090d"
+SRC_URI[archive.sha256sum] =

"5a4079194f45260c143f21ea6f33ce2660d89fca02ad8f1e65169968d365e4d4" +

Signature · 1 line

1.7.1

Paul Menzel

2011-03-11 10:02 UTC #1 lore raw

Dear Lukas-David,

Am Freitag, den 11.03.2011, 02:03 +0100 schrieb Lukas-David Gorris:

Quoted 1 line

Depends on the the previously sent libevent bump.

Using git format-patch -2 -s you can create patches where the dependencies are shown in the subject, e. g. [PATCH 1/2] and [PATCH 2/2].

Quoted 3 lines

From: Lukas-David Gorris <[email protected]>
Date: Fri, 11 Mar 2011 02:00:56 +0100
Subject: [oe] [PATCH] transmission: add recipe for 2.22 version

As already written in another thread, your MUA mangled the patches. Please turn off automatic line wrapping (normal to preformatted) or using git send-email.

Your Signed-off-by line is also missing as demanded by the commit policy [1].

Secondly, I would appreciate if you could add to the commit message, what build configuration you tested your new recipe/patch with and if all operations worked when running it.

Quoted 12 lines

---
 recipes/transmission/transmission_2.22.bb |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
 create mode 100644 recipes/transmission/transmission_2.22.bb

recipes/transmission/transmission_2.22.bb new file +0 -0

new file mode 100644
index 0000000..e9a7891

recipes/transmission/transmission_2.22.bb line 5

Quoted 5 lines

recipes/transmission/transmission_2.22.bb new file +5 -0
@@ -0,0 +1,9 @@
+require transmission.inc
+
+DEPENDS += "libevent"
+
+PR = ${INC_PR}.1

You should start at 0.

recipes/transmission/transmission_2.22.bb line 7

Quoted 2 lines

recipes/transmission/transmission_2.22.bb new file +2 -0

+SRC_URI[archive.md5sum] = "6499986bf769276310b00bda1090090d"
+SRC_URI[archive.sha256sum] = "5a4079194f45260c143f21ea6f33ce2660d89fca02ad8f1e65169968d365e4d4"

Thanks,

Paul

[1] http://openembedded.org/index.php/Commit_Policy

Paul Menzel

2011-03-11 14:56 UTC #2 lore raw

Dear Graeme,

Am Freitag, den 11.03.2011, 11:00 +0100 schrieb Paul Menzel:

Quoted 42 lines

Am Freitag, den 11.03.2011, 02:03 +0100 schrieb Lukas-David Gorris:
Quoted 1 line
Depends on the the previously sent libevent bump.
Using git format-patch -2 -s you can create patches where the dependencies are shown in the subject, e. g. [PATCH 1/2] and [PATCH 2/2].
Quoted 3 lines
From: Lukas-David Gorris <[email protected]>
Date: Fri, 11 Mar 2011 02:00:56 +0100
Subject: [oe] [PATCH] transmission: add recipe for 2.22 version
As already written in another thread, your MUA mangled the patches. Please turn off automatic line wrapping (normal to preformatted) or using git send-email.
Your Signed-off-by line is also missing as demanded by the commit policy [1].
Secondly, I would appreciate if you could add to the commit message, what build configuration you tested your new recipe/patch with and if all operations worked when running it.
Quoted 12 lines
---
 recipes/transmission/transmission_2.22.bb |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
 create mode 100644 recipes/transmission/transmission_2.22.bb
recipes/transmission/transmission_2.22.bb new file +0 -0
new file mode 100644
index 0000000..e9a7891
recipes/transmission/transmission_2.22.bb line 5
Quoted 5 lines
recipes/transmission/transmission_2.22.bb new file +5 -0
@@ -0,0 +1,9 @@
+require transmission.inc
+
+DEPENDS += "libevent"
+
+PR = ${INC_PR}.1
You should start at 0.

Quoted 2 lines

recipes/transmission/transmission_2.22.bb line 7
Quoted 2 lines
recipes/transmission/transmission_2.22.bb new file +2 -0
+SRC_URI[archive.md5sum] = "6499986bf769276310b00bda1090090d"
+SRC_URI[archive.sha256sum] = "5a4079194f45260c143f21ea6f33ce2660d89fca02ad8f1e65169968d365e4d4"

why did you commit in e124c44f [1] without my remarks being addressed? Also the things you put into the commit message could have been left out.

Thanks,

Paul

Quoted 1 line

[1] http://openembedded.org/index.php/Commit_Policy

[2] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=e124c44f14b887aec64c71d33120508cb033af6e

Graeme Gregory

2011-03-11 15:16 UTC #3 lore raw

Quoted 44 lines · Paul Menzel

Dear Graeme,
Am Freitag, den 11.03.2011, 11:00 +0100 schrieb Paul Menzel:
Quoted 39 lines
Am Freitag, den 11.03.2011, 02:03 +0100 schrieb Lukas-David Gorris:
Quoted 1 line
Depends on the the previously sent libevent bump.
Using git format-patch -2 -s you can create patches where the dependencies are shown in the subject, e. g. [PATCH 1/2] and [PATCH 2/2].
Quoted 3 lines
From: Lukas-David Gorris <[email protected]>
Date: Fri, 11 Mar 2011 02:00:56 +0100
Subject: [oe] [PATCH] transmission: add recipe for 2.22 version
As already written in another thread, your MUA mangled the patches. Please turn off automatic line wrapping (normal to preformatted) or using git send-email.
Your Signed-off-by line is also missing as demanded by the commit policy [1].
Secondly, I would appreciate if you could add to the commit message, what build configuration you tested your new recipe/patch with and if all operations worked when running it.
Quoted 12 lines
---
 recipes/transmission/transmission_2.22.bb |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
 create mode 100644 recipes/transmission/transmission_2.22.bb
recipes/transmission/transmission_2.22.bb new file +0 -0
new file mode 100644
index 0000000..e9a7891
recipes/transmission/transmission_2.22.bb line 5
Quoted 5 lines
recipes/transmission/transmission_2.22.bb new file +5 -0
@@ -0,0 +1,9 @@
+require transmission.inc
+
+DEPENDS += "libevent"
+
+PR = ${INC_PR}.1
You should start at 0.

Quoted 7 lines

Quoted 2 lines
recipes/transmission/transmission_2.22.bb line 7
Quoted 2 lines
recipes/transmission/transmission_2.22.bb new file +2 -0
+SRC_URI[archive.md5sum] = "6499986bf769276310b00bda1090090d"
+SRC_URI[archive.sha256sum] = "5a4079194f45260c143f21ea6f33ce2660d89fca02ad8f1e65169968d365e4d4"
why did you commit in e124c44f [1] without my remarks being addressed? Also the things you put into the commit message could have been left out.

I got your comments long after I had already done the commits. Im getting a lot of OE emails seriously delayed today.

I used pw-am as per the process recomended.

Graeme