Skip to contentSkip to conversation

PATCH RESEND: fix Bug 812 about slang

PATCH In review Kang Kai 2 participants 4 messages Mar 14, 2011 – Mar 15, 2011

lore
Share & tools
lore

Kang Kai

author
#0 lore raw

cover PATCH RESEND: fix Bug 812 about slang

From: Kang Kai <[email protected]>

Hi Soul,

Resend patch for bug 812.

When do install, export "INST_LIB_DIR=${STAGING_DIR_HOST}/usr/lib" to slsh so that it will go to the right place to search libraries.

And add necessary files to run slsh.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: kangkai/distro01
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/distro01

Thanks,
Kang Kai <[email protected]>
---

Kang Kai (1):
PATCH: fix Bug 812 about slang

 meta/recipes-extended/slang/slang_2.2.2.bb |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
author
#1 lore raw

PATCH 1/1 PATCH: fix Bug 812 about slang

From: Kang Kai <[email protected]>

Export "INST_LIB_DIR" to slang/slsh to fix cross compile warnings

Add necessary files to run slsh.

Signed-off-by Kang Kai <[email protected]>
---
 meta/recipes-extended/slang/slang_2.2.2.bb |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
meta/recipes-extended/slang/slang_2.2.2.bb +7 -1
index 7fe76af..8459e24 100644
@@ -10,7 +10,7 @@ to recode S-Lang procedures in C if you need to."
 SECTION = "libs"
 PRIORITY = "optional"
 DEPENDS = "pcre"
-PR = "r0"
+PR = "r1"
 
 LICENSE = "GPL Artistic"
 LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"

@@ -23,3 +23,9 @@ inherit autotools
 
 SRC_URI[md5sum] = "974437602a781cfe92ab61433dd16d03"
 SRC_URI[sha256sum] = "cfaf8551fa3855f9b0043309bb553ef6d457f931b404df5a6ba6a5a69371fc42"
+
+do_install() {
+	oe_runmake install DESTDIR=${D} -e 'INST_LIB_DIR=${STAGING_DIR_HOST}/usr/lib'
+}
+
+FILES_${PN} += "/usr/share/slsh/"
Signature · 1 line
1.7.1
#2 lore raw

Re: [PATCH 1/1] PATCH: fix Bug 812 about slang

Kang,

The proper first line of a commit (commit subject line) should contain the package name followed by what you have done in this commit.

Also, the bug # should not be in the first line, it should be in the Body of the commit message in the [YOCTO #XXX] format.

So your commit message should read something like:

slang: Export INST_LIB_DIR in do_install to fix compile problems

Export "INST_LIB_DIR" to slang/slsh to fix cross compile warnings Fixes [YOCTO #812]

Signed-off-by Kang Kai<[email protected]>

Sau!

Quoted 34 lines · Kang Kai

From: Kang Kai<[email protected]>

Export "INST_LIB_DIR" to slang/slsh to fix cross compile warnings

Add necessary files to run slsh.

Signed-off-by Kang Kai<[email protected]>
---
  meta/recipes-extended/slang/slang_2.2.2.bb |    8 +++++++-
  1 files changed, 7 insertions(+), 1 deletions(-)
meta/recipes-extended/slang/slang_2.2.2.bb +7 -1
index 7fe76af..8459e24 100644
@@ -10,7 +10,7 @@ to recode S-Lang procedures in C if you need to."
  SECTION = "libs"
  PRIORITY = "optional"
  DEPENDS = "pcre"
-PR = "r0"
+PR = "r1"
 
  LICENSE = "GPL Artistic"
  LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"

@@ -23,3 +23,9 @@ inherit autotools
 
  SRC_URI[md5sum] = "974437602a781cfe92ab61433dd16d03"
  SRC_URI[sha256sum] = "cfaf8551fa3855f9b0043309bb553ef6d457f931b404df5a6ba6a5a69371fc42"
+
+do_install() {
+	oe_runmake install DESTDIR=${D} -e 'INST_LIB_DIR=${STAGING_DIR_HOST}/usr/lib'
+}
+
+FILES_${PN} += "/usr/share/slsh/"
author
#3 lore raw

Re: [PATCH 1/1] PATCH: fix Bug 812 about slang

Quoted 7 lines · Saul Wold

Kang,

The proper first line of a commit (commit subject line) should contain the package name followed by what you have done in this commit.

Also, the bug # should not be in the first line, it should be in the Body of the commit message in the [YOCTO #XXX] format.

Quoted 9 lines

So your commit message should read something like:

slang: Export INST_LIB_DIR in do_install to fix compile problems

Export "INST_LIB_DIR" to slang/slsh to fix cross compile warnings Fixes [YOCTO #812]

Signed-off-by Kang Kai<[email protected]>

Sau!

Thank you very much, I will obey the rule next time.
And is there any document about the rules, then I can be more careful about my mails' format.

Regards,
Kang Kai

Quoted 38 lines · Kang Kai
Quoted 35 lines

From: Kang Kai<[email protected]>

Export "INST_LIB_DIR" to slang/slsh to fix cross compile warnings

Add necessary files to run slsh.

Signed-off-by Kang Kai<[email protected]>

---
meta/recipes-extended/slang/slang_2.2.2.bb | 8 +++++++-

1 files changed, 7 insertions(+), 1 deletions(-)
meta/recipes-extended/slang/slang_2.2.2.bb +0 -0
index 7fe76af..8459e24 100644
@@ -10,7 +10,7 @@ to recode S-Lang procedures in C if you need to."

SECTION = "libs"
PRIORITY = "optional"
DEPENDS = "pcre"

meta/recipes-extended/slang/slang_2.2.2.bb +1 -1
-PR = "r0"
+PR = "r1"

LICENSE = "GPL Artistic"
LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"

meta/recipes-extended/slang/slang_2.2.2.bb +0 -0
@@ -23,3 +23,9 @@ inherit autotools

SRC_URI[md5sum] = "974437602a781cfe92ab61433dd16d03"
SRC_URI[sha256sum] = "cfaf8551fa3855f9b0043309bb553ef6d457f931b404df5a6ba6a5a69371fc42"

meta/recipes-extended/slang/slang_2.2.2.bb +3 -0
+
+do_install() {
+ oe_runmake install DESTDIR=${D} -e

'INST_LIB_DIR=${STAGING_DIR_HOST}/usr/lib'

meta/recipes-extended/slang/slang_2.2.2.bb +3 -0
+}
+
+FILES_${PN} += "/usr/share/slsh/"