Skip to contentSkip to conversation

solos-pci: Fix debugging to include size, vpi/vci, but omit preamble

PATCH New Philip Prindeville 1 participant 1 message Mar 20, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 solos-pci: Fix debugging to include size, vpi/vci, but omit preamble

Show the buffer length, vpi, and vci as we do on receive. Use the word "port" instead of "device" consistently.

Don't display the "struct pkt_hdr" preamble on the sk_buff when doing hexdump of frame data.

---

drivers/atm/solos-pci.c renamed from drivers/atm/solos-pci.c.orig +8 -1
@@ -697,7 +697,7 @@ void solos_bh(unsigned long card_arg)
 					      size);
 			}
 			if (atmdebug) {
-				dev_info(&card->dev->dev, "Received: device %d\n", port);
+				dev_info(&card->dev->dev, "Received: port %d\n", port);
 				dev_info(&card->dev->dev, "size: %d VPI: %d VCI: %d\n",
 					 size, le16_to_cpu(header->vpi),
 					 le16_to_cpu(header->vci));
@@ -1025,8 +1025,15 @@ static uint32_t fpga_tx(struct solos_car
 
 			/* Clean up and free oldskb now it's gone */
 			if (atmdebug) {
+				struct pkt_hdr *header = (void *)oldskb->data;
+				int size = le16_to_cpu(header->size);
+
+				skb_pull(oldskb, sizeof(*header));
 				dev_info(&card->dev->dev, "Transmitted: port %d\n",
 					 port);
+				dev_info(&card->dev->dev, "size: %d VPI: %d VCI: %d\n",
+					 size, le16_to_cpu(header->vpi),
+					 le16_to_cpu(header->vci));
 				print_buffer(oldskb);
 			}