Clean up CodingStyle for scripts/kconfig/gconf.c
PATCH 1/1 Clean up CodingStyle for scripts/kconfig/gconf.c
Hi us,
Clean up CodingStyle for scripts/kconfig/gconf.c.
Thanks.
Best Regards.
Harry Wei.
--- scripts/kconfig/gconf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
scripts/kconfig/gconf.c +1 -1
@@ -7,7 +7,7 @@*/ #ifdef HAVE_CONFIG_H -# include <config.h> +#include <config.h> #endif #include "lkc.h"
Signature · 1 line
1.7.0.4
Quoted 3 lines · Harry Wei
Hi us,
Clean up CodingStyle forscripts/kconfig/gconf.c.
What makes you think this is a bad style? Does Documentation/CodingStyle say so? Does checkpatch.pl make a complain? Do you really think this improves readability? I don't think so, and actually it makes the code worse.
Run checkpatch.pl on this file, and you'll see lots of errors and warnings, but pure codingstyle cleanup is rarely worth anything, so better don't do that.
Quoted 22 lines
Thanks.
Best Regards.
Harry Wei.Signed-off-by Harry Wei <[email protected]>--- scripts/kconfig/gconf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)scripts/kconfig/gconf.c +1
-1@@ -7,7 +7,7 @@*/ #ifdef HAVE_CONFIG_H -# include <config.h> +#include <config.h> #endif #include "lkc.h"
Quoted 8 lines · Li Zefan
Quoted 3 lines · Harry Wei
Hi us,
Clean up CodingStyle forscripts/kconfig/gconf.c.What makes you think this is a bad style? Does
Documentation/CodingStylesay so? Does checkpatch.pl make a complain? Do you really think this improves readability? I don't think so, and actually it makes the code worse.
But we all write '#include <***>'. I have never seen '# include <***>'.
Quoted 4 lines
Run checkpatch.pl on this file, and you'll see lots of errors and warnings, but pure codingstyle cleanup is rarely worth anything, so better don't do that.
I am sorry, I have not got your meaning clearly.
Quoted 28 lines
Quoted 15 lines
Thanks.
Best Regards.
Harry Wei.Signed-off-by Harry Wei <[email protected]>--- scripts/kconfig/gconf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)scripts/kconfig/gconf.c +0
-0scripts/kconfig/gconf.c line 13
Quoted 8 lines
scripts/kconfig/gconf.c +1
-1@@ -7,7 +7,7 @@*/ #ifdef HAVE_CONFIG_H -# include <config.h> +#include <config.h> #endif #include "lkc.h" --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoted 9 lines
Quoted 8 lines
Quoted 4 lines
Hi us,
Clean up CodingStyle forscripts/kconfig/gconf.c.What makes you think this is a bad style? Does
Documentation/CodingStylesay so? Does checkpatch.pl make a complain? Do you really think this improves readability? I don't think so, and actually it makes the code worse.But we all write '#include <***>'. I have never seen '# include <***>'.
Then let's see:
$ find -name '*.c' -exec grep -H '^# .*include' {} \;
./drivers/char/mem.c:# include <linux/efi.h>
./drivers/char/random.c:# include <linux/irq.h>
./drivers/scsi/nsp32.c:# include "nsp32_debug.c"
./drivers/video/epson1355fb.c:# include <mach/hardware.h>You can look into those cases, and then you should be able to figure out why.
Quoted 5 lines
Quoted 4 lines
Run checkpatch.pl on this file, and you'll see lots of errors and warnings, but pure codingstyle cleanup is rarely worth anything, so better don't do that.
I am sorry, I have not got your meaning clearly.
Codingstyle cleanups aren't worth your time, and it would be better for you and for the kernel project as a whole if you can find something more valuable to work on.
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
Thanks.
Best Regards.
Harry Wei.Signed-off-by Harry Wei <[email protected]>--- scripts/kconfig/gconf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)scripts/kconfig/gconf.c +1
-1@@ -7,7 +7,7 @@*/ #ifdef HAVE_CONFIG_H -# include <config.h> +#include <config.h> #endif #include "lkc.h"
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 14 lines · jiaweiwei
Quoted 12 lines · Li Zefan
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Hi us,
Clean up CodingStyle forscripts/kconfig/gconf.c.What makes you think this is a bad style? Does
Documentation/CodingStylesay
Quoted 1 line
Quoted 1 line
so? Does checkpatch.pl make a complain? Do you really think this
improves
Quoted 2 lines
Quoted 1 line
readability? I don't think so, and actually it makes the code worse.
But we all write '#include <***>'. I have never seen '# include <***>'.
Quoted 8 lines
Quoted 8 lines
Then let's see:
$ find -name '*.c' -exec grep -H '^# .*include' {} \; ./drivers/char/mem.c:# include <linux/efi.h> ./drivers/char/random.c:# include <linux/irq.h> ./drivers/scsi/nsp32.c:# include "nsp32_debug.c" ./drivers/video/epson1355fb.c:# include <mach/hardware.h>
Okay, i see.
Quoted 7 lines
Quoted 7 lines
You can look into those cases, and then you should be able to figure out why.
Quoted 2 lines
Quoted 2 lines
Run checkpatch.pl on this file, and you'll see lots of errors and
warnings,
Quoted 1 line
Quoted 1 line
but pure codingstyle cleanup is rarely worth anything, so better don't
Quoted 8 lines
Quoted 8 lines
do
Quoted 2 lines
Quoted 1 line
that.
I am sorry, I have not got your meaning clearly.
Codingstyle cleanups aren't worth your time, and it would be better for you and for the kernel project as a whole if you can find something more valuable
to work on.
Thanks, i will try my best.
Best Regards.
Harry Wei.
Quoted 30 lines
Quoted 25 lines
Quoted 24 lines
Quoted 24 lines
Quoted 24 lines
Thanks.
Best Regards.
Harry Wei.Signed-off-by Harry Wei <[email protected]>--- scripts/kconfig/gconf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)scripts/kconfig/gconf.c +1
-1@@ -7,7 +7,7 @@*/ #ifdef HAVE_CONFIG_H -# include <config.h> +#include <config.h> #endif #include "lkc.h" Signature · 1 line
do kernel
Quoted 8 lines · Li Zefan
Quoted 3 lines · Harry Wei
Hi us,
Clean up CodingStyle forscripts/kconfig/gconf.c.What makes you think this is a bad style? Does
Documentation/CodingStylesay so? Does checkpatch.pl make a complain? Do you really think this improves readability? I don't think so, and actually it makes the code worse.
This include can be removed completely, there is no config.h in kconfig.
Michal