Skip to contentSkip to conversation

sctp: Make some local functions static

PATCH In review Holger Hans Peter Freyther 2 participants 2 messages Mar 23, 2011 – Mar 28, 2011

Subsystems (3)
Networking Network drivers SCTP protocol
lore
Share & tools
lore

Holger Hans Peter Freyther

author
#0 lore raw

PATCH 1/1 sctp: Make some local functions static

sparse proposed to mark these functions as static as they are only accessed locally. This patch is doing that.

Signed-off-by Holger Hans Peter Freyther <[email protected]>
Acked-by Wei Yongjun <[email protected]>
---
 net/sctp/probe.c         |   10 +++++-----
 net/sctp/sm_make_chunk.c |    4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)
net/sctp/probe.c +5 -4
index bc6cd75..4616548 100644
@@ -122,11 +122,11 @@ static const struct file_operations sctpprobe_fops = {
 	.llseek = noop_llseek,
 };
 -sctp_disposition_t jsctp_sf_eat_sack(const struct sctp_endpoint *ep,
-				     const struct sctp_association *asoc,
-				     const sctp_subtype_t type,
-				     void *arg,
-				     sctp_cmd_seq_t *commands)
+static sctp_disposition_t jsctp_sf_eat_sack(const struct sctp_endpoint *ep,
+					    const struct sctp_association *asoc,
+					    const sctp_subtype_t type,
+					    void *arg,
+					    sctp_cmd_seq_t *commands)
 {
 	struct sctp_transport *sp;
 	static __u32 lcwnd = 0;
net/sctp/sm_make_chunk.c +0 -0
index de98665..a8c0798 100644
@@ -132,8 +132,8 @@ void  sctp_init_cause(struct sctp_chunk *chunk, __be16

cause_code,
* abort chunk. Differs from sctp_init_cause in that it won't oops
* if there isn't enough space in the op error chunk
*/
-int sctp_init_cause_fixed(struct sctp_chunk *chunk, __be16 cause_code,
- size_t paylen)
+static int sctp_init_cause_fixed(struct sctp_chunk *chunk, __be16 cause_code,
+ size_t paylen)
{
sctp_errhdr_t err;
__u16 len;

Signature · 1 line
1.7.4
maintainer
#1 lore raw

From: Holger Hans Peter Freyther <[email protected]>
Date: Wed, 23 Mar 2011 11:48:07 +0100

Review void sctp_init_cause(struct sctp_chunk *chunk, __be16 · line 132

Quoted 2 lines
(quoted diff) +0 -0
@@ -132,8 +132,8 @@ void  sctp_init_cause(struct sctp_chunk *chunk, __be16
 cause_code,

Your patches are corrupted by your email client, in particular it has chopped up long lines.

Please fix your email setup, test it out by emailing both of your SCTP patches to yourself, then try to apply the patches in the emails you receive.

Then you can freshly resubmit them here.

Thank you.