Skip to contentSkip to conversation

solos-pci: Debugging fixes

PATCH In review Philip Prindeville 2 participants 2 messages Mar 28, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 solos-pci: Debugging fixes

Use VPI.VCI notation consistently.

---
 drivers/atm/solos-pci.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/atm/solos-pci.c +2 -2
index 25ef1a4..2c4146a 100644
@@ -710,8 +710,8 @@ void solos_bh(unsigned long card_arg)
 					       le16_to_cpu(header->vci));
 				if (!vcc) {
 					if (net_ratelimit())
-						dev_warn(&card->dev->dev, "Received packet for unknown VCI.VPI %d.%d on port %d\n",
-							 le16_to_cpu(header->vci), le16_to_cpu(header->vpi),
+						dev_warn(&card->dev->dev, "Received packet for unknown VPI.VCI %d.%d on port %d\n",
+							 le16_to_cpu(header->vpi), le16_to_cpu(header->vci),
 							 port);
 					continue;
 				}
maintainer
#1 lore raw

From: Philip Prindeville <[email protected]>
Date: Sun, 27 Mar 2011 19:02:54 -0700

Quoted 3 lines

Use VPI.VCI notation consistently.

The Subject line is where you describe what the change does.

If you use the same exact subject line in a set of changes, over and over again, people have no idea what distinguishes one of the change from the others.

Please fix up your commit messages so that the Subject lines are more informative.

Thanks.