Skip to contentSkip to conversation

solos-pci:Don't include pseudo-header in dump of frame

PATCH In review Philip Prindeville 2 participants 2 messages Mar 28, 2011

Subsystems (3)
Networking Network drivers ATM
lore
Share & tools
lore

Philip Prindeville

author
#0 lore raw

PATCH 2/2 solos-pci:Don't include pseudo-header in dump of frame

Don't include pseudo-header as part of frame hex-dump on transmit.

Signed-off-by Philip Prindeville<[email protected]>
---
 drivers/atm/solos-pci.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)
drivers/atm/solos-pci.c +8 -1
index 2c4146a..968f022 100644
@@ -697,7 +697,7 @@ void solos_bh(unsigned long card_arg)
 					      size);
 			}
 			if (atmdebug) {
-				dev_info(&card->dev->dev, "Received: device %d\n", port);
+				dev_info(&card->dev->dev, "Received: port %d\n", port);
 				dev_info(&card->dev->dev, "size: %d VPI: %d VCI: %d\n",
 					 size, le16_to_cpu(header->vpi),
 					 le16_to_cpu(header->vci));

@@ -1018,8 +1018,15 @@ static uint32_t fpga_tx(struct solos_card *card)
 
 			/* Clean up and free oldskb now it's gone */
 			if (atmdebug) {
+				struct pkt_hdr *header = (void *)oldskb->data;
+				int size = le16_to_cpu(header->size);
+
+				skb_pull(oldskb, sizeof(*header));
 				dev_info(&card->dev->dev, "Transmitted: port %d\n",
 					 port);
+				dev_info(&card->dev->dev, "size: %d VPI: %d VCI: %d\n",
+					 size, le16_to_cpu(header->vpi),
+					 le16_to_cpu(header->vci));
 				print_buffer(oldskb);
 			}
maintainer
#1 lore raw

From: Philip Prindeville <[email protected]>
Date: Sun, 27 Mar 2011 22:21:54 -0700

Quoted 1 line

Don't include pseudo-header as part of frame hex-dump on transmit.

Don't add this indentation in your commit messages, please.

Quoted 1 line
Signed-off-by Philip Prindeville<[email protected]>

Also, where is the respun patch #1?

This is getty real tiring.

We have extensive documentation about how to submit patches properly, you can start with Documentation/SubmittingPatches in the kernel sources.

When I ask you to make changes to a patch series, resubmit everything because I'm just going to mark whatever you submitted already as "Changes Requested".

Thanks.