Skip to contentSkip to conversation

Kirkwood: SATA supports only one device per bus

PATCH New Gray Remlin 3 participants 4 messages Mar 29, 2011 – Mar 30, 2011 Arm (32-bit)

lore
Share & tools
lore

Gray Remlin

author
#0 lore raw

PATCH 1/1 Kirkwood: SATA supports only one device per bus

Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1

Signed-off-by Gray Remlin <[email protected]>
---
 arch/arm/include/asm/arch-kirkwood/config.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/include/asm/arch-kirkwood/config.h +2 -1
index 71ba464..f582ba4 100644
@@ -128,7 +128,8 @@
 #define CONFIG_LBA48
 /* CONFIG_CMD_IDE requires some #defines for ATA registers */
 #define CONFIG_SYS_IDE_MAXBUS		2
-#define CONFIG_SYS_IDE_MAXDEVICE	2
+/* Only one device per bus on SATA */
+#define CONFIG_SYS_IDE_MAXDEVICE	1
 /* ATA registers base is at SATA controller base */
 #define CONFIG_SYS_ATA_BASE_ADDR	MV_SATA_BASE
 #endif /* CONFIG_CMD_IDE */
Signature · 1 line
1.7.4
#1 lore raw

PATCH 1/1 Kirkwood: SATA supports only one device per bus

Hi Gray,

Le 29/03/2011 21:42, Gray Remlin a ?crit :

Quoted 12 lines

Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1

Signed-off-by Gray Remlin<[email protected]>
---
  arch/arm/include/asm/arch-kirkwood/config.h |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/include/asm/arch-kirkwood/config.h +0 -0
index 71ba464..f582ba4 100644

arch/arm/include/asm/arch-kirkwood/config.h line 135

Quoted 9 lines
arch/arm/include/asm/arch-kirkwood/config.h +2 -1
@@ -128,7 +128,8 @@
  #define CONFIG_LBA48
  /* CONFIG_CMD_IDE requires some #defines for ATA registers */
  #define CONFIG_SYS_IDE_MAXBUS		2
-#define CONFIG_SYS_IDE_MAXDEVICE	2
+/* Only one device per bus on SATA */
+#define CONFIG_SYS_IDE_MAXDEVICE	1
  /* ATA registers base is at SATA controller base */
  #define CONFIG_SYS_ATA_BASE_ADDR	MV_SATA_BASE
  #endif /* CONFIG_CMD_IDE */

Did you cross-check this patch with Rogan's recent patch?

<http://patchwork.ozlabs.org/patch/87501/>

Amicalement,

Signature · 1 line
Albert.
author
#2 lore raw

PATCH 1/1 Kirkwood: SATA supports only one device per bus

Quoted 26 lines · Albert ARIBAUD

Hi Gray,

Le 29/03/2011 21:42, Gray Remlin a ?crit :

Quoted 12 lines

Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1

Signed-off-by Gray Remlin<[email protected]>
---
   arch/arm/include/asm/arch-kirkwood/config.h |    3 ++-
   1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/include/asm/arch-kirkwood/config.h +0 -0
index 71ba464..f582ba4 100644

arch/arm/include/asm/arch-kirkwood/config.h line 135

Quoted 9 lines
arch/arm/include/asm/arch-kirkwood/config.h +2 -1
@@ -128,7 +128,8 @@
   #define CONFIG_LBA48
   /* CONFIG_CMD_IDE requires some #defines for ATA registers */
   #define CONFIG_SYS_IDE_MAXBUS		2
-#define CONFIG_SYS_IDE_MAXDEVICE	2
+/* Only one device per bus on SATA */
+#define CONFIG_SYS_IDE_MAXDEVICE	1
   /* ATA registers base is at SATA controller base */
   #define CONFIG_SYS_ATA_BASE_ADDR	MV_SATA_BASE
   #endif /* CONFIG_CMD_IDE */

Did you cross-check this patch with Rogan's recent patch?

Quoted 3 lines

<http://patchwork.ozlabs.org/patch/87501/>

Amicalement,

No, this patch does not take Rogan's recent patch into consideration.

Rogan's patch does not address issues such as (from cmd_ide.c)

'array[CONFIG_SYS_IDE_MAXDEVICE]'

'for (i=0; i<CONFIG_SYS_IDE_MAXDEVICE; ++i)'

which will still be incorrect and will need to be patched up.

#3 lore raw

PATCH 1/1 Kirkwood: SATA supports only one device per bus

In reply to Gray Remlin
Quoted 10 lines

-----Original Message-----
From: Gray Remlin [mailto:gryrmln at gmail.com]
Sent: Wednesday, March 30, 2011 1:12 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Gray Remlin
Subject: [PATCH] Kirkwood: SATA supports only one device per bus

Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1

Kirkwood supports max 2
Why do you want this change?

Regards..
Prafulla ..

Quoted 23 lines
Signed-off-by Gray Remlin <[email protected]>
---
 arch/arm/include/asm/arch-kirkwood/config.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/include/asm/arch-kirkwood/config.h +2 -2
index 71ba464..f582ba4 100644
@@ -128,7 +128,8 @@
 #define CONFIG_LBA48
 /* CONFIG_CMD_IDE requires some #defines for ATA registers */
 #define CONFIG_SYS_IDE_MAXBUS		2
-#define CONFIG_SYS_IDE_MAXDEVICE	2
+/* Only one device per bus on SATA */
+#define CONFIG_SYS_IDE_MAXDEVICE	1
 /* ATA registers base is at SATA controller base */
 #define CONFIG_SYS_ATA_BASE_ADDR	MV_SATA_BASE
 #endif /* CONFIG_CMD_IDE */
--

1.7.4