Kirkwood: SATA supports only one device per bus

PATCH New Prafulla Wadaskar 3 participants 4 messages Mar 30, 2011

Share & tools

This one was a bit of a judgement call.
You are absolutely correct in what you say that Kirkwood supports two, but to the best of my knowledge, no one has yet implemented a board using both busses (I am not that familiar with OpenRD, I may have to eat my words).

For the sheevaplug, guruplug & dreamplug, it is definitely the case that only
one device can be attached.

Prafulla Wadaskar

author

2011-03-30 18:59 UTC #2 lore raw

PATCH 1/1 Kirkwood: SATA supports only one device per bus

Quoted 65 lines

-----Original Message-----
From: Gray Remlin [mailto:gryrmln at gmail.com]
Sent: Wednesday, March 30, 2011 7:21 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de
Subject: Re: [PATCH] Kirkwood: SATA supports only one device per bus
Quoted 17 lines · Prafulla Wadaskar
Quoted 17 lines
-----Original Message-----
From: Prafulla Wadaskar
Sent: Wednesday, March 30, 2011 4:48 PM
To: 'Gray Remlin'
Cc: u-boot at lists.denx.de; Prabhanjan Sarnaik; Ashish Karkare
Subject: RE: [PATCH] Kirkwood: SATA supports only one device per bus
Quoted 7 lines
-----Original Message-----
From: Gray Remlin [mailto:gryrmln at gmail.com]
Sent: Wednesday, March 30, 2011 1:12 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Gray Remlin
Subject: [PATCH] Kirkwood: SATA supports only one device per bus
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Change CONFIG_SYS_IDE_MAXDEVICE from 2 to 1
Kirkwood supports max 2
Why do you want this change?
Hi Gray
I take back my words. I will study more and let you know my comments
on this.
Quoted 22 lines
Sorry for noise.
Regards..
Prafulla . .
Quoted 17 lines
Regards..
Prafulla ..
Quoted 14 lines
Signed-off-by Gray Remlin<[email protected]>
---
  arch/arm/include/asm/arch-kirkwood/config.h |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/include/asm/arch-kirkwood/config.h +0 -0
index 71ba464..f582ba4 100644
@@ -128,7 +128,8 @@
  #define CONFIG_LBA48
  /* CONFIG_CMD_IDE requires some #defines for ATA registers */
  #define CONFIG_SYS_IDE_MAXBUS		2
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
arch/arm/include/asm/arch-kirkwood/config.h +2 -2
-#define CONFIG_SYS_IDE_MAXDEVICE	2
+/* Only one device per bus on SATA */
+#define CONFIG_SYS_IDE_MAXDEVICE	1
  /* ATA registers base is at SATA controller base */
  #define CONFIG_SYS_ATA_BASE_ADDR	MV_SATA_BASE
  #endif /* CONFIG_CMD_IDE */
--
1.7.4
Hi Prafulla,

Quoted 6 lines

This one was a bit of a judgement call.
You are absolutely correct in what you say that Kirkwood supports two, but
to the best of my knowledge, no one has yet implemented a board using both busses (I am not that familiar with OpenRD, I may have to eat my words).

OpenRD-Base board has two, one e-sata for external hdd and one sata for onboard hdd interface, I am using them :-)

Regards..
Prafulla . .

Quoted 10 lines

For the sheevaplug, guruplug & dreamplug, it is definitely the case that only
one device can be attached.

Albert ARIBAUD

2011-03-30 19:51 UTC #3 lore raw

PATCH 1/1 Kirkwood: SATA supports only one device per bus

Le 30/03/2011 20:59, Prafulla Wadaskar a ?crit :

Quoted 5 lines

Quoted 3 lines
to the best of my knowledge, no one has yet implemented a board using both busses (I am not that familiar with OpenRD, I may have to eat my words).
OpenRD-Base board has two, one e-sata for external hdd and one sata for onboard hdd interface, I am using them :-)

In which case it makes sense to keep CONFIG_SYS_IDE_MAXDEVICE set to 2 in the common code and redefine it to 1 in board configs that only implement one, does it not?

Amicalement,

Signature · 1 line

Albert.