Input: atmel_mxt_ts - Increase the wait times for backup and reset
Subsystems (3)
PATCH 1/2 Input: atmel_mxt_ts - Increase the wait times for backup and reset
Increase the sleep times after backup and reset, so that we can be sure they have been completed even when the mXT cycle time is set to maximum value (254ms).
--- drivers/input/touchscreen/atmel_mxt_ts.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/input/touchscreen/atmel_mxt_ts.c +2 -2
@@ -169,8 +169,8 @@/* Define for MXT_GEN_COMMAND */ #define MXT_BOOT_VALUE 0xa5#define MXT_BACKUP_VALUE 0x55 -#define MXT_BACKUP_TIME 25/* msec */ -#define MXT_RESET_TIME 65/* msec */ +#define MXT_BACKUP_TIME 270/* msec */ +#define MXT_RESET_TIME 350/* msec */ #define MXT_FWRESET_TIME 175/* msec */
Signature · 1 line
1.7.0.4
Hi, Iiro.
2011/3/17 Iiro Valkonen <[email protected]>:
Quoted 12 lines
Increase the sleep times after backup and reset, so that we can be sure they have been completed even when the mXT cycle time is set to maximum value (254ms).
Signed-off-by Iiro Valkonen <[email protected]>---
drivers/input/touchscreen/atmel_mxt_ts.c | 4 ++--1 files changed, 2 insertions(+), 2 deletions(-)drivers/input/touchscreen/atmel_mxt_ts.c +0
-0
drivers/input/touchscreen/atmel_mxt_ts.c line 173
Quoted 7 lines
drivers/input/touchscreen/atmel_mxt_ts.c +2
-2@@ -169,8 +169,8 @@ /* Define for MXT_GEN_COMMAND */ #define MXT_BOOT_VALUE 0xa5 #define MXT_BACKUP_VALUE 0x55 -#define MXT_BACKUP_TIME 25/* msec */ -#define MXT_RESET_TIME 65/* msec */ +#define MXT_BACKUP_TIME 270/* msec */ +#define MXT_RESET_TIME 350/* msec */
I wonder mXT cycle time is alterable and if reset and backup time is desided by mXT cycle time, i think they can be used to variable.
Signature · 5 lines
- Joonyoung Shim -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 8 lines · Joonyoung Shim
drivers/input/touchscreen/atmel_mxt_ts.c line 173
Quoted 4 lines
drivers/input/touchscreen/atmel_mxt_ts.c +2
-2-#define MXT_BACKUP_TIME 25/* msec */ -#define MXT_RESET_TIME 65/* msec */ +#define MXT_BACKUP_TIME 270/* msec */ +#define MXT_RESET_TIME 350/* msec */ I wonder mXT cycle time is alterable and if reset and backup time is desided by mXT cycle time, i think they can be used to variable.
I agree, waiting for 270 + 350 ms might be overkill. The correct way to do this would be to wait for the chip to indicate it has completed the backup and reset. I will send a new patch that implements this.
BR,
Signature · 1 line
Iiro