Skip to contentSkip to conversation

Provide pr_debug() and pr_info().

PATCH New Alexander Holler 2 participants 3 messages Apr 1, 2011

Subsystems (2)
MMC, SD and SDIO Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

Alexander Holler

author
#0 lore raw

PATCH 1/1 Provide pr_debug() and pr_info().

Those are usefull for compatibility with the kernel. Remove the locally defined pr_debug() in atmel_mci.c.

Signed-off-by Alexander Holler <[email protected]>
---
 drivers/mmc/atmel_mci.c |    6 ------
 include/common.h        |    4 ++++
 2 files changed, 4 insertions(+), 6 deletions(-)
drivers/mmc/atmel_mci.c +0 -6
index 3946ffe..9d798ca 100644
@@ -32,12 +32,6 @@
 
 #include "atmel_mci.h"
 
-#ifdef DEBUG
-#define pr_debug(fmt, args...) printf(fmt, ##args)
-#else
-#define pr_debug(...) do { } while(0)
-#endif
-
 #ifndef CONFIG_SYS_MMC_CLK_OD
 #define CONFIG_SYS_MMC_CLK_OD		150000
 #endif
include/common.h +4 -0
index 893af5c..a1fe8df 100644
@@ -119,11 +119,15 @@ typedef volatile unsigned char	vu_char;
 #ifdef	DEBUG
 #define debug(fmt,args...)	printf (fmt ,##args)
 #define debugX(level,fmt,args...) if (DEBUG>=level) printf(fmt,##args);
+#define pr_debug(fmt, args...) printf(fmt, ##args)
 #else
 #define debug(fmt,args...)
 #define debugX(level,fmt,args...)
+#define pr_debug(fmt, args...)
 #endif	/* DEBUG */
 
+#define pr_info(fmt, args...)	printf (fmt, ##args)
+
 #define error(fmt, args...) do {					\
 		printf("ERROR: " fmt "\nat %s:%d/%s()\n",		\
 			##args, __FILE__, __LINE__, __func__);		\
Signature · 1 line
1.7.3.4
#1 lore raw

PATCH 1/1 Provide pr_debug() and pr_info().

Dear Alexander Holler,

Quoted 8 lines · In message <[email protected]> you wrote:

Those are usefull for compatibility with the kernel. Remove the locally defined pr_debug() in atmel_mci.c.

Signed-off-by Alexander Holler <[email protected]>
---
 drivers/mmc/atmel_mci.c |    6 ------
 include/common.h        |    4 ++++
 2 files changed, 4 insertions(+), 6 deletions(-)

NAK. This is just adding redundant overhead. I don;t want to have yet another incarnation of macros which already exist.

Either replace the code in drivers/mmc/atmel_mci.c by a simple

	#define pr_debug(fmt, args...) debug(fmt, ##args)

or convert the code that uses this reference.

And pr_info() is completrely redundant and not used anywhere.

If you really think that pr_debug() is so much better than debug(), then convert ALL code to use that. But I am not a friend of such a change.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"When the only  tool  you  have  is  a  hammer,  you  tend  to  treat
everything as if it were a nail."                    - Abraham Maslow
author
#2 lore raw

PATCH 1/1 Provide pr_debug() and pr_info().

Hello,

Am 01.04.2011 19:56, schrieb Wolfgang Denk:

Quoted 19 lines

Dear Alexander Holler,

Quoted 8 lines · In message<[email protected]> you wrote:

Those are usefull for compatibility with the kernel. Remove the locally defined pr_debug() in atmel_mci.c.

Signed-off-by Alexander Holler<[email protected]>
---
  drivers/mmc/atmel_mci.c |    6 ------
  include/common.h        |    4 ++++
  2 files changed, 4 insertions(+), 6 deletions(-)

NAK. This is just adding redundant overhead. I don;t want to have yet another incarnation of macros which already exist.

Either replace the code in drivers/mmc/atmel_mci.c by a simple

	#define pr_debug(fmt, args...) debug(fmt, ##args)
Quoted 8 lines

or convert the code that uses this reference.

And pr_info() is completrely redundant and not used anywhere.

If you really think that pr_debug() is so much better than debug(), then convert ALL code to use that. But I am not a friend of such a change.

Than just forget this patch and someone else should add those macros to future imports of sources from the kernel. At least I will now do so.

Regards,

Alexander Holler