MX31: mx31pdk: fix nand_spl
PATCH 1/2 MX31: mx31pdk: fix nand_spl
Commit f326cbba98bae21d41df8daac0bd78121d557af1 breaks mx31pdk, as the _end section in u-boot.lds is missing for the nand_spl production.
--- nand_spl/board/freescale/mx31pdk/u-boot.lds | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
nand_spl/board/freescale/mx31pdk/u-boot.lds +2 -0
@@ -63,6 +63,8 @@ SECTIONS *(.dynsym) } + _end = .; + .bss __rel_dyn_start (OVERLAY) : { __bss_start = .; *(.bss)
Signature · 1 line
1.7.1
PATCH 1/2 MX31: mx31pdk: fix nand_spl
Hi Stefano,
Le 03/04/2011 12:01, Stefano Babic a ?crit :
Quoted 3 lines
Commit
f326cbba98bae21d41df8daac0bd78121d557af1breaks mx31pdk, as the_endsection inu-boot.ldsis missing for thenand_splproduction.
What command line should one use to reproduce the issue? I just did a ./MAKEALL mx31pdk from the current u-boot-arm master branch and it builds fine, which I suspect sould not be possible if it missed the _end symbol.
Amicalement,
Signature · 1 line
Albert.
PATCH 1/2 MX31: mx31pdk: fix nand_spl
Quoted 2 lines · Albert ARIBAUD
Hi Stefano,
Hi Albert,
Quoted 6 lines
Le 03/04/2011 12:01, Stefano Babic a ?crit :
Quoted 3 lines
Commit
f326cbba98bae21d41df8daac0bd78121d557af1breaks mx31pdk, as the_endsection inu-boot.ldsis missing for thenand_splproduction.What command line should one use to reproduce the issue?
you should issue mx31pdk_nand. I do not know why there is a special target in the Makefile, I do not think this is necessary and only boards.cfg could be used. But this has nothing to do with the reported error, answering your question I have seen something else strange ;-)
Quoted 4 lines
I just did a
./MAKEALL mx31pdk from the current u-boot-arm master branch and it builds fine, which I suspect sould not be possible if it missed the_endsymbol.
The mx31pdk supports booting from NOR or from NAND, using two different configuration. You compiled for NOR, and everything works fine - only the nand_spl part has this issue.
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
PATCH 1/2 MX31: mx31pdk: fix nand_spl
In reply to Albert ARIBAUDHi Albert,
Quoted 6 lines · Albert ARIBAUD
From: Albert ARIBAUD <[email protected]>
Subject: Re: [U-Boot] [PATCH 1/2] MX31: mx31pdk: fixnand_spl
To: u-boot at lists.denx.de
Date: Sunday, April 3, 2011, 9:08 AM
Hi Stefano,
Quoted 8 lines
Le 03/04/2011 12:01, Stefano Babic a ?crit :
Quoted 1 line
Commit
f326cbba98bae21d41df8daac0bd78121d557af1breaksmx31pdk,
Quoted 1 line
as the
_endsection inu-boot.ldsis missing for the
nand_splQuoted 1 line
production.
What command line should one use to reproduce the issue? I
Please do a ?make mx31pdk_nand_config?
Regards,
Fabio Estevam
PATCH 1/2 MX31: mx31pdk: fix nand_spl
In reply to Stefano BabicHi Stefano,
Quoted 3 lines · Stefano Babic
Commit
f326cbba98bae21d41df8daac0bd78121d557af1breaks mx31pdk, as the_endsection inu-boot.ldsis missing for thenand_splproduction.
After applying your patch I was able to build and boot MX31PDK from NAND, so here goes my:
Quoted 1 line
Signed-off-by Stefano Babic <[email protected]>
Regards,
Fabio Estevam
PATCH 1/2 MX31: mx31pdk: fix nand_spl
Le 04/04/2011 00:04, Fabio Estevam a ?crit :
Quoted 10 lines
Hi Stefano,
Quoted 3 lines · Stefano Babic
Commit
f326cbba98bae21d41df8daac0bd78121d557af1breaks mx31pdk, as the_endsection inu-boot.ldsis missing for thenand_splproduction.After applying your patch I was able to build and boot MX31PDK from NAND, so here goes my:
Quoted 6 lines
Quoted 1 line
Signed-off-by Stefano Babic<[email protected]>Tested-by Fabio Estevam<[email protected]>Regards,
Fabio Estevam
Applied to u-boot-arm/master, thanks!
Amicalement,
Signature · 1 line
Albert.