HID: Add NOGET quirk for the CH Pro Throttle

The CH Pro Throttle needs the NOGET quirk flag to work, just like other CH Products devices which already have the flag set.

Signed-off-by Unavowed <[email protected]>

---
 drivers/hid/hid-ids.h           |    1 +
 drivers/hid/usbhid/hid-quirks.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

drivers/hid/hid-ids.h +1 -0

index 65ac53d..1a9f996 100644
@@ -150,6 +150,7 @@
 #define USB_DEVICE_ID_CANDO_MULTI_TOUCH_15_6 0x0f01
 
 #define USB_VENDOR_ID_CH		0x068e
+#define USB_DEVICE_ID_CH_PRO_THROTTLE	0x00f1
 #define USB_DEVICE_ID_CH_PRO_PEDALS	0x00f2
 #define USB_DEVICE_ID_CH_COMBATSTICK	0x00f4
 #define USB_DEVICE_ID_CH_FLIGHT_SIM_ECLIPSE_YOKE       0x0051

drivers/hid/usbhid/hid-quirks.c +1 -0

index 9a94b64..a8426f1 100644
@@ -59,6 +59,7 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_CH, USB_DEVICE_ID_CH_COMBATSTICK, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_CH, USB_DEVICE_ID_CH_FLIGHT_SIM_ECLIPSE_YOKE, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_CH, USB_DEVICE_ID_CH_FLIGHT_SIM_YOKE, HID_QUIRK_NOGET },
+	{ USB_VENDOR_ID_CH, USB_DEVICE_ID_CH_PRO_THROTTLE, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_CH, USB_DEVICE_ID_CH_PRO_PEDALS, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_CH, USB_DEVICE_ID_CH_3AXIS_5BUTTON_STICK, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_CH, USB_DEVICE_ID_CH_AXIS_295, HID_QUIRK_NOGET },

Signature · 1 line

1.7.3.4

Quoted 3 lines · Unavowed

The CH Pro Throttle needs the NOGET quirk flag to work, just like other CH Products devices which already have the flag set.

Quoted 1 line

Signed-off-by Unavowed <[email protected]>

Hi,

thanks a lot for the patch.

Would it please be possible to have a real name to attribute for patch authorship and Signed-off-by line?

Quoted 11 lines

Quoted 4 lines

The CH Pro Throttle needs the NOGET quirk flag to work, just like other CH Products devices which already have the flag set.

Signed-off-by Unavowed <[email protected]>

Hi,

thanks a lot for the patch.

Would it please be possible to have a real name to attribute for patch authorship and Signed-off-by line?

Hi,

Thanks for such a quick response.

I'm sorry, but I only ever write contributions under a pseudonym. Is this not acceptable, especially for such a trivial patch?

Quoted 16 lines · Unavowed

Quoted 11 lines

Quoted 4 lines

The CH Pro Throttle needs the NOGET quirk flag to work, just like other CH Products devices which already have the flag set.

Signed-off-by Unavowed <[email protected]>

Hi,

thanks a lot for the patch.

Would it please be possible to have a real name to attribute for patch authorship and Signed-off-by line?

Hi,

Thanks for such a quick response.

Quoted 2 lines

I'm sorry, but I only ever write contributions under a pseudonym. Is this not acceptable, especially for such a trivial patch?

Well, see paragraph 12) of Documentation/SubmittingPatches. Especially the part with "sorry, no pseudonyms or anonymous contributions".

Now, I agree that trivial USB ID addition such as this really is a bit borderline ...

Quoted 8 lines

Quoted 2 lines

I'm sorry, but I only ever write contributions under a pseudonym. Is this not acceptable, especially for such a trivial patch?

Well, see paragraph 12) of Documentation/SubmittingPatches. Especially the part with "sorry, no pseudonyms or anonymous contributions".

Now, I agree that trivial USB ID addition such as this really is a bit borderline ...

If that's the case then I would like to report a bug. The HID device:

068e:00f1 CH Products, Inc. Pro Throttle

doesn't work with Linux. After plugging in the device, it is recognised but pressing buttons or moving axes doesn't trigger any events. Adding an entry to the HID blacklist with the HID_QUIRK_NOGET flag fixes the problem.

I, and probably other flight sim fans running Linux, would be very happy if someone could fix write a patch fixing this.

And if I may comment on that "no pseudonyms" policy, I don't fully understand the motivation behind it. After all, there have been many authors of copyrighted works who created them without revealing their real name[1]. Is this something to please the lawyers of Linux's corporate overlords?

Quoted 2 lines

I, and probably other flight sim fans running Linux, would be very happy if someone could fix write a patch fixing this.

I thought you'd figure that out :) Thanks for the report, I have queued the fix in my tree.

Quoted 5 lines

And if I may comment on that "no pseudonyms" policy, I don't fully understand the motivation behind it. After all, there have been many authors of copyrighted works who created them without revealing their real name[1]. Is this something to please the lawyers of Linux's corporate overlords?

I guess this would be topic for a separate thread, but anyway ... but I believe you'd be able to dig much information from reading the threads where entity calling itself 'Shem Multinymous' tried to submit Thinkpad Embedded Controller drivers.

It basically defeats the Developer's Certificate of Origin process completely.