Skip to contentSkip to conversation

powerpc/85xx: Add 36-bit address map support to P1022DS

PATCH New Kumar Gala 4 participants 18 messages Mar 7, 2011 – Apr 9, 2011

Subsystems (2)
lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/6 powerpc/85xx: Add 36-bit address map support to P1022DS

From: Jiang Yutang <[email protected]>

---
 board/freescale/p1022ds/p1022ds.c |    3 ++
 boards.cfg                        |    1 +
 include/configs/P1022DS.h         |   46 ++++++++++++++++++++++++++++++++++++-
 3 files changed, 49 insertions(+), 1 deletions(-)
board/freescale/p1022ds/p1022ds.c +3 -0
index 62beafa..6f20dc3 100644
@@ -53,6 +53,9 @@ int checkboard(void)
 	u8 sw;
 
 	puts("Board: P1022DS ");
+#ifdef CONFIG_PHYS_64BIT
+	puts("(36-bit addrmap) ");
+#endif
 
 	printf("Sys ID: 0x%02x, Sys Ver: 0x%02x, FPGA Ver: 0x%02x, ",
 		in_8(&pixis->id), in_8(&pixis->arch), in_8(&pixis->scver));
boards.cfg +1 -0
index 263c1e6..2622f78 100644
@@ -523,6 +523,7 @@ P1020RDB_NAND                powerpc     mpc85xx     p1_p2_rdb           freesca
 P1020RDB_SDCARD              powerpc     mpc85xx     p1_p2_rdb           freescale      -           P1_P2_RDB:P1020RDB,SDCARD
 P1020RDB_SPIFLASH            powerpc     mpc85xx     p1_p2_rdb           freescale      -           P1_P2_RDB:P1020RDB,SPIFLASH
 P1022DS                      powerpc     mpc85xx     p1022ds             freescale
+P1022DS_36BIT                powerpc     mpc85xx     p1022ds             freescale      -           P1022DS:36BIT
 P2010RDB                     powerpc     mpc85xx     p1_p2_rdb           freescale      -           P1_P2_RDB:P2010RDB
 P2010RDB_36BIT               powerpc     mpc85xx     p1_p2_rdb           freescale      -           P1_P2_RDB:P2010RDB,36BIT
 P2010RDB_36BIT_SDCARD        powerpc     mpc85xx     p1_p2_rdb           freescale      -           P1_P2_RDB:P2010RDB,36BIT,SDCARD
include/configs/P1022DS.h +45 -1

114 lines not on this page · raw message

Signature · 1 line
1.7.2.3
author
#2 lore raw

PATCH 2/6 powerpc/85xx: Enable support for ATI graphics cards on P1022DS

In reply to Kumar Gala

From: Jiang Yutang <[email protected]>

Make the support for ATI graphics cards mutually exclusive with DIU.

---
 include/configs/P1022DS.h |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)
include/configs/P1022DS.h +16 -0
index c15cb8d..b3cb135 100644
@@ -220,6 +220,22 @@
 #undef CONFIG_SYS_FLASH_EMPTY_INFO
 #endif
 
+#ifndef CONFIG_DIU
+#define CONFIG_ATI
+#endif
+
+#ifdef CONFIG_ATI
+#define VIDEO_IO_OFFSET		CONFIG_SYS_PCIE1_IO_VIRT
+#define CONFIG_VIDEO
+#define CONFIG_BIOSEMU
+#define CONFIG_VIDEO_SW_CURSOR
+#define CONFIG_ATI_RADEON_FB
+#define CONFIG_VIDEO_LOGO
+#define CONFIG_SYS_ISA_IO_BASE_ADDRESS VIDEO_IO_OFFSET
+#define CONFIG_CFB_CONSOLE
+#define CONFIG_VGA_AS_SINGLE_DEVICE
+#endif
+
 /*
  * Pass open firmware flat tree
  */
Signature · 1 line
1.7.2.3
author
#4 lore raw

PATCH 3/6 powerpc/85xx: Added DIU configs for P1022DS and fixed LVDS config

In reply to Kumar Gala

From: Jiang Yutang <[email protected]>

Added two build configurations with DIU enabled on P1022DS and fixed the configuration for LVDS monitors to enable backlighting.

---
 board/freescale/p1022ds/diu.c |    7 +++++--
 boards.cfg                    |    2 ++
 include/configs/P1022DS.h     |    4 +++-
 3 files changed, 10 insertions(+), 3 deletions(-)
board/freescale/p1022ds/diu.c +5 -2
index b37e0e2..15f95c6 100644
@@ -105,14 +105,17 @@ int platform_diu_init(unsigned int *xres, unsigned int *yres)
 		*xres = 1024;
 		*yres = 768;
 		/* Enable the DFP port, disable the DVI and the backlight */
-		temp &= ~(PX_BRDCFG1_DVIEN | PX_BRDCFG1_BACKLIGHT);
-		temp |= PX_BRDCFG1_DFPEN;
+		temp &= ~PX_BRDCFG1_DVIEN;
+		/* LVDS also needs backlight enabled, otherwise the display will be blank */
+		temp |= (PX_BRDCFG1_DFPEN | PX_BRDCFG1_BACKLIGHT);
+		printf("DIU link to 1-LVDS\n");
 	} else {	/* DVI */
 		*xres = 1280;
 		*yres = 1024;
 		/* Enable the DVI port, disable the DFP and the backlight */
 		temp &= ~(PX_BRDCFG1_DFPEN | PX_BRDCFG1_BACKLIGHT);
 		temp |= PX_BRDCFG1_DVIEN;
+		printf("DIU link to 0-DVI\n");
 	}
 
 	out_8(&pixis->brdcfg1, temp);
boards.cfg +2 -0
index 2622f78..02212bb 100644
@@ -524,6 +524,8 @@ P1020RDB_SDCARD              powerpc     mpc85xx     p1_p2_rdb           freesca
 P1020RDB_SPIFLASH            powerpc     mpc85xx     p1_p2_rdb           freescale      -           P1_P2_RDB:P1020RDB,SPIFLASH
 P1022DS                      powerpc     mpc85xx     p1022ds             freescale
 P1022DS_36BIT                powerpc     mpc85xx     p1022ds             freescale      -           P1022DS:36BIT
+P1022DS_36BIT_DIU            powerpc     mpc85xx     p1022ds             freescale      -           P1022DS:36BIT,DIU
+P1022DS_DIU                  powerpc     mpc85xx     p1022ds             freescale      -           P1022DS:DIU
 P2010RDB                     powerpc     mpc85xx     p1_p2_rdb           freescale      -           P1_P2_RDB:P2010RDB
 P2010RDB_36BIT               powerpc     mpc85xx     p1_p2_rdb           freescale      -           P1_P2_RDB:P2010RDB,36BIT
 P2010RDB_36BIT_SDCARD        powerpc     mpc85xx     p1_p2_rdb           freescale      -           P1_P2_RDB:P2010RDB,36BIT,SDCARD
include/configs/P1022DS.h +3 -1
index b3cb135..cac7f66 100644
@@ -202,7 +202,9 @@
 #define CONFIG_SYS_PROMPT_HUSH_PS2 "> "
 
 /* Video */
-#undef CONFIG_FSL_DIU_FB
+#ifdef CONFIG_DIU
+#define CONFIG_FSL_DIU_FB
+#endif
 
 #ifdef CONFIG_FSL_DIU_FB
 #define CONFIG_SYS_DIU_ADDR	(CONFIG_SYS_CCSRBAR + 0x10000)
Signature · 1 line
1.7.2.3
author
#5 lore raw

PATCH 4/6 powerpc/85xx: Add support usb2/etsec and tdm/audio pin multiplex on P1022DS

From: Jiang Yutang <[email protected]>

For soc which have pin multiplex relation, some of them can't enable simultaneously. This patch add environment var 'hwconfig' content defination for them. you can enable some one function by setting environment var 'hwconfig' content and reset board. Detail setting please refer doc/README.p1022ds

---
 arch/powerpc/include/asm/immap_85xx.h |    8 +++++
 board/freescale/p1022ds/p1022ds.c     |   50 +++++++++++++++++++++++++-------
 doc/README.p1022ds                    |   24 ++++++++++++++++
 3 files changed, 71 insertions(+), 11 deletions(-)
 create mode 100644 doc/README.p1022ds
arch/powerpc/include/asm/immap_85xx.h +8 -0
index 5118fe0..690bb3a 100644
@@ -1937,7 +1937,15 @@ typedef struct ccsr_gur {
 #define MPC85xx_PMUXCR_QE10		0x00000020
 #define MPC85xx_PMUXCR_QE11		0x00000010
 #define MPC85xx_PMUXCR_QE12		0x00000008
+#if defined(CONFIG_P1013) || defined(CONFIG_P1022)
+#define MPC85xx_PMUXCR_TDM_MASK		0x0001cc00
+#define MPC85xx_PMUXCR_TDM		0x00014800
+#endif
 	u32	pmuxcr2;	/* Alt. function signal multiplex control 2 */
+#if defined(CONFIG_P1013) || defined(CONFIG_P1022)
+#define MPC85xx_PMUXCR2_ETSECUSB_MASK	0x001f1000
+#define MPC85xx_PMUXCR2_USB		0x00150000
+#endif
 	u8	res6[8];
 	u32	devdisr;	/* Device disable control */
 #define MPC85xx_DEVDISR_PCI1		0x80000000
board/freescale/p1022ds/p1022ds.c +39 -11

72 lines not on this page · raw message

doc/README.p1022ds new file +24 -0
new file mode 100644
index 0000000..473ecf6
@@ -0,0 +1,24 @@
+Overview
+--------
+P1022ds is a Low End Dual core platform supporting the P1022 processor
+of QorIQ series. P1022 is an e500 based dual core SOC.
+
+
+Pin Multiplex(hwconfig setting)
+-------------------------------
+Add the environment 'usb2', 'audclk' and 'tdm' to support pin multiplex
+via hwconfig, i.e:
+'setenv hwconfig usb2' to enable USB2 and disable eTsec2
+'setenv hwconfig tdm' to enable TDM and disable Audio
+'setenv hwconfig audclk:12' to enable Audio(codec clock sources is 12MHz)
+ and disable TDM
+'setenv hwconfig 'usb2;tdm' to enable USB2 and TDM, disable eTsec2 and Audio
+'setenv hwconfig 'usb2;audclk:11' to enable USB2 and Audio(codec clock sources
+ is 11MHz), disable eTsec2 and TDM
+
+Warning: TDM and AUDIO can not enable simultaneous !
+and AUDIO codec clock sources only setting as 11MHz or 12MHz !
+'setenv hwconfig 'audclk:12;tdm'	--- error !
+'setenv hwconfig 'audclk:11;tdm'	--- error !
+'setenv hwconfig 'audclk:10'		--- error !
+
Signature · 1 line
1.7.2.3
author Applied
#6 lore raw

PATCH 4/6 powerpc/85xx: Add support usb2/etsec and tdm/audio pin multiplex on P1022DS

Quoted 8 lines · Kumar Gala

From: Jiang Yutang <[email protected]>

For soc which have pin multiplex relation, some of them can't enable simultaneously. This patch add environment var 'hwconfig' content defination for them. you can enable some one function by setting environment var 'hwconfig' content and reset board. Detail setting please refer doc/README.p1022ds

Quoted 8 lines

---

arch/powerpc/include/asm/immap_85xx.h |    8 +++++
board/freescale/p1022ds/p1022ds.c     |   50 +++++++++++++++++++++++++-------
doc/README.p1022ds                    |   24 ++++++++++++++++
3 files changed, 71 insertions(+), 11 deletions(-)

create mode 100644 doc/README.p1022ds

applied to 85xx

- k

author
#7 lore raw

PATCH v2 4/6 powerpc/85xx: Add support usb2/etsec and tdm/audio pin multiplex on P1022DS

In reply to Kumar Gala

From: Jiang Yutang <[email protected]>

For soc which have pin multiplex relation, some of them can't enable simultaneously. This patch add environment var 'hwconfig' content defination for them. you can enable some one function by setting environment var 'hwconfig' content and reset board. Detail setting please refer doc/README.p1022ds

---
* TDM need some configration option by SPI, so enable SPI while enable TDM.

 arch/powerpc/include/asm/immap_85xx.h |   10 ++++++
 board/freescale/p1022ds/p1022ds.c     |   56 ++++++++++++++++++++++++++------
 doc/README.p1022ds                    |   24 ++++++++++++++
 3 files changed, 79 insertions(+), 11 deletions(-)
 create mode 100644 doc/README.p1022ds
arch/powerpc/include/asm/immap_85xx.h +10 -0
index 5118fe0..b51017b 100644
@@ -1937,7 +1937,17 @@ typedef struct ccsr_gur {
 #define MPC85xx_PMUXCR_QE10		0x00000020
 #define MPC85xx_PMUXCR_QE11		0x00000010
 #define MPC85xx_PMUXCR_QE12		0x00000008
+#if defined(CONFIG_P1013) || defined(CONFIG_P1022)
+#define MPC85xx_PMUXCR_TDM_MASK		0x0001cc00
+#define MPC85xx_PMUXCR_TDM		0x00014800
+#define MPC85xx_PMUXCR_SPI_MASK		0x00600000
+#define MPC85xx_PMUXCR_SPI		0x00000000
+#endif
 	u32	pmuxcr2;	/* Alt. function signal multiplex control 2 */
+#if defined(CONFIG_P1013) || defined(CONFIG_P1022)
+#define MPC85xx_PMUXCR2_ETSECUSB_MASK	0x001f1000
+#define MPC85xx_PMUXCR2_USB		0x00150000
+#endif
 	u8	res6[8];
 	u32	devdisr;	/* Device disable control */
 #define MPC85xx_DEVDISR_PCI1		0x80000000
board/freescale/p1022ds/p1022ds.c +45 -11

78 lines not on this page · raw message

doc/README.p1022ds new file +24 -0
new file mode 100644
index 0000000..473ecf6
@@ -0,0 +1,24 @@
+Overview
+--------
+P1022ds is a Low End Dual core platform supporting the P1022 processor
+of QorIQ series. P1022 is an e500 based dual core SOC.
+
+
+Pin Multiplex(hwconfig setting)
+-------------------------------
+Add the environment 'usb2', 'audclk' and 'tdm' to support pin multiplex
+via hwconfig, i.e:
+'setenv hwconfig usb2' to enable USB2 and disable eTsec2
+'setenv hwconfig tdm' to enable TDM and disable Audio
+'setenv hwconfig audclk:12' to enable Audio(codec clock sources is 12MHz)
+ and disable TDM
+'setenv hwconfig 'usb2;tdm' to enable USB2 and TDM, disable eTsec2 and Audio
+'setenv hwconfig 'usb2;audclk:11' to enable USB2 and Audio(codec clock sources
+ is 11MHz), disable eTsec2 and TDM
+
+Warning: TDM and AUDIO can not enable simultaneous !
+and AUDIO codec clock sources only setting as 11MHz or 12MHz !
+'setenv hwconfig 'audclk:12;tdm'	--- error !
+'setenv hwconfig 'audclk:11;tdm'	--- error !
+'setenv hwconfig 'audclk:10'		--- error !
+
Signature · 1 line
1.7.2.3
author Applied
#8 lore raw

PATCH v2 4/6 powerpc/85xx: Add support usb2/etsec and tdm/audio pin multiplex on P1022DS

Quoted 8 lines · Kumar Gala

From: Jiang Yutang <[email protected]>

For soc which have pin multiplex relation, some of them can't enable simultaneously. This patch add environment var 'hwconfig' content defination for them. you can enable some one function by setting environment var 'hwconfig' content and reset board. Detail setting please refer doc/README.p1022ds

Quoted 4 lines

---
* TDM need some configration option by SPI, so enable SPI while enable TDM.

applied to 85xx

- k

author
#9 lore raw

PATCH 5/6 powerpc/85xx: Update default hwconfig on P1022DS

In reply to Kumar Gala

From: Jiang Yutang <[email protected]>

Set default configuration to have SDHC controller enabled, AUDIO enabled(codec clock sources is 12MHz) and disable TDM.

---
 include/configs/P1022DS.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/configs/P1022DS.h +1 -0
index cac7f66..ad10550 100644
@@ -511,6 +511,7 @@
 	"dium=mw e002c01c\0" 						\
 	"diuerr=md e002c014 1\0" 					\
 	"othbootargs=diufb=15M video=fslfb:1280x1024-32 at 60,monitor=0 tty0\0" \
+	"hwconfig=esdhc;audclk:12\0"					\
 	"monitor=0-DVI\0"
 
 #define CONFIG_HDBOOT					\
Signature · 1 line
1.7.2.3
author Applied
#10 lore raw

PATCH 5/6 powerpc/85xx: Update default hwconfig on P1022DS

Quoted 10 lines · Kumar Gala

From: Jiang Yutang <[email protected]>

Set default configuration to have SDHC controller enabled, AUDIO enabled(codec clock sources is 12MHz) and disable TDM.

---
include/configs/P1022DS.h | 1 +

1 files changed, 1 insertions(+), 0 deletions(-)

applied to 85xx

- k

author
#11 lore raw

PATCH 6/6 powerpc/85xx: Add SHARP LQ084S3LG01 LCD support on P1022DS

In reply to Kumar Gala

From: Jiang Yutang <[email protected]>

SHARP LQ084S3LG01 TFT LCD is the default configuration with P1022DS RevC board. It only support 800x600 resolutions. While using DIU's DVI or
LVDS ports, some environment var should be setting:

DVI:
'setenv monitor 0'
'setenv resolution 1280x1024'

LVDS(default):
'setenv monitor 1'
'setenv resolution 800x600'

environment var 'othbootargs' should be:
othbootargs=diufb=15M video=fslfb: $resolution -32 at 60,monitor=$monitor tty0

Save environment var 'monitor' as '0' or '1' then reset board, DIU will change signal out to DVI or LVDS. DIU driver will according environment var 'monitor' to automatic setting environment var 'resolution' as 800x600(SHARP LQ084S3LG01 LCD) or 1280x1024(DELL monitor).

---
 board/freescale/p1022ds/diu.c |    8 ++++++--
 doc/README.p1022ds            |   22 ++++++++++++++++++++++
 drivers/video/fsl_diu_fb.c    |   20 +++++++++++++++++++-
 include/configs/P1022DS.h     |    6 ++++--
 4 files changed, 51 insertions(+), 5 deletions(-)
board/freescale/p1022ds/diu.c +6 -2
index 15f95c6..d4fbc4f 100644
@@ -102,12 +102,14 @@ int platform_diu_init(unsigned int *xres, unsigned int *yres)
 
 	monitor_port = getenv("monitor");
 	if (!strncmp(monitor_port, "1", 1)) { /* 1 - Single link LVDS */
-		*xres = 1024;
-		*yres = 768;
+		*xres = 800;
+		*yres = 600;
 		/* Enable the DFP port, disable the DVI and the backlight */
 		temp &= ~PX_BRDCFG1_DVIEN;
 		/* LVDS also needs backlight enabled, otherwise the display will be blank */
 		temp |= (PX_BRDCFG1_DFPEN | PX_BRDCFG1_BACKLIGHT);
+		setenv("monitor", "1");
+		setenv("resolution", "800x600");
 		printf("DIU link to 1-LVDS\n");
 	} else {	/* DVI */
 		*xres = 1280;
@@ -115,6 +117,8 @@ int platform_diu_init(unsigned int *xres, unsigned int *yres)
 		/* Enable the DVI port, disable the DFP and the backlight */
 		temp &= ~(PX_BRDCFG1_DFPEN | PX_BRDCFG1_BACKLIGHT);
 		temp |= PX_BRDCFG1_DVIEN;
+		setenv("monitor", "0");
+		setenv("resolution", "1280x1024");
 		printf("DIU link to 0-DVI\n");
 	}
 
doc/README.p1022ds +22 -0
index 473ecf6..77db2f6 100644
@@ -22,3 +22,25 @@ and AUDIO codec clock sources only setting as 11MHz or 12MHz !
 'setenv hwconfig 'audclk:11;tdm'	--- error !
 'setenv hwconfig 'audclk:10'		--- error !
 
+
+DIU Display Setting
+-------------------------------
+P1022ds DIU can link to DVI or LVDS, DVI can connect to DELL monitor(1280x1024 resolution)
+and LVDS can connect to SHARP LQ084S3LG01 LCD(only support 800x600 resolution) on board.
+Before using DIU, please check following environment var setting:
+
+DVI:
+'setenv monitor 0'
+'setenv resolution 1280x1024'
+
+LVDS(default):
+'setenv monitor 1'
+'setenv resolution 800x600'
+
+environment var 'othbootargs' should be:
+othbootargs=diufb=15M video=fslfb: $resolution -32 at 60,monitor=$monitor tty0
+
+Save environment var 'monitor' as '0' or '1' then reset board, DIU will change signal out to DVI or LVDS.
+DIU driver will according environment var 'monitor' to automatic setting environment var 'resolution' as
+800x600(SHARP LQ084S3LG01 LCD) or 1280x1024(DELL monitor).
+
drivers/video/fsl_diu_fb.c +19 -1
index 35ed938..1e3e6a2 100644
@@ -1,5 +1,5 @@
 /*
- * Copyright 2007, 2010 Freescale Semiconductor, Inc.
+ * Copyright 2007, 2011 Freescale Semiconductor, Inc.
  * York Sun <[email protected]>
  *
  * FSL DIU Framebuffer driver
@@ -51,6 +51,23 @@ struct fb_videomode {
 #define FB_SYNC_COMP_HIGH_ACT	8	/* composite sync high active   */
 #define FB_VMODE_NONINTERLACED  0	/* non interlaced */
 
+#ifdef CONFIG_SHARP_LQ084S3LG01_TFT_LCD
+static struct fb_videomode fsl_diu_mode_800 = {
+	.name		= "800x600-60",
+	.refresh	= 60,
+	.xres		= 800,
+	.yres		= 600,
+	.pixclock	= 25000,
+	.left_margin	= 88,
+	.right_margin	= 40,
+	.upper_margin	= 23,
+	.lower_margin	= 1,
+	.hsync_len	= 128,
+	.vsync_len	= 4,
+	.sync		= FB_SYNC_COMP_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
+	.vmode		= FB_VMODE_NONINTERLACED
+};
+#else
 /* This setting is used for the ifm pdm360ng with PRIMEVIEW PM070WL3 */
 static struct fb_videomode fsl_diu_mode_800 = {
 	.refresh	= 60,
@@ -66,6 +83,7 @@ static struct fb_videomode fsl_diu_mode_800 = {
 	.sync		= 0,
 	.vmode		= FB_VMODE_NONINTERLACED
 };
+#endif
 
 /*
  * These parameters give default parameters
include/configs/P1022DS.h +4 -2
index ad10550..fd2d869 100644
@@ -220,6 +220,7 @@
  * disable empty flash sector detection, which is I/O-intensive.
  */
 #undef CONFIG_SYS_FLASH_EMPTY_INFO
+#define CONFIG_SHARP_LQ084S3LG01_TFT_LCD
 #endif
 
 #ifndef CONFIG_DIU
@@ -510,9 +511,10 @@
 	"diuregs=md e002c000 1d\0"			 		\
 	"dium=mw e002c01c\0" 						\
 	"diuerr=md e002c014 1\0" 					\
-	"othbootargs=diufb=15M video=fslfb:1280x1024-32 at 60,monitor=0 tty0\0" \
+	"othbootargs=diufb=15M video=fslfb: $resolution -32 at 60,monitor=$monitor tty0\0" \
 	"hwconfig=esdhc;audclk:12\0"					\
-	"monitor=0-DVI\0"
+	"monitor=0\0"							\
+	"resolution=800x600\0"
 
 #define CONFIG_HDBOOT					\
 	"setenv bootargs root=/dev/$bdev rw "		\
Signature · 1 line
1.7.2.3
author
#12 lore raw

PATCH 6/6 powerpc/85xx: Add SHARP LQ084S3LG01 LCD support on P1022DS

Quoted 22 lines · Kumar Gala

From: Jiang Yutang <[email protected]>

SHARP LQ084S3LG01 TFT LCD is the default configuration with P1022DS RevC board. It only support 800x600 resolutions. While using DIU's DVI or LVDS ports, some environment var should be setting:

DVI:
'setenv monitor 0'
'setenv resolution 1280x1024'

LVDS(default):
'setenv monitor 1'
'setenv resolution 800x600'

environment var 'othbootargs' should be:
othbootargs=diufb=15M video=fslfb: $resolution -32 at 60,monitor=$monitor tty0

Save environment var 'monitor' as '0' or '1' then reset board, DIU will change signal out to DVI or LVDS. DIU driver will according environment var 'monitor' to automatic setting environment var 'resolution' as 800x600(SHARP LQ084S3LG01 LCD) or 1280x1024(DELL monitor).

Quoted 8 lines

---

board/freescale/p1022ds/diu.c |    8 ++++++--
doc/README.p1022ds            |   22 ++++++++++++++++++++++
drivers/video/fsl_diu_fb.c    |   20 +++++++++++++++++++-
include/configs/P1022DS.h     |    6 ++++--
4 files changed, 51 insertions(+), 5 deletions(-)

Timur,

what about this patch?

- k

#13 lore raw

PATCH 6/6 powerpc/85xx: Add SHARP LQ084S3LG01 LCD support on P1022DS

Quoted 1 line · Kumar Gala

what about this patch?

I missed this one. Unfortunately, it conflicts with my patch. I'll have to rewrite this one to make it work.

Plus, there were problems with it. For instance, I'm not crazy about the setenv() calls (I NAK'd an earlier internal version of this patch that had similar calls).

I'll take care of it next week.

Signature · 2 lines
Timur Tabi
Linux kernel developer
#14 lore raw

PATCH 6/6 powerpc/85xx: Add SHARP LQ084S3LG01 LCD support on P1022DS

In reply to Kumar Gala

Dear Kumar Gala,

Quoted 10 lines · In message <[email protected]> you wrote:
Quoted 6 lines
board/freescale/p1022ds/diu.c |    8 ++++++--
doc/README.p1022ds            |   22 ++++++++++++++++++++++
drivers/video/fsl_diu_fb.c    |   20 +++++++++++++++++++-
include/configs/P1022DS.h     |    6 ++++--
4 files changed, 51 insertions(+), 5 deletions(-)

Timur,

what about this patch?

It needs Anatolij's ACK!

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Celestial navigation is based on the premise that the  Earth  is  the
center  of  the  universe.  The  premise is wrong, but the navigation
works. An incorrect model can be a useful tool.   - Kelvin Throop III
#15 lore raw

PATCH 3/6 powerpc/85xx: Added DIU configs for P1022DS and fixed LVDS config

In reply to Kumar Gala
Quoted 11 lines · Kumar Gala

From: Jiang Yutang <[email protected]>

Added two build configurations with DIU enabled on P1022DS and fixed the configuration for LVDS monitors to enable backlighting.

---

?board/freescale/p1022ds/diu.c | ? ?7 +++++--
?boards.cfg ? ? ? ? ? ? ? ? ? ?| ? ?2 ++
?include/configs/P1022DS.h ? ? | ? ?4 +++-

Just a heads-up, this will cause a merge conflict with my patch, "[v4]
powerpc: clean up DIU macro definitions for Freescale reference boards", which was posted about three weeks ago.

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
author
#16 lore raw

PATCH 3/6 powerpc/85xx: Added DIU configs for P1022DS and fixed LVDS config

Quoted 13 lines · Timur Tabi
Quoted 11 lines · Kumar Gala

From: Jiang Yutang <[email protected]>

Added two build configurations with DIU enabled on P1022DS and fixed the configuration for LVDS monitors to enable backlighting.

---
 board/freescale/p1022ds/diu.c |    7 +++++--
 boards.cfg                    |    2 ++
 include/configs/P1022DS.h     |    4 +++-
Quoted 3 lines

Just a heads-up, this will cause a merge conflict with my patch, "[v4]
powerpc: clean up DIU macro definitions for Freescale reference boards", which was posted about three weeks ago.

I'll deal with merge issues, can you ack or provide feedback on this patch

- k

#17 lore raw

PATCH 3/6 powerpc/85xx: Added DIU configs for P1022DS and fixed LVDS config

Quoted 1 line · Kumar Gala

I'll deal with merge issues, can you ack or provide feedback on this patch

My patch, "[v3] powerpc: user 'video-mode' environment variable to configure DIU" ("user" should be "use") should be applied instead.

Signature · 2 lines
Timur Tabi
Linux kernel developer