Skip to contentSkip to conversation

RDMA/cxgb4: missing parentheses

PATCH In review roel 3 participants 3 messages Apr 10, 2011 – Apr 11, 2011

Subsystems (2)
InfiniBand CXGB4 iWARP RNIC driver (IW_CXGB4)
lore
Share & tools
lore

roel

author
#0 lore raw

PATCH 1/1 RDMA/cxgb4: missing parentheses

Parens are missing: '|' has a higher presedence than '?'.

Signed-off-by Roel Kluin <[email protected]>
---
 drivers/infiniband/hw/cxgb4/qp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/infiniband/hw/cxgb4/qp.c +1 -1
index 70a5a3c..80cab20 100644
@@ -214,7 +214,7 @@ static int create_qp(struct c4iw_rdev *rdev, struct t4_wq *wq,
 		V_FW_RI_RES_WR_HOSTFCMODE(0) |	/* no host cidx updates */
 		V_FW_RI_RES_WR_CPRIO(0) |	/* don't keep in chip cache */
 		V_FW_RI_RES_WR_PCIECHN(0) |	/* set by uP at ri_init time */
-		t4_sq_onchip(&wq->sq) ? F_FW_RI_RES_WR_ONCHIP : 0 |
+		(t4_sq_onchip(&wq->sq) ? F_FW_RI_RES_WR_ONCHIP : 0) |
 		V_FW_RI_RES_WR_IQID(scq->cqid));
 	res->u.sqrq.dcaen_to_eqsize = cpu_to_be32(
 		V_FW_RI_RES_WR_DCAEN(0) |

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Acked-by on v1 1/1
#1 lore raw
Acked-by Steve Wise <[email protected]>
Quoted 20 lines · roel

Parens are missing: '|' has a higher presedence than '?'.

Signed-off-by Roel Kluin<[email protected]>
---
  drivers/infiniband/hw/cxgb4/qp.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
drivers/infiniband/hw/cxgb4/qp.c +1 -1
index 70a5a3c..80cab20 100644
@@ -214,7 +214,7 @@ static int create_qp(struct c4iw_rdev *rdev, struct t4_wq *wq,
  		V_FW_RI_RES_WR_HOSTFCMODE(0) |	/* no host cidx updates */
  		V_FW_RI_RES_WR_CPRIO(0) |	/* don't keep in chip cache */
  		V_FW_RI_RES_WR_PCIECHN(0) |	/* set by uP at ri_init time */
-		t4_sq_onchip(&wq->sq) ? F_FW_RI_RES_WR_ONCHIP : 0 |
+		(t4_sq_onchip(&wq->sq) ? F_FW_RI_RES_WR_ONCHIP : 0) |
  		V_FW_RI_RES_WR_IQID(scq->cqid));
  	res->u.sqrq.dcaen_to_eqsize = cpu_to_be32(
  		V_FW_RI_RES_WR_DCAEN(0) |