slub: Fix a typo in config name

PATCH In review Li Zefan 3 participants 4 messages Apr 12, 2011 – Apr 13, 2011

Subsystems (2)

Memory management Slab allocator

lore

Share & tools

lore

Li Zefan

author

2011-04-12 07:19 UTC #0 lore raw

PATCH 1/1 slub: Fix a typo in config name

There's no config named SLAB_DEBUG, and it should be a typo of SLUB_DEBUG.

Signed-off-by Li Zefan <[email protected]>

---

not slub expert, don't know how this bug affects slub debugging.

---
 mm/slub.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

mm/slub.c +1 -1

index 94d2a33..df77f78 100644
@@ -3203,7 +3203,7 @@ static void __init kmem_cache_bootstrap_fixup(struct kmem_cache *s)
 			list_for_each_entry(p, &n->partial, lru)
 				p->slab = s;
 
-#ifdef CONFIG_SLAB_DEBUG
+#ifdef CONFIG_SLUB_DEBUG
 			list_for_each_entry(p, &n->full, lru)
 				p->slab = s;
 #endif

Signature · 8 lines

1.7.3.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Christoph Lameter

Acked-by on v1 1/1

2011-04-12 18:02 UTC #1 lore raw

Quoted 7 lines · Li Zefan

There's no config named SLAB_DEBUG, and it should be a typo of SLUB_DEBUG.
Signed-off-by Li Zefan <[email protected]>
---
not slub expert, don't know how this bug affects slub debugging.

Affects the bootstrap code.

Acked-by Christoph Lameter <[email protected]>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

David Rientjes

reviewer

2011-04-13 02:16 UTC #2 lore raw

Quoted 5 lines · Christoph Lameter

Quoted 3 lines · Li Zefan
There's no config named SLAB_DEBUG, and it should be a typo of SLUB_DEBUG.

Quoted 7 lines

Quoted 4 lines
Signed-off-by Li Zefan <[email protected]>
---
not slub expert, don't know how this bug affects slub debugging.
Affects the bootstrap code.

I don't see how, there should be no partial or full slabs for either kmem_cache or kmem_cache_node at this point in the boot sequence. I think kmem_cache_bootstrap_fixup() should only need to add the cache to the list of slab caches and set the refcount accordingly.

Christoph Lameter

2011-04-13 13:36 UTC #3 lore raw

Quoted 12 lines · David Rientjes

Quoted 10 lines · Christoph Lameter
Quoted 7 lines · Li Zefan
There's no config named SLAB_DEBUG, and it should be a typo of SLUB_DEBUG.
Signed-off-by Li Zefan <[email protected]>
---
not slub expert, don't know how this bug affects slub debugging.

Quoted 7 lines

Quoted 2 lines
Affects the bootstrap code.
I don't see how, there should be no partial or full slabs for either kmem_cache or kmem_cache_node at this point in the boot sequence. I think kmem_cache_bootstrap_fixup() should only need to add the cache to the list of slab caches and set the refcount accordingly.

Hmmm... That depends on the number of objects in a slab page. If that is one then we may have an issue.