NFS: don't negotiate when user specifies sec flavor

PATCH New Bryan Schumaker 1 participant 1 message Apr 13, 2011

Subsystems (2)

NFS client NFS server

lore

Share & tools

lore

Bryan Schumaker

author

2011-04-13 18:31 UTC #0 lore raw

PATCH 5/6 NFS: don't negotiate when user specifies sec flavor

We were always attempting sec flavor negotiation, even if the user told us a specific sec flavor to use. If that sec flavor fails, we should return an error rather than continuing with sec flavor negotiation.

Signed-off-by Bryan Schumaker <[email protected]>

---
 fs/nfs/nfs4proc.c |    3 ++-
 fs/nfs/super.c    |    1 +
 2 files changed, 3 insertions(+), 1 deletions(-)

fs/nfs/nfs4proc.c +2 -1

index 7e27ebf..b8e1ac6 100644
@@ -46,6 +46,7 @@
 #include <linux/nfs4.h>
 #include <linux/nfs_fs.h>
 #include <linux/nfs_page.h>
+#include <linux/nfs_mount.h>
 #include <linux/namei.h>
 #include <linux/mount.h>
 #include <linux/module.h>

@@ -2234,7 +2235,7 @@ static int nfs4_proc_get_root(struct nfs_server *server, struct nfs_fh *fhandle,
 			      struct nfs_fsinfo *info)
 {
 	int status = nfs4_lookup_root(server, fhandle, info);
-	if (status == -EPERM)
+	if ((status == -EPERM) && !(server->flags & NFS_MOUNT_SECFLAVOUR))
 		status = nfs4_find_root_sec(server, fhandle, info);
 	if (status == 0)
 		status = nfs4_server_capabilities(server, fhandle);

fs/nfs/super.c +1 -0

index 2b8e9a5..74482e6 100644
@@ -1004,6 +1004,7 @@ static int nfs_parse_security_flavors(char *value,
 		return 0;
 	}
 
+	mnt->flags |= NFS_MOUNT_SECFLAVOUR;
 	mnt->auth_flavor_len = 1;
 	return 1;
 }

Signature · 1 line

1.7.4.4