arm: Tegra2: Fix out of tree builds
PATCH 1/1 arm: Tegra2: Fix out of tree builds
Create the board/nvidia/common directory in the out of tree build directory.
Without this patch building out of tree results in a failure to create the board.o file in the build directory tree.
---
An alternative solution would be to create a Makefile in the common directory that creates an object/library that each board depends on. I'm not sure which is better.
board/nvidia/harmony/Makefile | 2 ++ board/nvidia/seaboard/Makefile | 2 ++ 2 files changed, 4 insertions(+), 0 deletions(-)
board/nvidia/harmony/Makefile +2 -0
@@ -24,6 +24,8 @@ include $(TOPDIR)/config.mk +$(shell mkdir -p $(obj)../common) + LIB = $(obj)lib$(BOARD).o COBJS += ../common/board.o
board/nvidia/seaboard/Makefile +2 -0
@@ -24,6 +24,8 @@ include $(TOPDIR)/config.mk +$(shell mkdir -p $(obj)../common) + LIB = $(obj)lib$(BOARD).o COBJS += ../common/board.o
Signature · 1 line
1.7.3.1
PATCH 1/1 arm: Tegra2: Fix out of tree builds
Hi Anton,
Sorry for the dela in replying.
Le 05/04/2011 23:33, Anton Staaf a ?crit :
Quoted 6 lines
Create the board/nvidia/common directory in the out of tree build directory.
Without this patch building out of tree results in a failure to create the board.o file in the build directory tree.
Quoted 8 lines
Signed-off-by Anton Staaf<[email protected]>Cc Tom Warren<[email protected]>Cc Albert ARIBAUD<[email protected]>---
An alternative solution would be to create a
Makefilein the common directory that creates an object/library that each board depends on. I'm not sure which is better.
I'd prefer the alternative solution -- the issue is with a common directory, so it seems logical that the solution is in the common part of the code rather than spread over the non-common variants.
Amicalement,
Signature · 1 line
Albert.
PATCH 1/1 arm: Tegra2: Fix out of tree builds
No worries.
Quoted 11 lines · Albert ARIBAUD
Quoted 6 lines
An alternative solution would be to create a
Makefilein the common directory
that creates an object/library that each board depends on. ?I'm not sure which
is better.I'd prefer the alternative solution -- the issue is with a common directory, so it seems logical that the solution is in the common part of the code rather than spread over the non-common variants.
Yes, that makes perfect sense. I'll make the change.
Thanks,
Anton