xfs build warning
on i386, when CONFIG_LBDAF is not enabled:
fs/xfs/linux-2.6/./xfs_trace.h:1354: warning: format '%llx' expects type 'long long unsigned int', but argument 22 has type 'xfs_fsblock_t'
Signature · 6 lines
~Randy _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 3 lines · Randy Dunlap
on i386, when
CONFIG_LBDAFis not enabled:
fs/xfs/linux-2.6/./xfs_trace.h:1354: warning: format '%llx' expects type 'long long unsigned int', but argument 22 has type 'xfs_fsblock_t'
This should fix it:
fs/xfs/linux-2.6/xfs_trace.h +1 -1
@@ -1418,7 +1418,7 @@ DECLARE_EVENT_CLASS(xfs_alloc_class, __entry->wasfromfl, __entry->isfl, __entry->userdata, - __entry->firstblock) + (unsigned long long)__entry->firstblock) )#define DEFINE_ALLOC_EVENT (name) \
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Randy Dunlap
Acked-byQuoted 12 lines · Christoph Hellwig
Quoted 3 lines · Randy Dunlap
on i386, when
CONFIG_LBDAFis not enabled:
fs/xfs/linux-2.6/./xfs_trace.h:1354: warning: format '%llx' expects type 'long long unsigned int', but argument 22 has type 'xfs_fsblock_t'This should fix it:
Index:
linux-2.6/fs/xfs/linux-2.6/xfs_trace.h
===================================================================
fs/xfs/linux-2.6/xfs_trace.h DECLARE_EVENT_CLASS(xfs_alloc_class, · line 1424
Quoted 8 lines
fs/xfs/linux-2.6/xfs_trace.h +1
-1@@ -1418,7 +1418,7 @@ DECLARE_EVENT_CLASS(xfs_alloc_class, __entry->wasfromfl, __entry->isfl, __entry->userdata, - __entry->firstblock) + (unsigned long long)__entry->firstblock) )#define DEFINE_ALLOC_EVENT (name) \
Thanks.
Signature · 6 lines
~Randy _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Alex Elder
Reviewed-byQuoted 6 lines · Christoph Hellwig
Quoted 3 lines · Randy Dunlap
on i386, when
CONFIG_LBDAFis not enabled:
fs/xfs/linux-2.6/./xfs_trace.h:1354: warning: format '%llx' expects type 'long long unsigned int', but argument 22 has type 'xfs_fsblock_t'This should fix it:
Looks good. Christoph, can I assume your signoff?
I wonder whether we'll ever need to cast the other fields that are based on abstractions from __uint32_t (like xfs_agblock_t, xfs_extlen_t, ...).
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 6 lines · Alex Elder
Quoted 5 lines · Christoph Hellwig
Quoted 3 lines · Randy Dunlap
on i386, when
CONFIG_LBDAFis not enabled:
fs/xfs/linux-2.6/./xfs_trace.h:1354: warning: format '%llx' expects type 'long long unsigned int', but argument 22 has type 'xfs_fsblock_t'
Quoted 7 lines
Quoted 1 line
This should fix it:
Looks good. Christoph, can I assume your signoff?
I wonder whether we'll ever need to cast the other fields that are based on abstractions from
__uint32_t(likexfs_agblock_t,xfs_extlen_t, ...).
I'll resend it with a proper changelog and signoff.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs