Skip to contentSkip to conversation

mp2usb: remove board support

PATCH New Eric Bénard 3 participants 13 messages Apr 3, 2011 – May 12, 2011

Subsystems (2)
Kbuild Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

Eric Bénard

author
#0 lore raw

PATCH 1/3 mp2usb: remove board support

this board was cancelled long time ago so remove it as it won't be maintained anymore

Signed-off-by Eric B?nard <[email protected]>
---
 board/mp2usb/Makefile    |   50 -----
 board/mp2usb/config.mk   |    3 -
 board/mp2usb/flash.c     |  552 ----------------------------------------------
 board/mp2usb/mp2usb.c    |   98 --------
 boards.cfg               |    1 -
 include/configs/mp2usb.h |  242 --------------------
 6 files changed, 0 insertions(+), 946 deletions(-)
 delete mode 100644 board/mp2usb/Makefile
 delete mode 100644 board/mp2usb/config.mk
 delete mode 100644 board/mp2usb/flash.c
 delete mode 100644 board/mp2usb/mp2usb.c
 delete mode 100644 include/configs/mp2usb.h
board/mp2usb/Makefile deleted +0 -50
deleted file mode 100644
index 335734a..0000000
@@ -1,50 +0,0 @@
-#
-# (C) Copyright 2003-2006
-# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
-#
-# See file CREDITS for list of people who contributed to this
-# project.
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of
-# the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
-# MA 02111-1307 USA
-#
-
-include $(TOPDIR)/config.mk
-
-LIB	= $(obj)lib$(BOARD).o
-
-COBJS	:= mp2usb.o flash.o
-
-SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
-OBJS	:= $(addprefix $(obj),$(COBJS))
-SOBJS	:= $(addprefix $(obj),$(SOBJS))
-
-$(LIB):	$(obj).depend $(OBJS)
-	$(call cmd_link_o_target, $(OBJS))
-
-clean:
-	rm -f $(SOBJS) $(OBJS)
-
-distclean:	clean
-	rm -f $(LIB) core *.bak $(obj).depend
-
-#########################################################################
-
-# defines $(obj).depend target
-include $(SRCTREE)/rules.mk
-
-sinclude $(obj).depend
-
-#########################################################################
board/mp2usb/config.mk deleted +0 -3
deleted file mode 100644
index 948e4ff..0000000
@@ -1,3 +0,0 @@
-CONFIG_SYS_TEXT_BASE = 0x27F00000
-## For testing: load at 0x20100000 and "go" at 0x201000A4
-#CONFIG_SYS_TEXT_BASE = 0x20100000
board/mp2usb/flash.c deleted +0 -552

552 lines not on this page · raw message

board/mp2usb/mp2usb.c deleted +0 -98

98 lines not on this page · raw message

boards.cfg +0 -1
index 45c3102..105c748 100644
@@ -56,7 +56,6 @@ cmc_pu2                      arm         arm920t     -                   -
 csb637                       arm         arm920t     -                   -              at91rm9200
 kb9202                       arm         arm920t     -                   -              at91rm9200
 m501sk                       arm         arm920t     -                   -              at91rm9200
-mp2usb                       arm         arm920t     -                   -              at91rm9200
 at91rm9200dk                 arm         arm920t     -                   atmel          at91rm9200
 mx1ads                       arm         arm920t     -                   -              imx
 mx1fs2                       arm         arm920t     -                   -              imx
include/configs/mp2usb.h deleted +0 -242

242 lines not on this page · raw message

Signature · 1 line
1.7.4
author
#1 lore raw

PATCH 2/3 cpu9260: update board support

- update to new relocation code
- switch to boards.cfg
- get rid of LEGACY (still a little hack in .h to compile)
- add nand boot configuration
- boot tested for the following configurations :

	9260 (64MB RAM & nor boot)
	9260_nand (64MB RAM & nand boot)
	9G20_128M (128MB RAM & nor boot)
	9G20_nand_128M (128MB RAM & nand boot)
	(nor boot is using lowlevel init)
Signed-off-by Eric B?nard <[email protected]>
---
 board/eukrea/cpu9260/config.mk |    1 -
 board/eukrea/cpu9260/cpu9260.c |  161 +++++++++++--------------
 board/eukrea/cpu9260/led.c     |   36 +++---
 boards.cfg                     |    8 ++
 include/configs/cpu9260.h      |  265 +++++++++++++++++++++++++---------------
 5 files changed, 263 insertions(+), 208 deletions(-)
 delete mode 100644 board/eukrea/cpu9260/config.mk
board/eukrea/cpu9260/config.mk deleted +0 -1
deleted file mode 100644
index 2077692..0000000
@@ -1 +0,0 @@
-CONFIG_SYS_TEXT_BASE = 0x21f00000
board/eukrea/cpu9260/cpu9260.c +69 -92

232 lines not on this page · raw message

board/eukrea/cpu9260/led.c +19 -17
index e73543b..d0906bc 100644
@@ -35,65 +35,67 @@ static unsigned int saved_state[4] = {STATUS_LED_OFF, STATUS_LED_OFF,
 
 void coloured_LED_init(void)
 {
+	at91_pmc_t *pmc = (at91_pmc_t *) AT91_PMC_BASE;
+
 	/* Enable clock */
-	at91_sys_write(AT91_PMC_PCER, 1 << AT91SAM9260_ID_PIOC);
+	writel(1 << AT91SAM9260_ID_PIOC, &pmc->pcer);
 
-	at91_set_gpio_output(CONFIG_RED_LED, 1);
-	at91_set_gpio_output(CONFIG_GREEN_LED, 1);
-	at91_set_gpio_output(CONFIG_YELLOW_LED, 1);
-	at91_set_gpio_output(CONFIG_BLUE_LED, 1);
+	at91_set_pio_output(CONFIG_RED_LED, 1);
+	at91_set_pio_output(CONFIG_GREEN_LED, 1);
+	at91_set_pio_output(CONFIG_YELLOW_LED, 1);
+	at91_set_pio_output(CONFIG_BLUE_LED, 1);
 
-	at91_set_gpio_value(CONFIG_RED_LED, 1);
-	at91_set_gpio_value(CONFIG_GREEN_LED, 1);
-	at91_set_gpio_value(CONFIG_YELLOW_LED, 1);
-	at91_set_gpio_value(CONFIG_BLUE_LED, 1);
+	at91_set_pio_value(CONFIG_RED_LED, 1);
+	at91_set_pio_value(CONFIG_GREEN_LED, 1);
+	at91_set_pio_value(CONFIG_YELLOW_LED, 1);
+	at91_set_pio_value(CONFIG_BLUE_LED, 1);
 }
 
 void red_LED_off(void)
 {
-	at91_set_gpio_value(CONFIG_RED_LED, 1);
+	at91_set_pio_value(CONFIG_RED_LED, 1);
 	saved_state[STATUS_LED_RED] = STATUS_LED_OFF;
 }
 
 void green_LED_off(void)
 {
-	at91_set_gpio_value(CONFIG_GREEN_LED, 1);
+	at91_set_pio_value(CONFIG_GREEN_LED, 1);
 	saved_state[STATUS_LED_GREEN] = STATUS_LED_OFF;
 }
 
 void yellow_LED_off(void)
 {
-	at91_set_gpio_value(CONFIG_YELLOW_LED, 1);
+	at91_set_pio_value(CONFIG_YELLOW_LED, 1);
 	saved_state[STATUS_LED_YELLOW] = STATUS_LED_OFF;
 }
 
 void blue_LED_off(void)
 {
-	at91_set_gpio_value(CONFIG_BLUE_LED, 1);
+	at91_set_pio_value(CONFIG_BLUE_LED, 1);
 	saved_state[STATUS_LED_BLUE] = STATUS_LED_OFF;
 }
 
 void red_LED_on(void)
 {
-	at91_set_gpio_value(CONFIG_RED_LED, 0);
+	at91_set_pio_value(CONFIG_RED_LED, 0);
 	saved_state[STATUS_LED_RED] = STATUS_LED_ON;
 }
 
 void green_LED_on(void)
 {
-	at91_set_gpio_value(CONFIG_GREEN_LED, 0);
+	at91_set_pio_value(CONFIG_GREEN_LED, 0);
 	saved_state[STATUS_LED_GREEN] = STATUS_LED_ON;
 }
 
 void yellow_LED_on(void)
 {
-	at91_set_gpio_value(CONFIG_YELLOW_LED, 0);
+	at91_set_pio_value(CONFIG_YELLOW_LED, 0);
 	saved_state[STATUS_LED_YELLOW] = STATUS_LED_ON;
 }
 
 void blue_LED_on(void)
 {
-	at91_set_gpio_value(CONFIG_BLUE_LED, 0);
+	at91_set_pio_value(CONFIG_BLUE_LED, 0);
 	saved_state[STATUS_LED_BLUE] = STATUS_LED_ON;
 }
boards.cfg +8 -0
index 105c748..2f0d1df 100644
@@ -72,6 +72,14 @@ omap1510inn                  arm         arm925t     -                   ti
 aspenite                     arm         arm926ejs   -                   Marvell        armada100
 afeb9260                     arm         arm926ejs   -                   -              at91
 at91cap9adk                  arm         arm926ejs   -                   atmel          at91
+cpu9260                      arm         arm926ejs   cpu9260             eukrea         at91        cpu9260:CPU9260
+cpu9260_nand                 arm         arm926ejs   cpu9260             eukrea         at91        cpu9260:CPU9260,NANDBOOT
+cpu9260_128M                 arm         arm926ejs   cpu9260             eukrea         at91        cpu9260:CPU9260,CPU9260_128M
+cpu9260_nand_128M            arm         arm926ejs   cpu9260             eukrea         at91        cpu9260:CPU9260,CPU9260_128M,NANDBOOT
+cpu9G20                      arm         arm926ejs   cpu9260             eukrea         at91        cpu9260:CPU9G20
+cpu9G20_nand                 arm         arm926ejs   cpu9260             eukrea         at91        cpu9260:CPU9G20,NANDBOOT
+cpu9G20_128M                 arm         arm926ejs   cpu9260             eukrea         at91        cpu9260:CPU9G20,CPU9G20_128M
+cpu9G20_nand_128M            arm         arm926ejs   cpu9260             eukrea         at91        cpu9260:CPU9G20,CPU9G20_128M,NANDBOOT
 top9000eval_xe               arm         arm926ejs   top9000             emk            at91        top9000:EVAL9000
 top9000su_xe                 arm         arm926ejs   top9000             emk            at91        top9000:SU9000
 meesc                        arm         arm926ejs   -                   esd            at91
include/configs/cpu9260.h +167 -98

416 lines not on this page · raw message

Signature · 1 line
1.7.4
author
#2 lore raw

PATCH 2/3 cpu9260: update board support

Hi,

Quoted 5 lines · Eric B?nard

- update to new relocation code
- switch to boards.cfg
- get rid of LEGACY (still a little hack in .h to compile)
- add nand boot configuration
- boot tested for the following configurations :

Quoted 8 lines
	9260 (64MB RAM&  nor boot)
	9260_nand (64MB RAM&  nand boot)
	9G20_128M (128MB RAM&  nor boot)
	9G20_nand_128M (128MB RAM&  nand boot)
	(nor boot is using lowlevel init)
Signed-off-by Eric B?nard<[email protected]>

---

any news concerning this patch ?
http://patchwork.ozlabs.org/patch/89540/

Thanks,
Eric

#3 lore raw

PATCH 2/3 cpu9260: update board support

In reply to Eric Bénard

Le 03/04/2011 18:35, Eric B?nard a ?crit :

Quoted 7 lines
board/eukrea/cpu9260/cpu9260.c +0 -0
index 61b6c33..9ec48a0 100644
@@ -188,26 +175,16 @@ int board_init(void)

board/eukrea/cpu9260/cpu9260.c int board_init(void) · line 179

Quoted 10 lines
board/eukrea/cpu9260/cpu9260.c +2 -6
  int dram_init(void)
  {
-	gd->bd->bi_dram[0].start = PHYS_SDRAM;
-	if (get_ram_size((long *) PHYS_SDRAM, PHYS_SDRAM_SIZE) !=
-	    PHYS_SDRAM_SIZE)
-		return -1;
-
-	gd->bd->bi_dram[0].size = PHYS_SDRAM_SIZE;
+	gd->ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
+			CONFIG_SYS_SDRAM_SIZE);

Checkpatch warns about the volatile here.

I know the get_ram_size() prototype calls for the volatile attribute, but what is the rationale here for this? get_ram_size() just needs the RAM base address *value*; if it requires volatile accesses to it, it can arrange for these inside its definition. Besides, throughout the code base there are 19 instances of get_ram_size() callw where the argument is cast to volatile, against 130 where it is not.

Wolfgang et al.: how about removing the 'volatile' qualifier from the get_ram_size() prototype?

Eric: if your patch does not cause a warning without the volatile in the call, can you update and repost it as V2?

Quoted 8 lines
include/configs/cpu9260.h +1 -2
index d239423..a8ada2d 100644
 
-#define CONFIG_SYS_NAND_READY_PIN		AT91_PIN_PC13
-#define CONFIG_SYS_NAND_ENABLE_PIN		AT91_PIN_PC14
+#define CONFIG_SYS_NAND_READY_PIN		AT91_PIO_PORTC, 13

include/configs/cpu9260.h

Quoted 10 lines
include/configs/cpu9260.h +5 -4
+#define CONFIG_SYS_NAND_ENABLE_PIN		AT91_PIO_PORTC, 14
 
-#define CONFIG_RED_LED				AT91_PIN_PC11
-#define CONFIG_GREEN_LED			AT91_PIN_PC12
-#define CONFIG_YELLOW_LED			AT91_PIN_PC7
-#define CONFIG_BLUE_LED				AT91_PIN_PC9
+#define CONFIG_RED_LED				AT91_PIO_PORTC, 11
+#define CONFIG_GREEN_LED			AT91_PIO_PORTC, 12
+#define CONFIG_YELLOW_LED			AT91_PIO_PORTC, 7
+#define CONFIG_BLUE_LED				AT91_PIO_PORTC, 9

Checkpatch considers these errors. This is again a case where we'd want it to ignore it... or reconsider this type of macro, which intends to expand to several function arguments.

For now I'll ignore these 6 checkpatch errors.

Amicalement,

Signature · 1 line
Albert.
#4 lore raw

PATCH 2/3 cpu9260: update board support

Le 16/04/2011 09:26, Albert ARIBAUD a ?crit :

Quoted 58 lines

Le 03/04/2011 18:35, Eric B?nard a ?crit :

Quoted 7 lines
board/eukrea/cpu9260/cpu9260.c +0 -0
index 61b6c33..9ec48a0 100644
@@ -188,26 +175,16 @@ int board_init(void)

board/eukrea/cpu9260/cpu9260.c int board_init(void) · line 179

Quoted 10 lines
board/eukrea/cpu9260/cpu9260.c +2 -6
   int dram_init(void)
   {
-	gd->bd->bi_dram[0].start = PHYS_SDRAM;
-	if (get_ram_size((long *) PHYS_SDRAM, PHYS_SDRAM_SIZE) !=
-	    PHYS_SDRAM_SIZE)
-		return -1;
-
-	gd->bd->bi_dram[0].size = PHYS_SDRAM_SIZE;
+	gd->ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
+			CONFIG_SYS_SDRAM_SIZE);

Checkpatch warns about the volatile here.

I know the get_ram_size() prototype calls for the volatile attribute, but what is the rationale here for this? get_ram_size() just needs the RAM base address *value*; if it requires volatile accesses to it, it can arrange for these inside its definition. Besides, throughout the code base there are 19 instances of get_ram_size() callw where the argument is cast to volatile, against 130 where it is not.

Wolfgang et al.: how about removing the 'volatile' qualifier from the get_ram_size() prototype?

Eric: if your patch does not cause a warning without the volatile in the call, can you update and repost it as V2?

Quoted 8 lines
include/configs/cpu9260.h +1 -2
index d239423..a8ada2d 100644
 
-#define CONFIG_SYS_NAND_READY_PIN		AT91_PIN_PC13
-#define CONFIG_SYS_NAND_ENABLE_PIN		AT91_PIN_PC14
+#define CONFIG_SYS_NAND_READY_PIN		AT91_PIO_PORTC, 13

include/configs/cpu9260.h

Quoted 10 lines
include/configs/cpu9260.h +5 -4
+#define CONFIG_SYS_NAND_ENABLE_PIN		AT91_PIO_PORTC, 14
 
-#define CONFIG_RED_LED				AT91_PIN_PC11
-#define CONFIG_GREEN_LED			AT91_PIN_PC12
-#define CONFIG_YELLOW_LED			AT91_PIN_PC7
-#define CONFIG_BLUE_LED				AT91_PIN_PC9
+#define CONFIG_RED_LED				AT91_PIO_PORTC, 11
+#define CONFIG_GREEN_LED			AT91_PIO_PORTC, 12
+#define CONFIG_YELLOW_LED			AT91_PIO_PORTC, 7
+#define CONFIG_BLUE_LED				AT91_PIO_PORTC, 9

Checkpatch considers these errors. This is again a case where we'd want it to ignore it... or reconsider this type of macro, which intends to expand to several function arguments.

Quoted 3 lines

For now I'll ignore these 6 checkpatch errors.

Amicalement,

Applied to u-boot-arm/master, thanks.

Amicalement,

Signature · 1 line
Albert.
author
#5 lore raw

PATCH 3/3 cpuat91: fix board support

In reply to Eric Bénard

- fix board support following relocation changes
- switch to boards.cfg
- disable i2c to keep size under 128kiB (1 sector)

Signed-off-by Eric B?nard <[email protected]>
---
 Makefile                       |   10 ---
 board/eukrea/cpuat91/Makefile  |    4 +-
 board/eukrea/cpuat91/config.mk |    1 -
 board/eukrea/cpuat91/cpuat91.c |   11 ++--
 boards.cfg                     |    2 +
 include/configs/cpuat91.h      |  141 ++++++++++++++++++++++------------------
 6 files changed, 87 insertions(+), 82 deletions(-)
 delete mode 100644 board/eukrea/cpuat91/config.mk
Makefile +0 -10
index 10a856a..aeb6e7c 100644
@@ -749,16 +749,6 @@ M5485HFE_config :	unconfig
 #========================================================================
 
 #########################################################################
-## Atmel AT91RM9200 Systems
-#########################################################################
-
-CPUAT91_RAM_config \
-CPUAT91_config	:	unconfig
-	@mkdir -p $(obj)include
-	@echo "#define CONFIG_$(@:_config=) 1"	>$(obj)include/config.h
-	@$(MKCONFIG) -n $@ -a cpuat91 arm arm920t cpuat91 eukrea at91
-
-#########################################################################
 ## ARM926EJ-S Systems
 #########################################################################
board/eukrea/cpuat91/Makefile +2 -2
index 15da3d8..1d62b13 100644
@@ -25,7 +25,7 @@ include $(TOPDIR)/config.mk
 
 LIB	= $(obj)lib$(BOARD).o
 
-COBJS	:= cpuat91.o
+COBJS	:= $(BOARD).o
 
 SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
 OBJS	:= $(addprefix $(obj),$(COBJS))

@@ -38,7 +38,7 @@ clean:
 	rm -f $(SOBJS) $(OBJS)
 
 distclean:	clean
-	rm -f $(LIB) core *.bak .depend
+	rm -f $(LIB) core *.bak $(obj).depend
 
 #########################################################################
board/eukrea/cpuat91/config.mk deleted +0 -1
deleted file mode 100644
index 463f46b..0000000
@@ -1 +0,0 @@
-CONFIG_SYS_TEXT_BASE = 0x21F00000
board/eukrea/cpuat91/cpuat91.c +5 -6
index cd4d42c..4c4dad6 100644
@@ -47,24 +47,23 @@ int board_init(void)
 	/* arch number of CPUAT91-Board */
 	gd->bd->bi_arch_number = MACH_TYPE_CPUAT91;
 	/* adress of boot parameters */
-	gd->bd->bi_boot_params = PHYS_SDRAM + 0x100;
+	gd->bd->bi_boot_params = CONFIG_SYS_SDRAM_BASE + 0x100;
 
 	return 0;
 }
 
 int dram_init(void)
 {
-	gd->bd->bi_dram[0].start = PHYS_SDRAM;
-	gd->bd->bi_dram[0].size = PHYS_SDRAM_SIZE;
+	/* dram_init must store complete ramsize in gd->ram_size */
+	gd->ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
+			CONFIG_SYS_SDRAM_SIZE);
 	return 0;
 }
 
 #ifdef CONFIG_DRIVER_AT91EMAC
 int board_eth_init(bd_t *bis)
 {
-	int rc = 0;
-	rc = at91emac_register(bis, 0);
-	return rc;
+	return at91emac_register(bis, (u32) AT91_EMAC_BASE);
 }
 #endif
boards.cfg +2 -0
index 2f0d1df..64b5f95 100644
@@ -52,6 +52,8 @@ a320evb                      arm         arm920t     -                   faraday
 at91rm9200ek                 arm         arm920t     at91rm9200ek        atmel          at91        at91rm9200ek
 at91rm9200ek_ram             arm         arm920t     at91rm9200ek        atmel          at91        at91rm9200ek:RAMBOOT
 eb_cpux9k2                   arm         arm920t     -                   BuS            at91
+cpuat91                      arm         arm920t     cpuat91             eukrea         at91        cpuat91
+cpuat91_ram                  arm         arm920t     cpuat91             eukrea         at91        cpuat91:RAMBOOT
 cmc_pu2                      arm         arm920t     -                   -              at91rm9200
 csb637                       arm         arm920t     -                   -              at91rm9200
 kb9202                       arm         arm920t     -                   -              at91rm9200
include/configs/cpuat91.h +78 -63

224 lines not on this page · raw message

Signature · 1 line
1.7.4
#7 lore raw

PATCH 3/3 cpuat91: fix board support

Le 15/04/2011 15:49, Eric B?nard a ?crit :

Quoted 1 line

To: albert at aribaud.net

Please do not use this address of mine for U-Boot related stuff; use albert.u.boot at aribaud.net (Cc:ed).

Amicalement,

Signature · 1 line
Albert.
#8 lore raw

PATCH 3/3 cpuat91: fix board support

In reply to Eric Bénard

Le 03/04/2011 18:35, Eric B?nard a ?crit :

Quoted 6 lines

- fix board support following relocation changes
- switch to boards.cfg
- disable i2c to keep size under 128kiB (1 sector)

Signed-off-by Eric B?nard<[email protected]>

---

Reinhard: this was delegated to you in patchwork, but since this is only board support, not arch, and I have applied other at91-related patches in the series, I took the liberty of assigning it to myself.

Applied to u-boot-arm/master, thanks.

Amicalement,

Signature · 1 line
Albert.
#9 lore raw

PATCH 1/3 mp2usb: remove board support

In reply to Eric Bénard

Dear Eric,

Quoted 4 lines · In message <[email protected]> you wrote:

this board was cancelled long time ago so remove it as it won't be maintained anymore

Signed-off-by Eric B??nard <[email protected]>
Quoted 13 lines
---
 board/mp2usb/Makefile    |   50 -----
 board/mp2usb/config.mk   |    3 -
 board/mp2usb/flash.c     |  552 ----------------------------------------------
 board/mp2usb/mp2usb.c    |   98 --------
 boards.cfg               |    1 -
 include/configs/mp2usb.h |  242 --------------------
 6 files changed, 0 insertions(+), 946 deletions(-)
 delete mode 100644 board/mp2usb/Makefile
 delete mode 100644 board/mp2usb/config.mk
 delete mode 100644 board/mp2usb/flash.c
 delete mode 100644 board/mp2usb/mp2usb.c
 delete mode 100644 include/configs/mp2usb.h

This does not apply cleanly. Can you please rebase and resubmit?

Please also make an entry about the removal in doc/README.scrapyard - thanks!

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What about WRITING it first and rationalizing it afterwords?  :-)
                       - Larry Wall in <[email protected]>
author
#10 lore raw

PATCH 1/3 mp2usb: remove board support

Hi Wolfgang,

Quoted 19 lines · Wolfgang Denk
Quoted 12 lines · In message<[email protected]> you wrote:

this board was cancelled long time ago so remove it as it won't be maintained anymore

Signed-off-by Eric B??nard<[email protected]>
---
  board/mp2usb/Makefile    |   50 -----
  board/mp2usb/config.mk   |    3 -
  board/mp2usb/flash.c     |  552 ----------------------------------------------
  board/mp2usb/mp2usb.c    |   98 --------
  boards.cfg               |    1 -
  include/configs/mp2usb.h |  242 --------------------
  6 files changed, 0 insertions(+), 946 deletions(-)
Quoted 5 lines

delete mode 100644 board/mp2usb/Makefile
delete mode 100644 board/mp2usb/config.mk
delete mode 100644 board/mp2usb/flash.c
delete mode 100644 board/mp2usb/mp2usb.c
delete mode 100644 include/configs/mp2usb.h

Quoted 2 lines

This does not apply cleanly. Can you please rebase and resubmit?

in fact you already applied it ee986e2a7d1fd38568e2e5f83563b7bc4f607963 but took the 1st version which didn't remove boards.cfg (I forget to add v2 btw).

Quoted 2 lines

Please also make an entry about the removal in doc/README.scrapyard - thanks!

a patch finishing to work follows.

Thanks,
Eric

author
#11 lore raw

PATCH 1/1 mp2usb: finish the removal

In reply to Wolfgang Denk

- remove from boards.cfg
- add to doc/README.scrapyard

Signed-off-by Eric B?nard <[email protected]>
---
 boards.cfg           |    1 -
 doc/README.scrapyard |    1 +
 2 files changed, 1 insertions(+), 1 deletions(-)
boards.cfg +0 -1
index d4cbb06..916414a 100644
@@ -56,7 +56,6 @@ cmc_pu2                      arm         arm920t     -                   -
 csb637                       arm         arm920t     -                   -              at91rm9200
 kb9202                       arm         arm920t     -                   -              at91rm9200
 m501sk                       arm         arm920t     -                   -              at91rm9200
-mp2usb                       arm         arm920t     -                   -              at91rm9200
 at91rm9200dk                 arm         arm920t     -                   atmel          at91rm9200
 mx1ads                       arm         arm920t     -                   -              imx
 mx1fs2                       arm         arm920t     -                   -              imx
doc/README.scrapyard +1 -0
index 8f98b60..5cdf151 100644
@@ -11,6 +11,7 @@ easily if here is something they might want to dig for...
 
 Board	Arch	CPU	removed	    Commit	last known maintainer/contact
 =============================================================================
+mp2usb	ARM	AT91RM2900 	ee986e2	2011-01-25	Eric B?nard <[email protected]>
 barco	powerpc	MPC8245	-	  2010-11-23	Marc Leeman <[email protected]>
 ERIC	powerpc	405GP	d9ba451	  2010-11-21	Swen Anderson <[email protected]>
 VoVPN-GW_100MHz	powerpc	MPC8260 26fe3d2 2010-10-24	Juergen Selent <[email protected]>
Signature · 1 line
1.7.4.4
Applied
#12 lore raw

PATCH 1/1 mp2usb: finish the removal

Dear =?UTF-8?q?Eric=20B=C3=A9nard?=,

Quoted 8 lines · In message <[email protected]> you wrote:

- remove from boards.cfg
- add to doc/README.scrapyard

Signed-off-by Eric B??nard <[email protected]>
---
 boards.cfg           |    1 -
 doc/README.scrapyard |    1 +
 2 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Any excuse will serve a tyrant."                             - Aesop