Skip to contentSkip to conversation

efifb: fix int to pointer cast warning

PATCH Applied Konstantin Khlebnikov 3 participants 3 messages Apr 19, 2011 – Apr 20, 2011 Framebuffer layer

lore
Share & tools
lore

Konstantin Khlebnikov

author
#0 lore raw

PATCH 1/1 efifb: fix int to pointer cast warning

drivers/video/efifb.c:247: warning: cast to pointer from integer of different size

Signed-off-by Konstantin Khlebnikov <[email protected]>
---
 drivers/video/efifb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/video/efifb.c +2 -2
index 4eb38db..fb20584 100644
@@ -242,9 +242,9 @@ static int set_system(const struct dmi_system_id *id)
 		return 0;
 	}
 
-	printk(KERN_INFO "efifb: dmi detected %s - framebuffer at %p "
+	printk(KERN_INFO "efifb: dmi detected %s - framebuffer at 0x%08x "
 			 "(%dx%d, stride %d)\n", id->ident,
-			 (void *)screen_info.lfb_base, screen_info.lfb_width,
+			 screen_info.lfb_base, screen_info.lfb_width,
 			 screen_info.lfb_height, screen_info.lfb_linelength);
#1 lore raw
Quoted 3 lines · Konstantin Khlebnikov

drivers/video/efifb.c:247: warning: cast to pointer from integer of different size

Signed-off-by Konstantin Khlebnikov <[email protected]>

Looks fine to me:

Signed-off-by Peter Jones <[email protected]>
Quoted 25 lines
---
 drivers/video/efifb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/video/efifb.c +2 -3
index 4eb38db..fb20584 100644
@@ -242,9 +242,9 @@ static int set_system(const struct dmi_system_id *id)
 		return 0;
 	}
 
-	printk(KERN_INFO "efifb: dmi detected %s - framebuffer at %p "
+	printk(KERN_INFO "efifb: dmi detected %s - framebuffer at 0x%08x "
 			 "(%dx%d, stride %d)\n", id->ident,
-			 (void *)screen_info.lfb_base, screen_info.lfb_width,
+			 screen_info.lfb_base, screen_info.lfb_width,
 			 screen_info.lfb_height, screen_info.lfb_linelength);
 
 
 
--

To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 7 lines
        Peter

Hardware simply does not work like the manual says and no amount
of Zen contemplation will ever make you at one with a 3c905B ethernet card.
		-- Alan

01234567890123456789012345678901234567890123456789012345678901234567890123456789