Skip to contentSkip to conversation

net: forcedeth: fix compile warning of not used nv_set_tso function

PATCH Applied Shan Wei 2 participants 3 messages Apr 20, 2011

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Shan Wei

author
#0 lore raw

PATCH 1/1 net: forcedeth: fix compile warning of not used nv_set_tso function

Fix the below compile warning:
drivers/net/forcedeth.c:4266: warning: ‘nv_set_tso’ defined but not used

commit 569e146 converts forcedeth driver to use hw_features. So, implement function of .set_tso is abandoned.

Signed-off-by Shan Wei <[email protected]>
---
 drivers/net/forcedeth.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)
drivers/net/forcedeth.c +0 -10
index ec9a32d..0e1c76a 100644
@@ -4263,16 +4263,6 @@ static int nv_nway_reset(struct net_device *dev)
 	return ret;
 }
 
-static int nv_set_tso(struct net_device *dev, u32 value)
-{
-	struct fe_priv *np = netdev_priv(dev);
-
-	if ((np->driver_data & DEV_HAS_CHECKSUM))
-		return ethtool_op_set_tso(dev, value);
-	else
-		return -EOPNOTSUPP;
-}
-
 static void nv_get_ringparam(struct net_device *dev, struct ethtool_ringparam* ring)
 {
 	struct fe_priv *np = netdev_priv(dev);
Signature · 1 line
1.6.3.3
author
#1 lore raw

This patch is against net-next.

Shan Wei wrote, at 04/20/2011 09:31 AM:

Quoted 32 lines

Fix the below compile warning:
drivers/net/forcedeth.c:4266: warning: ‘nv_set_tso’ defined but not used

commit 569e146 converts forcedeth driver to use hw_features. So, implement function of .set_tso is abandoned.

Signed-off-by Shan Wei <[email protected]>
---
 drivers/net/forcedeth.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)
drivers/net/forcedeth.c +0 -10
index ec9a32d..0e1c76a 100644
@@ -4263,16 +4263,6 @@ static int nv_nway_reset(struct net_device *dev)
 	return ret;
 }
 
-static int nv_set_tso(struct net_device *dev, u32 value)
-{
-	struct fe_priv *np = netdev_priv(dev);
-
-	if ((np->driver_data & DEV_HAS_CHECKSUM))
-		return ethtool_op_set_tso(dev, value);
-	else
-		return -EOPNOTSUPP;
-}
-
 static void nv_get_ringparam(struct net_device *dev, struct ethtool_ringparam* ring)
 {
 	struct fe_priv *np = netdev_priv(dev);
Signature · 3 lines
Best Regards
-----
Shan Wei
maintainer Applied
#2 lore raw
In reply to Shan Wei

From: Shan Wei <[email protected]>
Date: Wed, 20 Apr 2011 09:31:20 +0800

Quoted 7 lines

Fix the below compile warning:
drivers/net/forcedeth.c:4266: warning: ‘nv_set_tso’ defined but not used

commit 569e146 converts forcedeth driver to use hw_features. So, implement function of .set_tso is abandoned.

Signed-off-by Shan Wei <[email protected]>

Applied.