Skip to contentSkip to conversation

ARM: fix stack pointer adjustment in board_init_f()

PATCH New Eric Cooper 3 participants 3 messages Apr 14, 2011 – Apr 20, 2011 Arm (32-bit)

lore
Share & tools
lore

Eric Cooper

author
#0 lore raw

PATCH 1/1 ARM: fix stack pointer adjustment in board_init_f()

Since addr_sp is a byte address, it should be adjusted by 12 here.

Signed-off-by Eric Cooper <[email protected]>
Cc Albert ARIBAUD <[email protected]>
---
 arch/arm/lib/board.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/lib/board.c +1 -1
index dc46e21..d5b34ad 100644
@@ -399,7 +399,7 @@ void board_init_f (ulong bootflag)
 		CONFIG_STACKSIZE_IRQ+CONFIG_STACKSIZE_FIQ, addr_sp);
 #endif
 	/* leave 3 words for abort-stack    */
-	addr_sp -= 3;
+	addr_sp -= 12;
 
 	/* 8-byte alignment for ABI compliance */
 	addr_sp &= ~0x07;
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 ARM: fix stack pointer adjustment in board_init_f()

Dear Eric Cooper,

Quoted 7 lines · In message <[email protected]> you wrote:

Since addr_sp is a byte address, it should be adjusted by 12 here.

Signed-off-by Eric Cooper <[email protected]>
Cc Albert ARIBAUD <[email protected]>
---
 arch/arm/lib/board.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Acked-by Wolfgang Denk <[email protected]>

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You've no idea of what a poor opinion  I  have  of  myself,  and  how
little I deserve it.                                  - W. S. Gilbert
#2 lore raw

PATCH 1/1 ARM: fix stack pointer adjustment in board_init_f()

Hi Eric,

Le 15/04/2011 10:42, Wolfgang Denk a ?crit :

Quoted 11 lines

Dear Eric Cooper,

Quoted 7 lines · In message<[email protected]> you wrote:

Since addr_sp is a byte address, it should be adjusted by 12 here.

Signed-off-by Eric Cooper<[email protected]>
Cc Albert ARIBAUD<[email protected]>
---
  arch/arm/lib/board.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 5 lines
Acked-by Wolfgang Denk<[email protected]>

Best regards,

Wolfgang Denk

Applied to u-boot-arm, thanks.

Amicalement,

Signature · 1 line
Albert.