Skip to contentSkip to conversation

package: Adding Next Generation IRC deamon ngircd

PATCH New fabien.marteau at armadeus.com 2 participants 4 messages Apr 20, 2011

lore
Share & tools
lore

fabien.marteau at armadeus.com

author
#0 lore raw

PATCH 1/1 package: Adding Next Generation IRC deamon ngircd

From: Fabien Marteau <[email protected]>

Signed-off-by Fabien Marteau <[email protected]>
---
 package/Config.in        |    1 +
 package/ngircd/Config.in |    6 ++++++
 package/ngircd/ngircd.mk |   11 +++++++++++
 3 files changed, 18 insertions(+), 0 deletions(-)
 create mode 100644 package/ngircd/Config.in
 create mode 100644 package/ngircd/ngircd.mk
package/Config.in +1 -0
index 014c2c0..cd49bc9 100644
@@ -409,6 +409,7 @@ source "package/netplug/Config.in"
 source "package/netsnmp/Config.in"
 source "package/netstat-nat/Config.in"
 source "package/nfs-utils/Config.in"
+source "package/ngircd/Config.in"
 source "package/ntp/Config.in"
 source "package/nuttcp/Config.in"
 source "package/olsr/Config.in"
package/ngircd/Config.in new file +6 -0
new file mode 100644
index 0000000..db13c41
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_NGIRCD
+	bool "ngircd"
+	help
+		Next Generation IRC server deamon.
+		http://ngircd.barton.de
+
package/ngircd/ngircd.mk new file +11 -0
new file mode 100644
index 0000000..0b70455
@@ -0,0 +1,11 @@
+#############################################################
+#
+# ngIRCd: Next Generation IRC Daemon
+#
+#############################################################
+NGIRCD_VERSION = 17.1
+NGIRCD_SOURCE = ngircd-17.1.tar.gz
+NGIRCD_SITE = ftp://ftp.berlios.de/pub/ngircd/
+NGIRCD_CONF_OPT =
+
+$(eval $(call AUTOTARGETS,package,ngircd))
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 package: Adding Next Generation IRC deamon ngircd

Hi Fabien!

Thanks for contributing. Just a few comments below:

2011/4/20 <[email protected]>:

Review line 6

Quoted 8 lines

From: Fabien Marteau <[email protected]>

(quoted diff) +6 -0
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_NGIRCD
+ ? ? ? bool "ngircd"
+ ? ? ? help
+ ? ? ? ? ? ? ? Next Generation IRC server deamon.
+ ? ? ? ? ? ? ? http://ngircd.barton.de
+

The current format uses 1 tab for identation (as you've done) but 1 tab + 2 spaces for help text. And please put the blank line between the description and the URL instead. :)
An ideal example: http://git.buildroot.net/buildroot/tree/package/file/Config.in

package/ngircd/ngircd.mk line 1

Quoted 3 lines

+++ b/package/ngircd/ngircd.mk

package/ngircd/ngircd.mk new file +1 -0
@@ -0,0 +1,11 @@
+NGIRCD_CONF_OPT =

Since you do not specify any CONF_OPT you could just remove the line completely.

#2 lore raw

PATCH 1/1 package: Adding Next Generation IRC deamon ngircd

In reply to fabien.marteau at armadeus.com

Oops, one last thing:

package/ngircd/ngircd.mk line 7

Quoted 2 lines
package/ngircd/ngircd.mk new file +2 -0
+NGIRCD_VERSION = 17.1
+NGIRCD_SOURCE = ngircd-17.1.tar.gz

This should be:

+NGIRCD_VERSION = 17.1
+NGIRCD_SOURCE = ngircd-$(NGIRCD_VERSION).tar.gz

Or, as the tarball follows standard naming convention, you could just strip the _SOURCE line as seen here:
http://git.buildroot.net/buildroot/tree/package/file/file.mk

author
#3 lore raw

PATCH 1/1 package: Adding Next Generation IRC deamon ngircd

Quoted 10 lines · Daniel Nystr?m

Oops, one last thing:

package/ngircd/ngircd.mk line 7

Quoted 2 lines
package/ngircd/ngircd.mk new file +2 -0
+NGIRCD_VERSION = 17.1
+NGIRCD_SOURCE = ngircd-17.1.tar.gz

This should be:

(quoted diff) +2 -0
+NGIRCD_VERSION = 17.1
+NGIRCD_SOURCE = ngircd-$(NGIRCD_VERSION).tar.gz
Quoted 4 lines

Or, as the tarball follows standard naming convention, you could just strip the _SOURCE line as seen here:
http://git.buildroot.net/buildroot/tree/package/file/file.mk

Thanks for your remarks, i will commit a new version of the patch

Fabien