Skip to contentSkip to conversation

powerpc/eeh: Handle functional reset on non-PCIe device

PATCH In review Richard A Lary 1 participant 1 message Apr 22, 2011

Subsystems (2)
PowerPC PCI enhanced error handling (eeh) for PowerPC
lore
Share & tools
lore

Richard A Lary

author
#0 lore raw

PATCH 3/3 powerpc/eeh: Handle functional reset on non-PCIe device

From: Richard A Lary <[email protected]>

For adapters which have devices under a PCIe switch/bridge it is informative to display information for both the PCIe switch/bridge and the device on which the bus error was detected.

Signed-off-by Richard A Lary <[email protected]>

---
arch/powerpc/platforms/pseries/eeh_driver.c | 24 14 + 10 - 0 !

 1 file changed, 14 insertions(+), 10 deletions(-)
arch/powerpc/platforms/pseries/eeh_driver.c +14 -10
Index: b/arch/powerpc/platforms/pseries/eeh_driver.c
===================================================================
@@ -328,7 +328,7 @@ struct pci_dn * handle_eeh_events (struc
 	struct pci_bus *frozen_bus;
 	int rc = 0;
 	enum pci_ers_result result = PCI_ERS_RESULT_NONE;
-	const char *location, *pci_str, *drv_str;
+	const char *location, *pci_str, *drv_str, *bus_pci_str, *bus_drv_str;
 
 	frozen_dn = find_device_pe(event->dn);
 	if (!frozen_dn) {

@@ -364,22 +364,26 @@ struct pci_dn * handle_eeh_events (struc
 	frozen_pdn = PCI_DN(frozen_dn);
 	frozen_pdn->eeh_freeze_count++;
 
-	if (frozen_pdn->pcidev) {
-		pci_str = pci_name (frozen_pdn->pcidev);
-		drv_str = pcid_name (frozen_pdn->pcidev);
-	} else {
-		pci_str = eeh_pci_name(event->dev);
-		drv_str = pcid_name (event->dev);
-	}
-	
+	pci_str = eeh_pci_name(event->dev);
+	drv_str = pcid_name(event->dev);
+
 	if (frozen_pdn->eeh_freeze_count > EEH_MAX_ALLOWED_FREEZES)
 		goto excess_failures;
 
 	printk(KERN_WARNING
 	   "EEH: This PCI device has failed %d times in the last hour:\n",
 		frozen_pdn->eeh_freeze_count);
+
+	if (frozen_pdn->pcidev) {
+		bus_pci_str = pci_name(frozen_pdn->pcidev);
+		bus_drv_str = pcid_name(frozen_pdn->pcidev);
+		printk(KERN_WARNING
+			"EEH: Bus location=%s driver=%s pci addr=%s\n",
+			location, bus_drv_str, bus_pci_str);
+	}
+
 	printk(KERN_WARNING
-		"EEH: location=%s driver=%s pci addr=%s\n",
+		"EEH: Device location=%s driver=%s pci addr=%s\n",
 		location, drv_str, pci_str);
 
 	/* Walk the various device drivers attached to this slot through