Skip to contentSkip to conversation

kbuild: fix sed error in export_report.pl

PATCH In review Peter Foley 4 participants 6 messages Apr 25, 2011 – Apr 26, 2011 Kbuild

lore
Share & tools
lore

Peter Foley

author
#0 lore raw

PATCH 1/1 kbuild: fix sed error in export_report.pl

This patch fixes a sed error in export_report.pl by escaping a $.

Signed-off-by Peter Foley <[email protected]>
---
 scripts/export_report.pl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
scripts/export_report.pl +1 -1
index 04dce7c..91fa5a2 100644
@@ -50,7 +50,7 @@ sub usage {
  sub collectcfiles {
     my @file
-	= `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
+	= `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko\$/.mod.c/`;
     chomp @file;
     return @file;
 }
Signature · 1 line
1.7.5.rc1
#1 lore raw

Hi,

Quoted 2 lines · Peter Foley

This patch fixes a sed error in export_report.pl by escaping a $.

Which error ?

Thanks,
- Arnaud

Quoted 25 lines
Signed-off-by Peter Foley <[email protected]>

---
 scripts/export_report.pl |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
scripts/export_report.pl +0 -0
index 04dce7c..91fa5a2 100644
@@ -50,7 +50,7 @@ sub usage {
  sub collectcfiles {

    my @file

-       = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
+       = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko\$/.mod.c/`;

    chomp @file;
    return @file;
 }
--
1.7.5.rc1

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

author
#2 lore raw
Quoted 10 lines · Arnaud Lacombe

Hi,

Quoted 2 lines · Peter Foley

This patch fixes a sed error in export_report.pl by escaping a $.

Which error ?

Thanks,
- Arnaud

This is the error I get:

make -C /usr/src/git O=/root/linux/t/. export_report perl /usr/src/git/scripts/export_report.pl
sed: -e expression #1, char 5: unterminated `s' command
sh: line 1: .mod.c/: No such file or directory

Acked-by
#3 lore raw
Quoted 12 lines · Peter Foley
Quoted 10 lines · Arnaud Lacombe

Hi,

Quoted 2 lines · Peter Foley

This patch fixes a sed error in export_report.pl by escaping a $.

Which error ?

Thanks,
 - Arnaud

Quoted 6 lines

This is the error I get:

make -C /usr/src/git O=/root/linux/t/. export_report perl /usr/src/git/scripts/export_report.pl
sed: -e expression #1, char 5: unterminated `s' command
sh: line 1: .mod.c/: No such file or directory

Please include this in your changelog.

But anyway,

Acked-by WANG Cong <[email protected]>

Thanks!

#4 lore raw
In reply to Peter Foley
Quoted 12 lines · Peter Foley

This patch fixes a sed error in export_report.pl by escaping a $.

Signed-off-by Peter Foley<[email protected]>
---
  scripts/export_report.pl |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
scripts/export_report.pl +0 -0
index 04dce7c..91fa5a2 100644

scripts/export_report.pl sub usage { · line 52

Quoted 4 lines
scripts/export_report.pl +1 -1
@@ -50,7 +50,7 @@ sub usage {
   sub collectcfiles {
      my @file
-	= `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
+	= `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko\$/.mod.c/`;

Please enclose the argument in single quotes instead.

Michal

author
#5 lore raw
Quoted 21 lines · Michal Marek
Quoted 12 lines · Peter Foley

This patch fixes a sed error in export_report.pl by escaping a $.

Signed-off-by Peter Foley<[email protected]>
---
  scripts/export_report.pl |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
scripts/export_report.pl +0 -0
index 04dce7c..91fa5a2 100644

scripts/export_report.pl sub usage { · line 53

Quoted 5 lines
scripts/export_report.pl +1 -1
@@ -50,7 +50,7 @@ sub usage {
   sub collectcfiles {
      my @file
-    = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
+    = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed
 s/\.ko\$/.mod.c/`;

Please enclose the argument in single quotes instead.

Quoted 1 line

Michal

I tried doing that and still got:
perl /usr/src/git/scripts/export_report.pl
sed: -e expression #1, char 5: unterminated `s' command

Peter