kbuild: allow headerdep to work in KBUILD_OUTPUT and add targets to PHONY
PATCH 1/1 kbuild: allow headerdep to work in KBUILD_OUTPUT and add targets to PHONY
This patch fixes the headerdep target so it will work when make is executed from KBUILD_OUTPUT. It also adds a few targets to PHONY so they are always executed.
--- Makefile | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
Makefile +4 -1
@@ -991,7 +991,8 @@ include/generated/utsrelease.h: include/config/kernel.release FORCE PHONY += headerdep headerdep: - $(Q)find include/ -name '*.h' | xargs --max-args 1 scripts/headerdep.pl + $(Q)find $(srctree)/include/ -name '*.h' | xargs --max-args 1 \ + $(srctree)/scripts/headerdep.pl -I$(srctree)/include # ---------------------------------------------------------------------------
@@ -1392,6 +1393,8 @@ tags TAGS cscope gtags: FORCE # Scripts to check various things for consistency # --------------------------------------------------------------------------- +PHONY += includecheck versioncheck coccicheck namespacecheck export_report + includecheck: find * $(RCS_FIND_IGNORE) \ -name '*.[hcS]' -type f -print | sort \
Signature · 1 line
1.7.5.rc1
Hi,
Quoted 3 lines · Peter Foley
This patch fixes the headerdep target so it will work when make is executed from
KBUILD_OUTPUT. It also adds a few targets to PHONY so they are always executed.
one change, one patch, please.
Why do you want that much consistency check to be always ran ? Especially `coccicheck', which rely on a non-common program being available.
Thanks,
- Arnaud
Quoted 36 lines
Signed-off-by Peter Foley <[email protected]>---
Makefile | 5 ++++-1 files changed, 4 insertions(+), 1 deletions(-)Makefile +0
-0@@ -991,7 +991,8 @@ include/generated/utsrelease.h: include/config/kernel.release FORCEPHONY += headerdep
headerdep:
- $(Q)findinclude/-name '*.h' | xargs --max-args 1scripts/headerdep.pl
+ $(Q)find $(srctree)/include/ -name '*.h' | xargs --max-args 1 \
+ $(srctree)/scripts/headerdep.pl -I$(srctree)/include# ---------------------------------------------------------------------------
Makefile +2
-0@@ -1392,6 +1393,8 @@ tags TAGS cscope gtags: FORCE # Scripts to check various things for consistency # --------------------------------------------------------------------------- +PHONY += includecheck versioncheck coccicheck namespacecheck export_report +includecheck:
find * $(RCS_FIND_IGNORE) \
-name '*.[hcS]' -type f -print | sort \
--
1.7.5.rc1--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 11 lines · Arnaud Lacombe
Hi,
Quoted 3 lines · Peter Foley
This patch fixes the headerdep target so it will work when make is executed from
KBUILD_OUTPUT. It also adds a few targets to PHONY so they are always executed.one change, one patch, please.
Why do you want that much consistency check to be always ran ? Especially `coccicheck', which rely on a non-common program being available.
The change is valid, but the changelog text is misleading. 'PHONY += foo' means that 'make foo' will always execute the commands for foo, even if there is a file of the same name.
Michal
Hi,
Quoted 9 lines · Michal Marek
Quoted 8 lines · Arnaud Lacombe
Hi,
Quoted 3 lines · Peter Foley
This patch fixes the headerdep target so it will work when make is executed from
KBUILD_OUTPUT. It also adds a few targets to PHONY so they are always executed.one change, one patch, please.
Quoted 8 lines
Quoted 3 lines
Why do you want that much consistency check to be always ran ? Especially `coccicheck', which rely on a non-common program being available.
The change is valid, but the changelog text is misleading. 'PHONY += foo' means that 'make foo' will always execute the commands for foo, even if there is a file of the same name.
my bad, I just confirmed that purpose by checking make doc :)
- Arnaud
Quoted 2 lines
Michal