Skip to contentSkip to conversation

kbuild: only build kxgettext when needed

PATCH Superseded Peter Foley 2 participants 4 messages Apr 26, 2011 – Apr 27, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/7 kbuild: only build kxgettext when needed

This patch only builds kxgettext when running update-po-config which is the only target that uses it.

---
 scripts/kconfig/Makefile |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
scripts/kconfig/Makefile +5 -1
index 368ae30..fec830f 100644
@@ -169,7 +169,7 @@ mconf-objs     := mconf.o zconf.tab.o $(lxdialog)
 nconf-objs     := nconf.o zconf.tab.o nconf.gui.o
 kxgettext-objs	:= kxgettext.o zconf.tab.o
 
-hostprogs-y := conf qconf gconf kxgettext
+hostprogs-y := conf qconf gconf
 
 ifeq ($(MAKECMDGOALS),nconfig)
 	hostprogs-y += nconf
@@ -179,6 +179,10 @@ ifeq ($(MAKECMDGOALS),menuconfig)
 	hostprogs-y += mconf
 endif
 
+ifeq($(MAKECMDGOALS),update-po-config)
+	hostprogs-y += kxgettext
+endif
+
 ifeq ($(MAKECMDGOALS),xconfig)
 	qconf-target := 1
 endif
Signature · 1 line
1.7.5.rc1
#1 lore raw

Sorry, I forgot a space in this patch. A corrected version is below.

This patch only builds kxgettext when running update-po-config which is the only target that uses it.

---
 scripts/kconfig/Makefile |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
scripts/kconfig/Makefile +5 -1
index 368ae30..fec830f 100644
@@ -169,7 +169,7 @@ mconf-objs     := mconf.o zconf.tab.o $(lxdialog)
 nconf-objs     := nconf.o zconf.tab.o nconf.gui.o
 kxgettext-objs	:= kxgettext.o zconf.tab.o
 
-hostprogs-y := conf qconf gconf kxgettext
+hostprogs-y := conf qconf gconf
 
 ifeq ($(MAKECMDGOALS),nconfig)
 	hostprogs-y += nconf
@@ -179,6 +179,10 @@ ifeq ($(MAKECMDGOALS),menuconfig)
 	hostprogs-y += mconf
 endif
 
+ifeq ($(MAKECMDGOALS),update-po-config)
+	hostprogs-y += kxgettext
+endif
+
 ifeq ($(MAKECMDGOALS),xconfig)
 	qconf-target := 1
 endif
Signature · 1 line
1.7.5.rc1
#2 lore raw
Quoted 1 line · Peter Foley

Sorry, I forgot a space in this patch. A corrected version is below.

The first patch actually applied OK, but patch 2/7 and 4/7 and maybe other were malformed. Could you please resend the patches as MIME attachments so that they are not modified by your mailer?

Thanks,
Michal

#3 lore raw
Quoted 9 lines · Michal Marek
Quoted 1 line · Peter Foley

Sorry, I forgot a space in this patch. A corrected version is below.

The first patch actually applied OK, but patch 2/7 and 4/7 and maybe other were malformed. Could you please resend the patches as MIME attachments so that they are not modified by your mailer?

Thanks,
Michal

Ok, I'll resend them.
Sorry for any trouble.

Thanks,

Peter