Skip to contentSkip to conversation

kbuild: don't warn about include/linux/version.h not including itself

PATCH In review Peter Foley 2 participants 2 messages Apr 26, 2011 – Apr 29, 2011 Kbuild

lore
Share & tools
lore

Peter Foley

author
#0 lore raw

PATCH v2 1/1 kbuild: don't warn about include/linux/version.h not including itself

This patch makes checkversion.pl not warn that include/linux/version.h dosen't include itself.

Signed-off-by Peter Foley <[email protected]>
---
 scripts/checkversion.pl |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
scripts/checkversion.pl +3 -0
index b444e89..cf4b1dc 100755
@@ -12,6 +12,8 @@ $| = 1;
 my $debugging;
 
 foreach my $file (@ARGV) {
+    if($file !~ "include/linux/version\.h")
+    {
     # Open this file.
     open( my $f, '<', $file )
       or die "Can't open $file: $!\n";

@@ -67,4 +69,5 @@ foreach my $file (@ARGV) {
     }
 
     close($f);
+    }
 }
Signature · 1 line
1.7.5.rc1
#1 lore raw
Quoted 13 lines · Peter Foley

This patch makes checkversion.pl not warn that include/linux/version.h dosen't include itself.

Signed-off-by Peter Foley <[email protected]>
---
 scripts/checkversion.pl |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
scripts/checkversion.pl +0 -0
index b444e89..cf4b1dc 100755

scripts/checkversion.pl $| = 1; · line 17

Quoted 6 lines
scripts/checkversion.pl +2 -0
@@ -12,6 +12,8 @@ $| = 1;
 my $debugging;
 
 foreach my $file (@ARGV) {
+    if($file !~ "include/linux/version\.h")
+    {
     # Open this file.

Enclosing the block in another pair of {...} is ugly, I changed it to

scripts/checkversion.pl +1 -0
index b444e89..5e490a8 100755
@@ -12,6 +12,7 @@ $| = 1;
 my $debugging;
 
 foreach my $file (@ARGV) {
+    next if $file =~ "include/linux/version\.h";
     # Open this file.
     open( my $f, '<', $file )
       or die "Can't open $file: $!\n";

and pushed to kbuild-2.6.git#misc.

Michal