Skip to contentSkip to conversation

Trivial: ARM: pxa168: Bug fix - correct UART DMA channels

PATCH New Tanmay Upadhyay 2 participants 3 messages Jan 4, 2011 – Apr 27, 2011

Subsystems (3)
Arm (32-bit) Arm sub-architectures Mmp support
lore
Share & tools
lore

Tanmay Upadhyay

author
#0 lore raw

PATCH 1/1 Trivial: ARM: pxa168: Bug fix - correct UART DMA channels

According to ARMADA_16x_Software_Manual.pdf, DMA channels for UART1 are 19, 20 and DMA channels for UART2 are 21, 22.

It's of little significance for now as the PXA UART driver doesn't use DMA as of now.

Signed-off-by Tanmay Upadhyay <[email protected]>
---
 arch/arm/mach-mmp/pxa168.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-mmp/pxa168.c +2 -2
index 72b4e76..7564739 100644
@@ -147,8 +147,8 @@ void pxa168_clear_keypad_wakeup(void)
 }
 
 /* on-chip devices */
-PXA168_DEVICE(uart1, "pxa2xx-uart", 0, UART1, 0xd4017000, 0x30, 21, 22);
-PXA168_DEVICE(uart2, "pxa2xx-uart", 1, UART2, 0xd4018000, 0x30, 23, 24);
+PXA168_DEVICE(uart1, "pxa2xx-uart", 0, UART1, 0xd4017000, 0x30, 19, 20);
+PXA168_DEVICE(uart2, "pxa2xx-uart", 1, UART2, 0xd4018000, 0x30, 21, 22);
 PXA168_DEVICE(twsi0, "pxa2xx-i2c", 0, TWSI0, 0xd4011000, 0x28);
 PXA168_DEVICE(twsi1, "pxa2xx-i2c", 1, TWSI1, 0xd4025000, 0x28);
 PXA168_DEVICE(pwm1, "pxa168-pwm", 0, NONE, 0xd401a000, 0x10);
Signature · 1 line
1.7.0.4
author
#1 lore raw

PATCH 1/1 Trivial: ARM: pxa168: Bug fix - correct UART DMA channels

Quoted 16 lines · Tanmay Upadhyay

According to ARMADA_16x_Software_Manual.pdf, DMA channels for UART1 are 19, 20 and DMA channels for UART2 are 21, 22.

It's of little significance for now as the PXA UART driver doesn't use DMA as of now.

Signed-off-by Tanmay Upadhyay<[email protected]>
---
  arch/arm/mach-mmp/pxa168.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-mmp/pxa168.c +0 -0
index 72b4e76..7564739 100644

arch/arm/mach-mmp/pxa168.c void pxa168_clear_keypad_wakeup(void) · line 154

Quoted 10 lines
arch/arm/mach-mmp/pxa168.c +2 -2
@@ -147,8 +147,8 @@ void pxa168_clear_keypad_wakeup(void)
  }
 
  /* on-chip devices */
-PXA168_DEVICE(uart1, "pxa2xx-uart", 0, UART1, 0xd4017000, 0x30, 21, 22);
-PXA168_DEVICE(uart2, "pxa2xx-uart", 1, UART2, 0xd4018000, 0x30, 23, 24);
+PXA168_DEVICE(uart1, "pxa2xx-uart", 0, UART1, 0xd4017000, 0x30, 19, 20);
+PXA168_DEVICE(uart2, "pxa2xx-uart", 1, UART2, 0xd4018000, 0x30, 21, 22);
  PXA168_DEVICE(twsi0, "pxa2xx-i2c", 0, TWSI0, 0xd4011000, 0x28);
  PXA168_DEVICE(twsi1, "pxa2xx-i2c", 1, TWSI1, 0xd4025000, 0x28);
  PXA168_DEVICE(pwm1, "pxa168-pwm", 0, NONE, 0xd401a000, 0x10);

Is there anything wrong with the patch? Any suggestions please?

Thanks,

Tanmay
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110427/93e8c570/attachment-0001.html>

#2 lore raw

PATCH 1/1 Trivial: ARM: pxa168: Bug fix - correct UART DMA channels

Quoted 29 lines · Tanmay Upadhyay

On Tuesday 04 January 2011 11:37 AM, Tanmay Upadhyay wrote:

According to ARMADA_16x_Software_Manual.pdf, DMA channels for UART1 are 19, 20 and DMA channels for UART2 are 21, 22.

It's of little significance for now as the PXA UART driver doesn't use DMA as of now.

Signed-off-by Tanmay Upadhyay <[email protected]>
---
 arch/arm/mach-mmp/pxa168.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-mmp/pxa168.c +2 -2
index 72b4e76..7564739 100644
@@ -147,8 +147,8 @@ void pxa168_clear_keypad_wakeup(void)
 }
 
 /* on-chip devices */
-PXA168_DEVICE(uart1, "pxa2xx-uart", 0, UART1, 0xd4017000, 0x30, 21, 22);
-PXA168_DEVICE(uart2, "pxa2xx-uart", 1, UART2, 0xd4018000, 0x30, 23, 24);
+PXA168_DEVICE(uart1, "pxa2xx-uart", 0, UART1, 0xd4017000, 0x30, 19, 20);
+PXA168_DEVICE(uart2, "pxa2xx-uart", 1, UART2, 0xd4018000, 0x30, 21, 22);
 PXA168_DEVICE(twsi0, "pxa2xx-i2c", 0, TWSI0, 0xd4011000, 0x28);
 PXA168_DEVICE(twsi1, "pxa2xx-i2c", 1, TWSI1, 0xd4025000, 0x28);
 PXA168_DEVICE(pwm1, "pxa168-pwm", 0, NONE, 0xd401a000, 0x10);
Quoted 2 lines

Is there anything wrong with the patch? Any suggestions please?

Hi Tanmay,

Nothing wrong with the patch. Sorry it was kept in the bottom of my mail box for such a long time.

Jason & Haojian,

I need your double-check and Ack. Thanks.

Quoted 4 lines

Thanks,

Tanmay