PXA: Fix typo in proc-xscale.S
PATCH 1/1 PXA: Fix typo in proc-xscale.S
--- arch/arm/mm/proc-xscale.S | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mm/proc-xscale.S +1 -1
@@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area) teq r2, #DMA_TO_DEVICE beq xscale_dma_clean_range b xscale_dma_flush_range -ENDPROC(xscsale_dma_a0_map_area) +ENDPROC(xscale_dma_a0_map_area) /* * dma_unmap_area(start, size, dir)
Signature · 1 line
1.7.4.1
PATCH 1/1 PXA: Fix typo in proc-xscale.S
Hi Marek,
Quoted 10 lines · Marek Vasut
Signed-off-by Marek Vasut <[email protected]>--- arch/arm/mm/proc-xscale.S | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mm/proc-xscale.S +0
-0
arch/arm/mm/proc-xscale.S ENTRY(xscale_dma_a0_map_area) · line 401
Quoted 8 lines
arch/arm/mm/proc-xscale.S +1
-1@@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area) teq r2, #DMA_TO_DEVICE beq xscale_dma_clean_range b xscale_dma_flush_range -ENDPROC(xscsale_dma_a0_map_area) +ENDPROC(xscale_dma_a0_map_area) /* * dma_unmap_area(start, size, dir)
Similar patch:
http://www.spinics.net/lists/arm-kernel/msg118258.html
has been sent to Russell quite a while ago,
but somehow got lost or something.
Signature · 2 lines
Regards, Igor.
PATCH 1/1 PXA: Fix typo in proc-xscale.S
Quoted 24 lines · Igor Grinberg
Hi Marek,
Quoted 21 lines · Marek Vasut
Signed-off-by Marek Vasut <[email protected]>---
arch/arm/mm/proc-xscale.S | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mm/proc-xscale.S +1
-1@@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area) teq r2, #DMA_TO_DEVICE beq xscale_dma_clean_range b xscale_dma_flush_range -ENDPROC(xscsale_dma_a0_map_area) +ENDPROC(xscale_dma_a0_map_area)/*
Quoted 7 lines
Quoted 1 line
*
dma_unmap_area(start, size, dir)Similar patch:
http://www.spinics.net/lists/arm-kernel/msg118258.htmlhas been sent to Russell quite a while ago,
but somehow got lost or something.
Hi,
I'm fine with the other one of course :) I didn't notice, thanks.
Eric, can you pick that one ?
Cheers
PATCH 1/1 PXA: Fix typo in proc-xscale.S
Quoted 30 lines · Marek Vasut
Quoted 29 lines · Igor Grinberg
Hi Marek,
Quoted 19 lines · Marek Vasut
Signed-off-by Marek Vasut <[email protected]>---
?arch/arm/mm/proc-xscale.S | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mm/proc-xscale.S +0
-0@@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area)? ? teq ? ? r2, #DMA_TO_DEVICE
? ? beq ? ?xscale_dma_clean_range
? ? b ? ? ?xscale_dma_flush_rangearch/arm/mm/proc-xscale.S +1
-1-ENDPROC(xscsale_dma_a0_map_area) +ENDPROC(xscale_dma_a0_map_area)Quoted 3 lines
?/*
? *
dma_unmap_area(start, size, dir)Similar patch:
http://www.spinics.net/lists/arm-kernel/msg118258.html
Quoted 9 lines
Quoted 2 lines
has been sent to Russell quite a while ago,
but somehow got lost or something.Hi,
I'm fine with the other one of course :) I didn't notice, thanks.
Eric, can you pick that one ?
Picked, will send to Russell soon.
Quoted 7 lines
Cheers
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 1/1 PXA: Fix typo in proc-xscale.S
In reply to Igor GrinbergQuoted 20 lines · Igor Grinberg
Hi Marek,
Quoted 16 lines · Marek Vasut
Signed-off-by Marek Vasut <[email protected]>--- arch/arm/mm/proc-xscale.S | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mm/proc-xscale.S +1
-1@@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area) teq r2, #DMA_TO_DEVICE beq xscale_dma_clean_range b xscale_dma_flush_range -ENDPROC(xscsale_dma_a0_map_area) +ENDPROC(xscale_dma_a0_map_area)
Quoted 8 lines
arch/arm/mm/proc-xscale.S ENTRY(xscale_dma_a0_map_area) · line 401
Quoted 2 lines
arch/arm/mm/proc-xscale.S +0
-0/* * dma_unmap_area(start, size, dir)Similar patch:
http://www.spinics.net/lists/arm-kernel/msg118258.htmlhas been sent to Russell quite a while ago,
but somehow got lost or something.
As I keep saying, I'm useless dealing with patches sent only by email - they tend to get quickly buried and forgotten, plus they need saving out, sometimes editing and transferring between machines to be applied.
The patch system greatly simplifies that effort, and ensures that patches don't get forgotten.
PATCH 1/1 PXA: Fix typo in proc-xscale.S
Quoted 26 lines · Russell King - ARM Linux
Quoted 25 lines · Igor Grinberg
Hi Marek,
Quoted 10 lines · Marek Vasut
Signed-off-by Marek Vasut <[email protected]>--- arch/arm/mm/proc-xscale.S | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mm/proc-xscale.S +0
-0arch/arm/mm/proc-xscale.S ENTRY(xscale_dma_a0_map_area) · line 401
Quoted 8 lines
arch/arm/mm/proc-xscale.S +1
-1@@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area) teq r2, #DMA_TO_DEVICE beq xscale_dma_clean_range b xscale_dma_flush_range -ENDPROC(xscsale_dma_a0_map_area) +ENDPROC(xscale_dma_a0_map_area) /* * dma_unmap_area(start, size, dir)Similar patch:
http://www.spinics.net/lists/arm-kernel/msg118258.html
Quoted 8 lines
Quoted 2 lines
has been sent to Russell quite a while ago,
but somehow got lost or something.As I keep saying, I'm useless dealing with patches sent only by email - they tend to get quickly buried and forgotten, plus they need saving out, sometimes editing and transferring between machines to be applied.
The patch system greatly simplifies that effort, and ensures that patches don't get forgotten.
Apparently, not many people read Documentation/arm/README :( May be it would be helpful to add a note to the MAINTAINERS file regarding the patch system and tweak scripts/get_maintainer.pl to spit it out in appropriate cases?
Signature · 2 lines
Regards, Igor.
PATCH 1/1 PXA: Fix typo in proc-xscale.S
Hello,
[adding Ben as the author of the linked patch to Cc:]
Quoted 34 lines · Igor Grinberg
Quoted 32 lines · Russell King - ARM Linux
Quoted 20 lines · Igor Grinberg
Hi Marek,
Quoted 16 lines · Marek Vasut
Signed-off-by Marek Vasut <[email protected]>--- arch/arm/mm/proc-xscale.S | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mm/proc-xscale.S +1
-1@@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area) teq r2, #DMA_TO_DEVICE beq xscale_dma_clean_range b xscale_dma_flush_range -ENDPROC(xscsale_dma_a0_map_area) +ENDPROC(xscale_dma_a0_map_area)Quoted 7 lines
arch/arm/mm/proc-xscale.S ENTRY(xscale_dma_a0_map_area) · line 401
Quoted 2 lines
arch/arm/mm/proc-xscale.S +0
-0/* * dma_unmap_area(start, size, dir)Similar patch:
http://www.spinics.net/lists/arm-kernel/msg118258.htmlhas been sent to Russell quite a while ago,
but somehow got lost or something.As I keep saying, I'm useless dealing with patches sent only by email - they tend to get quickly buried and forgotten, plus they need saving out, sometimes editing and transferring between machines to be applied.
Quoted 7 lines
Quoted 2 lines
The patch system greatly simplifies that effort, and ensures that patches don't get forgotten.
Apparently, not many people read
Documentation/arm/README:( May be it would be helpful to add a note to theMAINTAINERSfile regarding the patch system and tweakscripts/get_maintainer.plto spit it out in appropriate cases?
another problem is that the patch system is for reviewed patches only. If the patch is forgotten before it gets some reply sending it to the patch system is wrong (at least for non-trivial patches).
Patchwork comes to mind. That doesn't forget patches.
I think for that to be practical for lakml some automatic delegation would be needed though.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 PXA: Fix typo in proc-xscale.S
Quoted 3 lines · Uwe Kleine-K?nig
another problem is that the patch system is for reviewed patches only. If the patch is forgotten before it gets some reply sending it to the patch system is wrong (at least for non-trivial patches).
That's where pester power comes in - if its still sitting around unreviewed a week later (assuming there's no long holidays) then it needs to be chased.
Quoted 3 lines
Patchwork comes to mind. That doesn't forget patches.
I think for that to be practical for lakml some automatic delegation would be needed though.
I'm not convinced that patchwork ultimately reduces the amount of work required - I think it moves the workload from the patch submitter to the folk reviewing patches and applying them, who are already overworked.
We have an army of patch submitters but relatively few people reviewing and applying, so increasing their workload is not really fair. We need the workload for people up the chain of patches (who handle a greater volume of patches) to be less than those down the chain of patches.
Eg, I'm currently struggling to catch up with the email from the last six days. Having spent about six hours over the last two days trying to work through the backlog, I've made a fairly insignificant dent - about 1100 unread messages yesterday morning to 930 unread messages at around this point in time. I estimate at this rate I'll have caught up by end of next week - probably less because I normally seem to drop 10% of email on the floor unanswered irrespective of the volume.
I already feel like I need another holiday!