Afatech AF9015 & dual tuner - dual_mode B.R.O.K.E.N.

DISCUSSION poma 3 participants 6 messages Feb 16, 2011 – Apr 29, 2011 Media (V4L/DVB)

lore

Share & tools

lore

poma

author

2011-02-16 05:26 UTC #0 lore raw

To num_adapters = 2, or num_adapters = 1: that is the question!

rgds,
poma

poma

author

2011-02-17 09:23 UTC #1 lore raw

Quoted 1 line · poma

To num_adapters = 2, or num_adapters = 1: that is the question!

In dual tuner mode, after a while device become unrensponsive, eventually after S5 aka 'Soft Off' system doesn't even boot! Didn't even mention all sorts of 'mumbo-jumbo' with S3 aka 'Suspend to RAM'. Antti, please consider adding 'dual_mode' parameter back.

"dvb_usb_af9015 dual_mode=0"

Devices to consider:

Not Only TV/LifeView DUAL DVB-T USB LV52T
(equivalent to TerraTec Cinergy T Stick Dual RC)
Afatech AF9013/AF9015 & 2x MaxLinear MxL5007T
http://www.notonlytv.net/p_lv52t.html

KWorld USB Dual DVB-T TV Stick (DVB-T 399U)
Afatech AF9013/AF9015 & 2x MaxLinear MxL5003S
http://www.kworld-global.com/main/prod_in.aspx?mnuid=1248&modid=6&prodid=73

DigitalNow TinyTwin DVB-T Receiver
Afatech AF9013/AF9015 & 2x MaxLinear MxL5005S
http://www.digitalnow.com.au/product_pages/TinyTwin.html

http://www.spinics.net/lists/linux-dvb/msg31616.html
http://www.spinics.net/lists/linux-dvb/msg31621.html

rgds,
poma

poma

author

2011-02-17 22:11 UTC #2 lore raw

Quoted 21 lines · poma

Quoted 1 line · poma
To num_adapters = 2, or num_adapters = 1: that is the question!
In dual tuner mode, after a while device become unrensponsive, eventually after S5 aka 'Soft Off' system doesn't even boot! Didn't even mention all sorts of 'mumbo-jumbo' with S3 aka 'Suspend to RAM'. Antti, please consider adding 'dual_mode' parameter back.
"dvb_usb_af9015 dual_mode=0"
Devices to consider:
Not Only TV/LifeView DUAL DVB-T USB LV52T
(equivalent to TerraTec Cinergy T Stick Dual RC)
Afatech AF9013/AF9015 & 2x MaxLinear MxL5007T
http://www.notonlytv.net/p_lv52t.html
KWorld USB Dual DVB-T TV Stick (DVB-T 399U)
Afatech AF9013/AF9015 & 2x MaxLinear MxL5003S
http://www.kworld-global.com/main/prod_in.aspx?mnuid=1248&modid=6&prodid=73

Quoted 6 lines

DigitalNow TinyTwin DVB-T Receiver
Afatech AF9013/AF9015 & 2x MaxLinear MxL5005S
http://www.digitalnow.com.au/product_pages/TinyTwin.html
http://www.spinics.net/lists/linux-dvb/msg31616.html
http://www.spinics.net/lists/linux-dvb/msg31621.html

This patch restore dvb_usb_af9015 'dual mode' parameter - "disable dual mode by default because it is buggy". Enabled mode:
options dvb_usb_af9015 dual_mode=1
in modprobe referent file.

linux/drivers/media/dvb/dvb-usb/af9015.c +6 -0

@@ -40,6 +40,9 @@
 static int dvb_usb_af9015_remote;
 module_param_named(remote, dvb_usb_af9015_remote, int, 0644);
 MODULE_PARM_DESC(remote, "select remote");
+static int dvb_usb_af9015_dual_mode;
+module_param_named(dual_mode, dvb_usb_af9015_dual_mode, int, 0644);
+MODULE_PARM_DESC(dual_mode, "enable dual mode");
 DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr);
 
 static DEFINE_MUTEX(af9015_usb_mutex);

@@ -841,6 +844,9 @@
 		goto error;
 	af9015_config.dual_mode = val;
 	deb_info("%s: TS mode:%d\n", __func__, af9015_config.dual_mode);
+	/* disable dual mode by default because it is buggy */
+	if (!dvb_usb_af9015_dual_mode)
+		af9015_config.dual_mode = 0;
 
 	/* Set adapter0 buffer size according to USB port speed, adapter1 buffer
 	   size can be static because it is enabled only USB2.0 */

rgds,
poma

linux/drivers/media/dvb/dvb-usb/af9015.c +6 -0

@@ -40,6 +40,9 @@
 static int dvb_usb_af9015_remote;
 module_param_named(remote, dvb_usb_af9015_remote, int, 0644);
 MODULE_PARM_DESC(remote, "select remote");
+static int dvb_usb_af9015_dual_mode;
+module_param_named(dual_mode, dvb_usb_af9015_dual_mode, int, 0644);
+MODULE_PARM_DESC(dual_mode, "enable dual mode");
 DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr);
 
 static DEFINE_MUTEX(af9015_usb_mutex);

@@ -841,6 +844,9 @@
 		goto error;
 	af9015_config.dual_mode = val;
 	deb_info("%s: TS mode:%d\n", __func__, af9015_config.dual_mode);
+	/* disable dual mode by default because it is buggy */
+	if (!dvb_usb_af9015_dual_mode)
+		af9015_config.dual_mode = 0;
 
 	/* Set adapter0 buffer size according to USB port speed, adapter1 buffer
 	   size can be static because it is enabled only USB2.0 */

Mauro Carvalho Chehab

2011-04-29 12:03 UTC #3 lore raw

Hi Antti,

I'm assuming that you're reviewing this patchset, so, I'll update patchwork status accordingly.

Mauro

Em 17-02-2011 20:11, poma escreveu:

Quoted 62 lines

Quoted 21 lines · poma
Quoted 1 line · poma
To num_adapters = 2, or num_adapters = 1: that is the question!
In dual tuner mode, after a while device become unrensponsive, eventually after S5 aka 'Soft Off' system doesn't even boot! Didn't even mention all sorts of 'mumbo-jumbo' with S3 aka 'Suspend to RAM'. Antti, please consider adding 'dual_mode' parameter back.
"dvb_usb_af9015 dual_mode=0"
Devices to consider:
Not Only TV/LifeView DUAL DVB-T USB LV52T
(equivalent to TerraTec Cinergy T Stick Dual RC)
Afatech AF9013/AF9015 & 2x MaxLinear MxL5007T
http://www.notonlytv.net/p_lv52t.html
KWorld USB Dual DVB-T TV Stick (DVB-T 399U)
Afatech AF9013/AF9015 & 2x MaxLinear MxL5003S
http://www.kworld-global.com/main/prod_in.aspx?mnuid=1248&modid=6&prodid=73
Quoted 6 lines
DigitalNow TinyTwin DVB-T Receiver
Afatech AF9013/AF9015 & 2x MaxLinear MxL5005S
http://www.digitalnow.com.au/product_pages/TinyTwin.html
http://www.spinics.net/lists/linux-dvb/msg31616.html
http://www.spinics.net/lists/linux-dvb/msg31621.html
This patch restore dvb_usb_af9015 'dual mode' parameter - "disable dual mode by default because it is buggy". Enabled mode:
options dvb_usb_af9015 dual_mode=1
in modprobe referent file.
..
linux/drivers/media/dvb/dvb-usb/af9015.c 2011-02-17 21:58:42.099040739 +0100 renamed from linux/drivers/media/dvb/dvb-usb/af9015.c 2011-01-10 16:24:45.000000000 +0100 +6 -0
@@ -40,6 +40,9 @@
 static int dvb_usb_af9015_remote;
 module_param_named(remote, dvb_usb_af9015_remote, int, 0644);
 MODULE_PARM_DESC(remote, "select remote");
+static int dvb_usb_af9015_dual_mode;
+module_param_named(dual_mode, dvb_usb_af9015_dual_mode, int, 0644);
+MODULE_PARM_DESC(dual_mode, "enable dual mode");
 DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr);
 
 static DEFINE_MUTEX(af9015_usb_mutex);
@@ -841,6 +844,9 @@
         goto error;
     af9015_config.dual_mode = val;
     deb_info("%s: TS mode:%d\n", __func__, af9015_config.dual_mode);
+    /* disable dual mode by default because it is buggy */
+    if (!dvb_usb_af9015_dual_mode)
+        af9015_config.dual_mode = 0;
 
     /* Set adapter0 buffer size according to USB port speed, adapter1 buffer
        size can be static because it is enabled only USB2.0 */
..
rgds,
poma

Antti Palosaari

2011-04-29 12:10 UTC #4 lore raw

Moikka Mauro et all,

I will NACK this.

Surely it is not proper solution. And after all, I haven't got any other reports there is such problem. AF9015 is probably most common DVB-T USB hardware today and if there is major problems I am the first person got reports.

regards,
Antti

Quoted 71 lines · Mauro Carvalho Chehab

Hi Antti,
I'm assuming that you're reviewing this patchset, so, I'll update patchwork status accordingly.
Mauro
Em 17-02-2011 20:11, poma escreveu:
Quoted 62 lines
Quoted 21 lines · poma
Quoted 1 line · poma
To num_adapters = 2, or num_adapters = 1: that is the question!
In dual tuner mode, after a while device become unrensponsive, eventually after S5 aka 'Soft Off' system doesn't even boot! Didn't even mention all sorts of 'mumbo-jumbo' with S3 aka 'Suspend to RAM'. Antti, please consider adding 'dual_mode' parameter back.
"dvb_usb_af9015 dual_mode=0"
Devices to consider:
Not Only TV/LifeView DUAL DVB-T USB LV52T
(equivalent to TerraTec Cinergy T Stick Dual RC)
Afatech AF9013/AF9015& 2x MaxLinear MxL5007T
http://www.notonlytv.net/p_lv52t.html
KWorld USB Dual DVB-T TV Stick (DVB-T 399U)
Afatech AF9013/AF9015& 2x MaxLinear MxL5003S
http://www.kworld-global.com/main/prod_in.aspx?mnuid=1248&modid=6&prodid=73
Quoted 6 lines
DigitalNow TinyTwin DVB-T Receiver
Afatech AF9013/AF9015& 2x MaxLinear MxL5005S
http://www.digitalnow.com.au/product_pages/TinyTwin.html
http://www.spinics.net/lists/linux-dvb/msg31616.html
http://www.spinics.net/lists/linux-dvb/msg31621.html
This patch restore dvb_usb_af9015 'dual mode' parameter - "disable dual mode by default because it is buggy". Enabled mode:
options dvb_usb_af9015 dual_mode=1
in modprobe referent file.
..
linux/drivers/media/dvb/dvb-usb/af9015.c 2011-02-17 21:58:42.099040739 +0100 renamed from linux/drivers/media/dvb/dvb-usb/af9015.c 2011-01-10 16:24:45.000000000 +0100 +6 -0
@@ -40,6 +40,9 @@
  static int dvb_usb_af9015_remote;
  module_param_named(remote, dvb_usb_af9015_remote, int, 0644);
  MODULE_PARM_DESC(remote, "select remote");
+static int dvb_usb_af9015_dual_mode;
+module_param_named(dual_mode, dvb_usb_af9015_dual_mode, int, 0644);
+MODULE_PARM_DESC(dual_mode, "enable dual mode");
  DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr);
 
  static DEFINE_MUTEX(af9015_usb_mutex);
@@ -841,6 +844,9 @@
          goto error;
      af9015_config.dual_mode = val;
      deb_info("%s: TS mode:%d\n", __func__, af9015_config.dual_mode);
+    /* disable dual mode by default because it is buggy */
+    if (!dvb_usb_af9015_dual_mode)
+        af9015_config.dual_mode = 0;
 
      /* Set adapter0 buffer size according to USB port speed, adapter1 buffer
         size can be static because it is enabled only USB2.0 */
..
rgds,
poma

Signature · 1 line

http://palosaari.fi/

poma

author

2011-04-29 23:06 UTC #5 lore raw

Quoted 5 lines · Antti Palosaari

Moikka Mauro et all,
I will NACK this.
Surely it is not proper solution. And after all, I haven't got any other reports there is such problem. AF9015 is probably most common DVB-T USB hardware today and if there is major problems I am the first person got reports.

If you are interested, I'm willing to do more testing on this particular device, to clear up ;)

rgds,
poma