ALSA: HDA: Fix automute for Gateway NV79

PATCH In review David Henningsson 2 participants 2 messages Apr 29, 2011 Sound

Share & tools

David Henningsson

author

2011-04-29 12:17 UTC #0 lore raw

PATCH 1/1 ALSA: HDA: Fix automute for Gateway NV79

The PCI SSID is 1025:031c and the codec SSID is 1025:031d, so the driver mistakes this for a SKU value, but looking at the numbers, this is obviously wrong.

Signature · 2 lines

David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

Quoted 1 line

From a57dcea812c629ff341f48b531454557499de008 Mon Sep 17 00:00:00 2001

From: David Henningsson <[email protected]>
Date: Fri, 29 Apr 2011 14:10:55 +0200
Subject: [PATCH] ALSA: HDA: Fix automute for Gateway NV79

The PCI SSID is 1025:031c and the codec SSID is 1025:031d, so the driver mistakes this for a SKU value, but looking at the numbers, this is obviously wrong.

Cc [email protected] (2.6.38+)

BugLink http://bugs.launchpad.net/bugs/761861

Signed-off-by David Henningsson <[email protected]>

---
 sound/pci/hda/patch_realtek.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

sound/pci/hda/patch_realtek.c +6 -0

index 6c94c4a..35efee6 100644
@@ -19486,6 +19486,7 @@ enum {
 	ALC272_FIXUP_MARIO,
 	ALC662_FIXUP_CZC_P10T,
 	ALC662_FIXUP_GIGABYTE,
+	ALC662_FIXUP_SKU_IGNORE,
 };
 
 static const struct alc_fixup alc662_fixups[] = {

@@ -19521,10 +19522,15 @@ static const struct alc_fixup alc662_fixups[] = {
 			{ }
 		}
 	},
+	[ALC662_FIXUP_SKU_IGNORE] = {
+		.type = ALC_FIXUP_SKU,
+		.v.sku = ALC_FIXUP_SKU_IGNORE,
+	},
 };
 
 static struct snd_pci_quirk alc662_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1025, 0x0308, "Acer Aspire 8942G", ALC662_FIXUP_ASPIRE),
+	SND_PCI_QUIRK(0x1025, 0x031c, "Gateway NV79", ALC662_FIXUP_SKU_IGNORE),
 	SND_PCI_QUIRK(0x1025, 0x038b, "Acer Aspire 8943G", ALC662_FIXUP_ASPIRE),
 	SND_PCI_QUIRK(0x144d, 0xc051, "Samsung R720", ALC662_FIXUP_IDEAPAD),
 	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte", ALC662_FIXUP_GIGABYTE),

Signature · 1 line

1.7.4.1

Takashi Iwai

2011-04-29 12:21 UTC #1 lore raw

At Fri, 29 Apr 2011 14:17:46 +0200,

Quoted 4 lines · David Henningsson

The PCI SSID is 1025:031c and the codec SSID is 1025:031d, so the driver mistakes this for a SKU value, but looking at the numbers, this is obviously wrong.

Applied now. Thanks.

Takashi

Quoted 52 lines

Signature · 4 lines
-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
[2 0001-ALSA-HDA-Fix-automute-for-Gateway-NV79.patch <text/x-patch (7bit)>]
Quoted 1 line
From a57dcea812c629ff341f48b531454557499de008 Mon Sep 17 00:00:00 2001
From: David Henningsson <[email protected]>
Date: Fri, 29 Apr 2011 14:10:55 +0200
Subject: [PATCH] ALSA: HDA: Fix automute for Gateway NV79
The PCI SSID is 1025:031c and the codec SSID is 1025:031d, so the driver mistakes this for a SKU value, but looking at the numbers, this is obviously wrong.
Cc [email protected] (2.6.38+)
BugLink http://bugs.launchpad.net/bugs/761861
Signed-off-by David Henningsson <[email protected]>
---
 sound/pci/hda/patch_realtek.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
sound/pci/hda/patch_realtek.c +6 -0
index 6c94c4a..35efee6 100644
@@ -19486,6 +19486,7 @@ enum {
 	ALC272_FIXUP_MARIO,
 	ALC662_FIXUP_CZC_P10T,
 	ALC662_FIXUP_GIGABYTE,
+	ALC662_FIXUP_SKU_IGNORE,
 };
 
 static const struct alc_fixup alc662_fixups[] = {
@@ -19521,10 +19522,15 @@ static const struct alc_fixup alc662_fixups[] = {
 			{ }
 		}
 	},
+	[ALC662_FIXUP_SKU_IGNORE] = {
+		.type = ALC_FIXUP_SKU,
+		.v.sku = ALC_FIXUP_SKU_IGNORE,
+	},
 };
 
 static struct snd_pci_quirk alc662_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1025, 0x0308, "Acer Aspire 8942G", ALC662_FIXUP_ASPIRE),
+	SND_PCI_QUIRK(0x1025, 0x031c, "Gateway NV79", ALC662_FIXUP_SKU_IGNORE),
 	SND_PCI_QUIRK(0x1025, 0x038b, "Acer Aspire 8943G", ALC662_FIXUP_ASPIRE),
 	SND_PCI_QUIRK(0x144d, 0xc051, "Samsung R720", ALC662_FIXUP_IDEAPAD),
 	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte", ALC662_FIXUP_GIGABYTE),
Signature · 1 line
1.7.4.1