Skip to contentSkip to conversation

VMSTATE_U64 vs. VMSTATE_UINT64

DISCUSSION Jan Kiszka 4 participants 6 messages May 4, 2011 – May 9, 2011 KVM

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

Hi guys,

can anyone comment on commit e4d6d49061 ("introduce VMSTATE_U64") in qemu-kvm again? I strongly suspect this thing was only introduced to be able to grab from a __u64 (for kvmclock) without generating a compiler warning that you may got when using uint64_t, right?

Thanks,
Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
#1 lore raw
Quoted 10 lines · Jan Kiszka

Hi guys,

can anyone comment on commit e4d6d49061 ("introduce VMSTATE_U64") in qemu-kvm again? I strongly suspect this thing was only introduced to be able to grab from a __u64 (for kvmclock) without generating a compiler warning that you may got when using uint64_t, right?

Thanks,
Jan

I don't remember if it was kvmclock. IIRC, it was my irqchip implementation at the time. But I do remember the reason: it was indeed to be able to grab kernel data structures directly without a compile warning.

author
#2 lore raw
Quoted 8 lines · Glauber Costa
Quoted 7 lines · Jan Kiszka

Hi guys,

can anyone comment on commit e4d6d49061 ("introduce VMSTATE_U64") in qemu-kvm again? I strongly suspect this thing was only introduced to be able to grab from a __u64 (for kvmclock) without generating a compiler warning that you may got when using uint64_t, right?

Quoted 8 lines
Quoted 3 lines

Thanks,
Jan

I don't remember if it was kvmclock. IIRC, it was my irqchip implementation at the time. But I do remember the reason: it was indeed to be able to grab kernel data structures directly without a compile warning.

Perfect. Then I will also include a revert/drop patch in my series that switches the only user, kvmclock, to the upstream version.

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
#3 lore raw

Trouble activating windows xp when booted with KVM

Hi all,

I used qemu-kvm to create a windows xp image.
The image boots fine on rhel5 64 bit and up and running with networking. However I seem to have issue activating from a window instance over KVM and fine with real hardware.

I am using kvm-86 version.
Host is rhel5 linux 64 bit.
Guest is Windows xp pro sp2

Has anyone encountered this issue ?

Cheers,
Majid

#4 lore raw
In reply to Jan Kiszka
Quoted 18 lines · Jan Kiszka
Quoted 8 lines · Glauber Costa
Quoted 7 lines · Jan Kiszka

Hi guys,

can anyone comment on commit e4d6d49061 ("introduce VMSTATE_U64") in qemu-kvm again? I strongly suspect this thing was only introduced to be able to grab from a __u64 (for kvmclock) without generating a compiler warning that you may got when using uint64_t, right?

Quoted 8 lines
Quoted 3 lines

Thanks,
Jan

I don't remember if it was kvmclock. IIRC, it was my irqchip implementation at the time. But I do remember the reason: it was indeed to be able to grab kernel data structures directly without a compile warning.

Quoted 5 lines

Perfect. Then I will also include a revert/drop patch in my series that switches the only user, kvmclock, to the upstream version.

Jan

I am fine with that.

#5 lore raw
In reply to Jan Kiszka
Quoted 6 lines · Jan Kiszka

Hi guys,

can anyone comment on commit e4d6d49061 ("introduce VMSTATE_U64") in qemu-kvm again? I strongly suspect this thing was only introduced to be able to grab from a __u64 (for kvmclock) without generating a compiler warning that you may got when using uint64_t, right?

Yes, it was that on 64 bit u64 was unsigned long long and uint64_t was only unsigned long or something like that. I have forgot if it was kvmclock or irqchip also. I think that Marcelo also requested it at some point, but dont' remember details :-(

Later, Juan.