Skip to contentSkip to conversation

b43: drop invalid IMCFGLO workaround

PATCH New Rafał Miłecki 2 participants 2 messages May 5, 2011 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 b43: drop invalid IMCFGLO workaround

We were performing it on wrong core, it was outdated and is already implemented in ssb.

---
 drivers/net/wireless/b43/main.c |   28 +---------------------------
 1 files changed, 1 insertions(+), 27 deletions(-)
drivers/net/wireless/b43/main.c +1 -27
index 5af40d9..f907df0 100644
@@ -4213,33 +4213,7 @@ static void b43_bluetooth_coext_disable(struct b43_wldev *dev)
 
 static void b43_imcfglo_timeouts_workaround(struct b43_wldev *dev)
 {
-#ifdef CONFIG_SSB_DRIVER_PCICORE
-	struct ssb_bus *bus = dev->dev->bus;
-	u32 tmp;
-
-	if (bus->pcicore.dev &&
-	    bus->pcicore.dev->id.coreid == SSB_DEV_PCI &&
-	    bus->pcicore.dev->id.revision <= 5) {
-		/* IMCFGLO timeouts workaround. */
-		tmp = ssb_read32(dev->dev, SSB_IMCFGLO);
-		switch (bus->bustype) {
-		case SSB_BUSTYPE_PCI:
-		case SSB_BUSTYPE_PCMCIA:
-			tmp &= ~SSB_IMCFGLO_REQTO;
-			tmp &= ~SSB_IMCFGLO_SERTO;
-			tmp |= 0x32;
-			break;
-		case SSB_BUSTYPE_SSB:
-			tmp &= ~SSB_IMCFGLO_REQTO;
-			tmp &= ~SSB_IMCFGLO_SERTO;
-			tmp |= 0x53;
-			break;
-		default:
-			break;
-		}
-		ssb_write32(dev->dev, SSB_IMCFGLO, tmp);
-	}
-#endif /* CONFIG_SSB_DRIVER_PCICORE */
+	/* TODO: implement 80211 core workaround here */
 }
 
 static void b43_set_synth_pu_delay(struct b43_wldev *dev, bool idle)
Signature · 1 line
1.7.3.4
#1 lore raw

PATCH 1/1 b43: drop invalid IMCFGLO workaround

Quoted 7 lines · Rafa? Mi?ecki

We were performing it on wrong core, it was outdated and is already implemented in ssb.

---
  drivers/net/wireless/b43/main.c |   28 +---------------------------
  1 files changed, 1 insertions(+), 27 deletions(-)

ACK.

Larry