Skip to contentSkip to conversation

mm: memory: remove unreachable code

PATCH In review Maxin B John 2 participants 3 messages May 8, 2011

Subsystems (2)
Memory management MM core
lore
Share & tools
lore

Maxin B John

author
#0 lore raw

PATCH 1/1 mm: memory: remove unreachable code

Remove the unreachable code found in mm/memory.c

Signed-off-by Maxin B. John <[email protected]>

---

mm/memory.c +0 -1
index 27f4253..d3b30af 100644
@@ -3695,7 +3695,6 @@ static int __access_remote_vm(struct task_struct *tsk, struct mm_struct *mm,
 			if (ret <= 0)
 #endif
 				break;
-			bytes = ret;
 		} else {
 			bytes = len;
 			offset = addr & (PAGE_SIZE-1);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#1 lore raw
Quoted 9 lines · Maxin B John

Remove the unreachable code found in mm/memory.c

Signed-off-by Maxin B. John<[email protected]>

---

mm/memory.c +0 -0
index 27f4253..d3b30af 100644

mm/memory.c static int __access_remote_vm(struct task_struct *tsk, struct mm_struct *mm, · line 3700

Quoted 7 lines
mm/memory.c +0 -1
@@ -3695,7 +3695,6 @@ static int __access_remote_vm(struct task_struct *tsk, struct mm_struct *mm,
  			if (ret<= 0)
  #endif
  				break;
-			bytes = ret;
  		} else {
  			bytes = len;
  			offset = addr&  (PAGE_SIZE-1);

Is it really impossible for vma->vm_ops->access to return a positive value?

Signature · 8 lines
All rights reversed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
author
#2 lore raw

Hi,

Quoted 4 lines

Is it really impossible for vma->vm_ops->access to return a positive value?

Got it .. Thank you very much for pointing it out.

Best Regards,
Maxin

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>