Skip to contentSkip to conversation

sparc32/LEON: Added __init declaration to leon_flush_needed()

PATCH In review Matthias Rosenfelder 2 participants 2 messages May 10, 2011 – May 11, 2011 SPARC + UltraSPARC (sparc/sparc64)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sparc32/LEON: Added __init declaration to leon_flush_needed()

The function leon_flush_needed() is called only during bootup from another __init function. Therefore, we can add __init to leon_flush_needed().

---
  arch/sparc/mm/leon_mm.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
arch/sparc/mm/leon_mm.c +1 -1
index c0e0129..e485a68 100644
@@ -226,7 +226,7 @@ void leon3_getCacheRegs(struct leon3_cacheregs *regs)
   * Leon2 and Leon3 differ in their way of telling cache information
   *
   */
-int leon_flush_needed(void)
+int __init leon_flush_needed(void)
  {
         int flush_needed = -1;
         unsigned int ssize, sets;

--
1.6.4.2

Acked-by on v1 1/1
#1 lore raw
Quoted 25 lines · Matthias Rosenfelder

The function leon_flush_needed() is called only during bootup from another __init function. Therefore, we can add __init to leon_flush_needed().

---
 arch/sparc/mm/leon_mm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/sparc/mm/leon_mm.c +1 -1
index c0e0129..e485a68 100644
@@ -226,7 +226,7 @@ void leon3_getCacheRegs(struct leon3_cacheregs *regs)
  * Leon2 and Leon3 differ in their way of telling cache information
  *
  */
-int leon_flush_needed(void)
+int __init leon_flush_needed(void)
 {
        int flush_needed = -1;
        unsigned int ssize, sets;
Signature · 1 line
1.6.4.2

Please change to the standard commit message format: "sparc32,leon: " instead of sparc32/LEON. Otherwise it looks good,

Thanks,
Daniel