MX53: Add initial support for MX53SMD board.
PATCH 1/1 MX53: Add initial support for MX53SMD board.
--- MAINTAINERS | 1 + board/freescale/mx53smd/Makefile | 48 ++++++++ board/freescale/mx53smd/imximage.cfg | 96 +++++++++++++++ board/freescale/mx53smd/mx53smd.c | 222 ++++++++++++++++++++++++++++++++++ boards.cfg | 1 + include/configs/mx53smd.h | 190 +++++++++++++++++++++++++++++ 6 files changed, 558 insertions(+), 0 deletions(-) create mode 100644 board/freescale/mx53smd/Makefile create mode 100644 board/freescale/mx53smd/imximage.cfg create mode 100644 board/freescale/mx53smd/mx53smd.c create mode 100644 include/configs/mx53smd.h
MAINTAINERS +1 -0
@@ -638,6 +638,7 @@ Kristoffer Ericson <[email protected]> Fabio Estevam <[email protected]> mx31pdk i.MX31 + mx53smd i.MX53 Peter Figuli <[email protected]>
board/freescale/mx53smd/Makefile new file +48 -0
48 lines not on this page · raw message
board/freescale/mx53smd/imximage.cfg new file +96 -0
96 lines not on this page · raw message
board/freescale/mx53smd/mx53smd.c new file +222 -0
222 lines not on this page · raw message
boards.cfg +1 -0
@@ -124,6 +124,7 @@ ca9x4_ct_vxp arm armv7 vexpress armltd efikamx arm armv7 efikamx - mx5 mx51evk arm armv7 mx51evk freescale mx5 mx51evk:IMX_CONFIG=board/freescale/mx51evk/imximage.cfg mx53evk arm armv7 mx53evk freescale mx5 mx53evk:IMX_CONFIG=board/freescale/mx53evk/imximage.cfg +mx53smd arm armv7 mx53smd freescale mx5 mx53smd:IMX_CONFIG=board/freescale/mx53smd/imximage.cfg vision2 arm armv7 vision2 ttcontrol mx5 cm_t35 arm armv7 cm_t35 - omap3 omap3_overo arm armv7 overo - omap3
include/configs/mx53smd.h new file +190 -0
190 lines not on this page · raw message
Signature · 1 line
1.6.0.4
PATCH 1/1 MX53: Add initial support for MX53SMD board.
Quoted 2 lines · Fabio Estevam
Signed-off-by Fabio Estevam <[email protected]>---
Hi Fabio,
only a few comments.
board/freescale/mx53smd/imximage.cfg line 2
Quoted 8 lines
board/freescale/mx53smd/imximage.cfg new file +2
-0@@ -0,0 +1,96 @@ +# +# (C Copyright 2009
Can you add the missing ")" ? I know it was my mistake, but we are spreading this on more files ;-)
board/freescale/mx53smd/imximage.cfg line 15
Quoted 13 lines
board/freescale/mx53smd/imximage.cfg new file +13
-0+int board_mmc_getcd(u8 *cd, struct mmc *mmc) +{ + *cd = mxc_gpio_get(77); /*GPIO3_13*/ + + return 0; +} + +int board_mmc_init(bd_t *bis) +{ + u32 index; + s32 status = 0; + + for (index = 0; index < CONFIG_SYS_FSL_ESDHC_NUM; index++) {
You have a loop, but you set CONFIG_SYS_FSL_ESDHC_NUM to 1. How many SD slots has this board ? If you have only one, do we need the loop ? I know, this is a personal taste, I am not against if you think the code is clear enough. As I do not know your board, I want mainly know if this board supports more as one slot, maybe in future.
board/freescale/mx53smd/imximage.cfg line 19
Quoted 4 lines
board/freescale/mx53smd/imximage.cfg new file +4
-0+int board_late_init(void) +{ + return 0; +}
If you do not need this function, simply drop BOARD_LATE_INIT from the config file and remove this function.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
Fabio Estevam
reviewerPATCH 1/1 MX53: Add initial support for MX53SMD board.
Hi Stefano,
On Fri, May 13, 2011 at 6:01 AM, Stefano Babic <[email protected]> wrote:
...
Quoted 5 lines
board/freescale/mx53smd/imximage.cfg line 2
Quoted 2 lines
board/freescale/mx53smd/imximage.cfg new file +2
-0+# +# (C Copyright 2009Can you add the missing ")" ? I know it was my mistake, but we are spreading this on more files ;-)
Sure. Will send it in v2.
...
Quoted 4 lines
Quoted 4 lines
board/freescale/mx53smd/mx53smd.c new file +4
-0+int board_mmc_init (bd_t *bis) +{ + ? ? u32 index; + ? ? s32 status = 0;
Quoted 8 lines
Quoted 2 lines
+
+ ? ? for (index = 0; index <CONFIG_SYS_FSL_ESDHC_NUM; index++) {You have a loop, but you set
CONFIG_SYS_FSL_ESDHC_NUMto 1. How many SD slots has this board ? If you have only one, do we need the loop ? I know, this is a personal taste, I am not against if you think the code is clear enough. As I do not know your board, I want mainly know if this board supports more as one slot, maybe in future.
Yes, it has a standard SD connector on esdhc1 and also a iNAND on esdhc3 . On this patch I only enable esdhc1, but I plan to add support to the iNAND in the future.
Quoted 8 lines
board/freescale/mx53smd/mx53smd.c line 215
Quoted 5 lines
board/freescale/mx53smd/mx53smd.c new file +4
-0+int board_late_init (void ) +{ + ? ? return 0; +}If you do not need this function, simply drop
BOARD_LATE_INITfrom the config file and remove this function.
OK, good point.
Regards,
Fabio Estevam