Skip to contentSkip to conversation

Kernel command line options for runqemu

PATCH RESEND In review Gary Thomas 3 participants 4 messages May 16, 2011

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 Kernel command line options for runqemu

This patch lets the user add options to the kernel command line when started via runqemu. Very useful for things like 'psplash=false'

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

From eaeb894f1bd4b769ec05c28cca4e31f334339261 Mon Sep 17 00:00:00 2001
From: Gary Thomas <[email protected]>
Date: Mon, 16 May 2011 05:29:24 -0600
Subject: [PATCH] runqemu: allow kernel command line options to be specified by user

---
 scripts/runqemu |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
scripts/runqemu +1 -1
index a09362c..2c3f6f4 100755
@@ -51,7 +51,7 @@ ROOTFS=""
 LAZY_ROOTFS=""
 SCRIPT_QEMU_OPT=""
 SCRIPT_QEMU_EXTRA_OPT=""
-SCRIPT_KERNEL_OPT=""
+SCRIPT_KERNEL_OPT=${SCRIPT_KERNEL_OPT:-""}
 
 TMPDIR=""
 
Signature · 1 line
1.7.3.4
#1 lore raw
Quoted 9 lines · Gary Thomas

This patch lets the user add options to the kernel command line when started via runqemu. Very useful for things like 'psplash=false'

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

Gary,

This is a reasonable idea, but it exposes an internal variable that might change in the future, so am I hesitant to take this.

Sau!

#2 lore raw
Quoted 6 lines · Saul Wold
Quoted 5 lines · Gary Thomas

This patch lets the user add options to the kernel command line when started via runqemu. Very useful for things like 'psplash=false'

Quoted 8 lines
Quoted 4 lines

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

Gary,

This is a reasonable idea, but it exposes an internal variable that might change in the future, so am I hesitant to take this.

Without it, the only way to change the kernel command line is by editing the script, which doesn't seem very friendly.

Would you feel better if it were a special variable, just for this purpose, which is by default empty? I was just using the infrastructure that was already in place.

Thanks

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
#3 lore raw
Quoted 17 lines · Gary Thomas
Quoted 11 lines · Saul Wold
Quoted 9 lines · Gary Thomas

This patch lets the user add options to the kernel command line when started via runqemu. Very useful for things like 'psplash=false'

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

Quoted 4 lines

Gary,

This is a reasonable idea, but it exposes an internal variable that might change in the future, so am I hesitant to take this.

Quoted 6 lines

Without it, the only way to change the kernel command line is by editing the script, which doesn't seem very friendly.

Would you feel better if it were a special variable, just for this purpose, which is by default empty? I was just using the infrastructure that was already in place.

Hi Gary,

I believe this is being tracked with bug #1019:

http://bugzilla.pokylinux.org/show_bug.cgi?id=1019

I do not have an ETA on this except for "before 1.1". Your workaround could be used in the meantime.

I haven't given any thought to creating an environment variable "API" to the script, so I'm not comfortable taking the patch currently.

As a temporary workaround, you could use the patch locally.

Scott

Signature · 3 lines
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center