Skip to contentSkip to conversation

rtlwifi: Use write barrier when assigning ownership

PATCH In review Mike McCormack 2 participants 2 messages May 23, 2011 Networking drivers (wireless)

lore
Share & tools
lore

Mike McCormack

author
#0 lore raw

PATCH 7/8 rtlwifi: Use write barrier when assigning ownership

Make sure all updates to a descriptor are flushed to memory before assigning ownship to hardware.

Signed-off-by Mike McCormack <[email protected]>
---
 drivers/net/wireless/rtlwifi/rtl8192ce/trx.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c +2 -0
index 54b2bd5..06d9ddb 100644
@@ -932,6 +932,7 @@ void rtl92ce_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val)
 	if (istx == true) {
 		switch (desc_name) {
 		case HW_DESC_OWN:
+			wmb();
 			SET_TX_DESC_OWN(pdesc, 1);
 			break;
 		case HW_DESC_TX_NEXTDESC_ADDR:

@@ -945,6 +946,7 @@ void rtl92ce_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val)
 	} else {
 		switch (desc_name) {
 		case HW_DESC_RXOWN:
+			wmb();
 			SET_RX_DESC_OWN(pdesc, 1);
 			break;
 		case HW_DESC_RXBUFF_ADDR:
Signature · 1 line
1.7.4.1
#1 lore raw
Quoted 21 lines · Mike McCormack

Make sure all updates to a descriptor are flushed to memory before assigning ownship to hardware.

Signed-off-by Mike McCormack<[email protected]>
---
  drivers/net/wireless/rtlwifi/rtl8192ce/trx.c |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c +1 -0
index 54b2bd5..06d9ddb 100644
@@ -932,6 +932,7 @@ void rtl92ce_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val)
  	if (istx == true) {
  		switch (desc_name) {
  		case HW_DESC_OWN:
+			wmb();
  			SET_TX_DESC_OWN(pdesc, 1);
  			break;
  		case HW_DESC_TX_NEXTDESC_ADDR:

drivers/net/wireless/rtlwifi/rtl8192ce/trx.c void rtl92ce_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val) · line 952

Quoted 7 lines
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c +1 -0
@@ -945,6 +946,7 @@ void rtl92ce_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val)
  	} else {
  		switch (desc_name) {
  		case HW_DESC_RXOWN:
+			wmb();
  			SET_RX_DESC_OWN(pdesc, 1);
  			break;
  		case HW_DESC_RXBUFF_ADDR:

A similar change needs to be applied to rtl8192se. I'll take care of it.

Signed-off-by Larry Finger <[email protected]>

---

Larry