usbip: simplify lock handling in valid_request()

PATCH New Németh Márton 1 participant 1 message May 24, 2011 Staging

lore

Share & tools

lore

Németh Márton

author

2011-05-24 21:19 UTC #0 lore raw

PATCH 1/1 usbip: simplify lock handling in valid_request()

From: Márton Németh <[email protected]>

The function calls spin_lock() and spin_unlock() should be in pair. This patch makes this pairing more clear for the reader of the code.

Signed-off-by Márton Németh <[email protected]>

---

drivers/staging/usbip/stub_rx.c +3 -3

index a5c1fa1..e2cfedb 100644
@@ -304,18 +304,18 @@ static int stub_recv_cmd_unlink(struct stub_device *sdev,
 static int valid_request(struct stub_device *sdev, struct usbip_header *pdu)
 {
 	struct usbip_device *ud = &sdev->ud;
+	int valid = 0;
 
 	if (pdu->base.devid == sdev->devid) {
 		spin_lock(&ud->lock);
 		if (ud->status == SDEV_ST_USED) {
 			/* A request is valid. */
-			spin_unlock(&ud->lock);
-			return 1;
+			valid = 1;
 		}
 		spin_unlock(&ud->lock);
 	}
 
-	return 0;
+	return valid;
 }
 
 static struct stub_priv *stub_priv_alloc(struct stub_device *sdev,