AT91: Add VSYNC pin definition for AT91SAM9263 silicon
PATCH 1/1 AT91: Add VSYNC pin definition for AT91SAM9263 silicon
On Atmel's AT91SAM9263-EK board, the LCD panel does not need VSYNC signal. But this signal is useful for the boards from other vendors, as suggested by Nicholas Kinar.
This small patch adds the VSYNC pin definition by default.
--- arch/arm/mach-at91/at91sam9263_devices.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-at91/at91sam9263_devices.c +1 -0
@@ -832,6 +832,7 @@ void __init at91_add_device_lcdc(struct atmel_lcdfb_info *data)if (!data)return ; +at91_set_A_periph (AT91_PIN_PC0 ,0 );/* LCDVSYNC */ at91_set_A_periph (AT91_PIN_PC1 ,0 );/* LCDHSYNC */ at91_set_A_periph (AT91_PIN_PC2 ,0 );/* LCDDOTCK */ at91_set_A_periph (AT91_PIN_PC3 ,0 );/* LCDDEN */
Signature · 1 line
1.7.3.3
PATCH 1/1 AT91: Add VSYNC pin definition for AT91SAM9263 silicon
Quoted 17 lines · Hong Xu
On Atmel's AT91SAM9263-EK board, the LCD panel does not need VSYNC signal. But this signal is useful for the boards from other vendors, as suggested by Nicholas Kinar.
This small patch adds the VSYNC pin definition by default.
Reported-by Nicholas Kinar <[email protected]>Signed-off-by Hong Xu <[email protected]>--- arch/arm/mach-at91/at91sam9263_devices.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)arch/arm/mach-at91/at91sam9263_devices.c +0
-0
arch/arm/mach-at91/at91sam9263_devices.c void __init at91_add_device_lcdc(struct atmel_lcdfb_info *data) · line 835
Quoted 4 lines
arch/arm/mach-at91/at91sam9263_devices.c +1
-0@@ -832,6 +832,7 @@ void __init at91_add_device_lcdc(struct atmel_lcdfb_info *data)if (!data)return ; +at91_set_A_periph (AT91_PIN_PC0 ,0 );/* LCDVSYNC */
this must be optionnal
we need to update this with somethink like done on avr32
Best Regards,
J.
PATCH 1/1 AT91: Add VSYNC pin definition for AT91SAM9263 silicon
Hi,
Quoted 21 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 20 lines · Hong Xu
On Atmel's AT91SAM9263-EK board, the LCD panel does not need VSYNC signal. But this signal is useful for the boards from other vendors, as suggested by Nicholas Kinar.
This small patch adds the VSYNC pin definition by default.
Reported-by Nicholas Kinar<[email protected]>Signed-off-by Hong Xu<[email protected]>--- arch/arm/mach-at91/at91sam9263_devices.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)arch/arm/mach-at91/at91sam9263_devices.c +0
-0@@ -832,6 +832,7 @@ void __init at91_add_device_lcdc(struct atmel_lcdfb_info *data)if (!data)return ;
Quoted 5 lines
arch/arm/mach-at91/at91sam9263_devices.c void __init at91_add_device_lcdc(struct atmel_lcdfb_info *data) · line 835
Quoted 1 line
arch/arm/mach-at91/at91sam9263_devices.c +1
-0+at91_set_A_periph (AT91_PIN_PC0 ,0 );/* LCDVSYNC */ this must be optionnal
we need to update this with somethink like done on avr32
hm.. PC0 in SAM9263 has only "A" function (LCD VSYNC). As long as this pin is not used as GPIO, it's harmless to enable its peripheral function.
I just had a quick look at the AVR32 code without catching your "something like on AVR32". In AVR32, all ATMEL_LCDC_*_*BIT has "VSYNC" defined.
BR,
Eric
PATCH 1/1 AT91: Add VSYNC pin definition for AT91SAM9263 silicon
Quoted 30 lines · Hong Xu
Hi,
Quoted 21 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 20 lines · Hong Xu
On Atmel's AT91SAM9263-EK board, the LCD panel does not need VSYNC signal. But this signal is useful for the boards from other vendors, as suggested by Nicholas Kinar.
This small patch adds the VSYNC pin definition by default.
Reported-by Nicholas Kinar<[email protected]>Signed-off-by Hong Xu<[email protected]>--- arch/arm/mach-at91/at91sam9263_devices.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)arch/arm/mach-at91/at91sam9263_devices.c +0
-0@@ -832,6 +832,7 @@ void __init at91_add_device_lcdc(struct atmel_lcdfb_info *data)if (!data)return ;Quoted 5 lines
arch/arm/mach-at91/at91sam9263_devices.c void __init at91_add_device_lcdc(struct atmel_lcdfb_info *data) · line 835
Quoted 1 line
arch/arm/mach-at91/at91sam9263_devices.c +1
-0+at91_set_A_periph (AT91_PIN_PC0 ,0 );/* LCDVSYNC */ this must be optionnal
we need to update this with somethink like done on avr32
Quoted 7 lines
hm.. PC0 in SAM9263 has only "A" function (LCD VSYNC). As long as this pin is not used as GPIO, it's harmless to enable its peripheral function.
I just had a quick look at the AVR32 code without catching your "something like on AVR32". In AVR32, all ATMEL_LCDC_*_*BIT has "VSYNC" defined.
my key point is not here, my key point is to make it optional just take a look how did the avr32
Best Regards,
J.