Skip to contentSkip to conversation

fec driver multicast (and IPv6) problem

PATCH New Zach Sadecki 1 participant 1 message May 26, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fec driver multicast (and IPv6) problem

I noticed that sometimes I could not connect to my i.MX28 board over IPv6. After some diagnosis I learned that it was not responding any NDP requests. A simple "ip link set eth0 promisc off" would cause it to respond properly to those requests. While that command didn't really do anything (it wasn't in promisc mode to begin with), it did trigger a call to set_multicast_list in the fec driver. It turns out that the fec_restart function was zeroing out the multicast group hash registers which breaks IPv6 NDP (amongst other things dependent on multicast functionality). Changing the zeroing functionality into a call to set_multicast_list fixed this problem for me. Note that simply removing the calls that zero out the registers didn't work, as I believe the reset call a few lines above had already cleared them. A patch is inline below.

Zach

drivers/net/fec.c 2011-05-25 15:17:12.294339147 -0500 renamed from drivers/net/fec.c 2011-05-18 23:06:34.000000000 -0500 +1 -2
diff -ru linux-2.6.39/drivers/net/fec.c linux-2.6.39-fecpatch/drivers/net/fec.c
@@ -361,8 +361,7 @@
     writel(0xffc00000, fep->hwp + FEC_IEVENT);
 
     /* Reset all multicast.    */
-    writel(0, fep->hwp + FEC_GRP_HASH_TABLE_HIGH);
-    writel(0, fep->hwp + FEC_GRP_HASH_TABLE_LOW);
+    set_multicast_list(dev);
 #ifndef CONFIG_M5272
     writel(0, fep->hwp + FEC_HASH_TABLE_HIGH);
     writel(0, fep->hwp + FEC_HASH_TABLE_LOW);