base patches needed for romley

PATCH In review [email protected] 3 participants 13 messages May 27, 2011 – May 28, 2011

Subsystems (4)

Network drivers x86 PCI libata

lore

Share & tools

lore

[email protected]

author

2011-05-27 20:47 UTC #0 lore raw

cover base patches needed for romley

From: Tom Zanussi <[email protected]>

These upstreamed post-2.6.37 patches are needed by the romley BSP for 2.6.37.

Note that I've removed the e-mail addresses from these posted patches, but the git branch retains them.

Please pull into linux-yocto-2.6.37.

Thanks,

Tom

Pull URL: git://git.yoctoproject.org/linux-yocto-2.6.37-contrib
Branch: tzanussi/romley-new-options-and-refactor-base
Browse: http://git.yoctoproject.org/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=tzanussi/romley-new-options-and-refactor-base

Greg Rose (1):
Remove extra struct page member from the buffer info structure

Seth Heasley (2):
x86/PCI: irq and pci_ids patch for Intel Patsburg
ahci: AHCI mode SATA patch for Intel Patsburg SATA RAID controller

 arch/x86/pci/irq.c        |    3 ++-
 drivers/ata/ahci.c        |    1 +
 drivers/net/igbvf/igbvf.h |    1 -
 include/linux/pci_ids.h   |    3 ++-
 4 files changed, 5 insertions(+), 3 deletions(-)

[email protected]

author

2011-05-27 20:47 UTC #1 lore raw

PATCH 1/3 Remove extra struct page member from the buffer info structure

From: Greg Rose

declaration.

commit b1d670f10e8078485884f0cf7e384d890909aeaa upstream

Reported-by: Andi Kleen
Signed-off-by: Greg Rose
Tested-by: Emil Tantilov
Signed-off-by: Jeff Kirsher
Integrated-by: Tom Zanussi

---
 drivers/net/igbvf/igbvf.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

drivers/net/igbvf/igbvf.h +0 -1

index debeee2..f7ae284 100644
@@ -126,7 +126,6 @@ struct igbvf_buffer {
 			unsigned int page_offset;
 		};
 	};
-	struct page *page;
 };
 
 union igbvf_desc {

Signature · 1 line

1.7.0.4

[email protected]

author

2011-05-27 20:47 UTC #2 lore raw

PATCH 2/3 x86/PCI: irq and pci_ids patch for Intel Patsburg

From: Seth Heasley

commit 9b444b36fee16d2aaae9cc91ce594ecb15d922a9 upstream

This patch adds an additional LPC Controller DeviceID for the Intel Patsburg PCH.

Signed-off-by: Seth Heasley
Signed-off-by: Jesse Barnes
Integrated-by: Tom Zanussi

---
 arch/x86/pci/irq.c      |    3 ++-
 include/linux/pci_ids.h |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

arch/x86/pci/irq.c +2 -1

index 9f9bfb7..87e6c83 100644
@@ -589,7 +589,8 @@ static __init int intel_router_probe(struct irq_router *r, struct pci_dev *route
 	case PCI_DEVICE_ID_INTEL_ICH10_1:
 	case PCI_DEVICE_ID_INTEL_ICH10_2:
 	case PCI_DEVICE_ID_INTEL_ICH10_3:
-	case PCI_DEVICE_ID_INTEL_PATSBURG_LPC:
+	case PCI_DEVICE_ID_INTEL_PATSBURG_LPC_0:
+	case PCI_DEVICE_ID_INTEL_PATSBURG_LPC_1:
 		r->name = "PIIX/ICH";
 		r->get = pirq_piix_get;
 		r->set = pirq_piix_set;

include/linux/pci_ids.h +2 -1

index cb845c1..d830106 100644
@@ -2468,7 +2468,8 @@
 #define PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MIN	0x1c41
 #define PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MAX	0x1c5f
 #define PCI_DEVICE_ID_INTEL_PATSBURG_SMBUS	0x1d22
-#define PCI_DEVICE_ID_INTEL_PATSBURG_LPC	0x1d40
+#define PCI_DEVICE_ID_INTEL_PATSBURG_LPC_0	0x1d40
+#define PCI_DEVICE_ID_INTEL_PATSBURG_LPC_1	0x1d41
 #define PCI_DEVICE_ID_INTEL_82801AA_0	0x2410
 #define PCI_DEVICE_ID_INTEL_82801AA_1	0x2411
 #define PCI_DEVICE_ID_INTEL_82801AA_3	0x2413

Signature · 1 line

1.7.0.4

[email protected]

author

2011-05-27 20:47 UTC #3 lore raw

PATCH 3/3 ahci: AHCI mode SATA patch for Intel Patsburg SATA RAID controller

In reply to [email protected]

From: Seth Heasley

commit 64a3903d0885879ba8706a8bcf71c5e3e7664db2 upstream

This patch adds an updated SATA RAID DeviceID for the Intel Patsburg PCH.

Signed-off-by: Seth Heasley
Signed-off-by: Jeff Garzik
Integrated-by: Tom Zanussi

---
 drivers/ata/ahci.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

drivers/ata/ahci.c +1 -0

index 3288263..dfc0a26 100644
@@ -260,6 +260,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
 	{ PCI_VDEVICE(INTEL, 0x1d02), board_ahci }, /* PBG AHCI */
 	{ PCI_VDEVICE(INTEL, 0x1d04), board_ahci }, /* PBG RAID */
 	{ PCI_VDEVICE(INTEL, 0x1d06), board_ahci }, /* PBG RAID */
+	{ PCI_VDEVICE(INTEL, 0x2826), board_ahci }, /* PBG RAID */
 
 	/* JMicron 360/1/3/5/6, match class to avoid IDE function */
 	{ PCI_VENDOR_ID_JMICRON, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,

Signature · 1 line

1.7.0.4

Bruce Ashfield

2011-05-27 21:08 UTC #4 lore raw

Re: [PATCH 3/3] ahci: AHCI mode SATA patch for Intel Patsburg SATA RAID controller

Quoted 5 lines · On 11-05-27 04:46 PM, [email protected] wrote:

From: Seth Heasley
commit 64a3903d0885879ba8706a8bcf71c5e3e7664db2 upstream
This patch adds an updated SATA RAID DeviceID for the Intel Patsburg PCH.

Looks like we already had this one in the 2.6.37 tree via gregkh and -stable

Quoted 1 line

git tag --contains 5618c45b

v2.6.37.5
v2.6.37.6

And hence the base yocto/standard/common-pc-64/romley bsp branch.

So I won't do anything with this in particular. It is interesting though how it applied in your tree. Do you have all the -stable updates ?

I checked and it doesn't look like I've been hoarding them, but you never know.

Bruce

Quoted 20 lines

Signed-off-by: Seth Heasley
Signed-off-by: Jeff Garzik
Integrated-by: Tom Zanussi

---
  drivers/ata/ahci.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

drivers/ata/ahci.c +1 -0

index 3288263..dfc0a26 100644
@@ -260,6 +260,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
  	{ PCI_VDEVICE(INTEL, 0x1d02), board_ahci }, /* PBG AHCI */
  	{ PCI_VDEVICE(INTEL, 0x1d04), board_ahci }, /* PBG RAID */
  	{ PCI_VDEVICE(INTEL, 0x1d06), board_ahci }, /* PBG RAID */
+	{ PCI_VDEVICE(INTEL, 0x2826), board_ahci }, /* PBG RAID */
 
  	/* JMicron 360/1/3/5/6, match class to avoid IDE function */
  	{ PCI_VENDOR_ID_JMICRON, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,

Tom Zanussi

author

2011-05-27 21:20 UTC #5 lore raw

Re: [PATCH 3/3] ahci: AHCI mode SATA patch for Intel Patsburg SATA RAID controller

Quoted 17 lines · Bruce Ashfield

Quoted 5 lines · On 11-05-27 04:46 PM, [email protected] wrote:
From: Seth Heasley
commit 64a3903d0885879ba8706a8bcf71c5e3e7664db2 upstream
This patch adds an updated SATA RAID DeviceID for the Intel Patsburg PCH.
Looks like we already had this one in the 2.6.37 tree via gregkh and -stable
Quoted 1 line
git tag --contains 5618c45b
v2.6.37.5
v2.6.37.6
And hence the base yocto/standard/common-pc-64/romley bsp branch.

Quoted 7 lines

So I won't do anything with this in particular. It is interesting though how it applied in your tree. Do you have all the -stable updates ?
I checked and it doesn't look like I've been hoarding them, but you never know.

Hmm, yeah, it did apply (checked the build dir for the other changes), but not sure why I didn't get rejects. My kernel is a little over a week old, but it does have the .5 stable:

$ git tag --contains 5618c45b
v2.6.37.5

Tom

Quoted 23 lines

Bruce

Quoted 20 lines

Signed-off-by: Seth Heasley
Signed-off-by: Jeff Garzik
Integrated-by: Tom Zanussi

---
  drivers/ata/ahci.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

drivers/ata/ahci.c +1 -0

index 3288263..dfc0a26 100644
@@ -260,6 +260,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
  	{ PCI_VDEVICE(INTEL, 0x1d02), board_ahci }, /* PBG AHCI */
  	{ PCI_VDEVICE(INTEL, 0x1d04), board_ahci }, /* PBG RAID */
  	{ PCI_VDEVICE(INTEL, 0x1d06), board_ahci }, /* PBG RAID */
+	{ PCI_VDEVICE(INTEL, 0x2826), board_ahci }, /* PBG RAID */
 
  	/* JMicron 360/1/3/5/6, match class to avoid IDE function */
  	{ PCI_VENDOR_ID_JMICRON, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,

Bruce Ashfield

2011-05-28 00:16 UTC #6 lore raw

Re: [PATCH 3/3] ahci: AHCI mode SATA patch for Intel Patsburg SATA RAID controller

Quoted 22 lines · Tom Zanussi

Quoted 21 lines · Bruce Ashfield
Quoted 5 lines · On 11-05-27 04:46 PM, [email protected] wrote:
From: Seth Heasley
commit 64a3903d0885879ba8706a8bcf71c5e3e7664db2 upstream
This patch adds an updated SATA RAID DeviceID for the Intel Patsburg PCH.
Looks like we already had this one in the 2.6.37 tree via gregkh and -stable
Quoted 1 line
git tag --contains 5618c45b
v2.6.37.5
v2.6.37.6
And hence the base yocto/standard/common-pc-64/romley bsp branch.
So I won't do anything with this in particular. It is interesting though how it applied in your tree. Do you have all the -stable updates ?

Quoted 7 lines

Quoted 3 lines
I checked and it doesn't look like I've been hoarding them, but you never know.
Hmm, yeah, it did apply (checked the build dir for the other changes), but not sure why I didn't get rejects. My kernel is a little over a week old, but it does have the .5 stable:

It actually has .6 and certain people (*cough*) didn't push the tags. I'll fix that tonight.

git has a way of managing to apply changes and do the right thing. I've double checked, and I do see the change in the branches waiting for us, so we'll go with that until proven otherwise.

Cheers,

Bruce

Quoted 31 lines

$ git tag --contains 5618c45b
v2.6.37.5

Tom

Quoted 23 lines

Bruce

Quoted 20 lines

Signed-off-by: Seth Heasley
Signed-off-by: Jeff Garzik
Integrated-by: Tom Zanussi

---
   drivers/ata/ahci.c |    1 +
   1 files changed, 1 insertions(+), 0 deletions(-)

drivers/ata/ahci.c +1 -0

index 3288263..dfc0a26 100644
@@ -260,6 +260,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
   	{ PCI_VDEVICE(INTEL, 0x1d02), board_ahci }, /* PBG AHCI */
   	{ PCI_VDEVICE(INTEL, 0x1d04), board_ahci }, /* PBG RAID */
   	{ PCI_VDEVICE(INTEL, 0x1d06), board_ahci }, /* PBG RAID */
+	{ PCI_VDEVICE(INTEL, 0x2826), board_ahci }, /* PBG RAID */
 
   	/* JMicron 360/1/3/5/6, match class to avoid IDE function */
   	{ PCI_VENDOR_ID_JMICRON, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,

Tom Zanussi

author

2011-05-28 00:27 UTC #7 lore raw

Re: [PATCH 3/3] ahci: AHCI mode SATA patch for Intel Patsburg SATA RAID controller

Quoted 31 lines · Bruce Ashfield

Quoted 22 lines · Tom Zanussi
Quoted 21 lines · Bruce Ashfield
Quoted 5 lines · On 11-05-27 04:46 PM, [email protected] wrote:
From: Seth Heasley
commit 64a3903d0885879ba8706a8bcf71c5e3e7664db2 upstream
This patch adds an updated SATA RAID DeviceID for the Intel Patsburg PCH.
Looks like we already had this one in the 2.6.37 tree via gregkh and -stable
Quoted 1 line
git tag --contains 5618c45b
v2.6.37.5
v2.6.37.6
And hence the base yocto/standard/common-pc-64/romley bsp branch.
So I won't do anything with this in particular. It is interesting though how it applied in your tree. Do you have all the -stable updates ?
Quoted 7 lines
Quoted 3 lines
I checked and it doesn't look like I've been hoarding them, but you never know.
Hmm, yeah, it did apply (checked the build dir for the other changes), but not sure why I didn't get rejects. My kernel is a little over a week old, but it does have the .5 stable:

Quoted 8 lines

It actually has .6 and certain people (*cough*) didn't push the tags. I'll fix that tonight.
git has a way of managing to apply changes and do the right thing. I've double checked, and I do see the change in the branches waiting for us, so we'll go with that until proven otherwise.

Yeah, either way it's the same single line change, so whatever's easiest.

Tom

Quoted 36 lines

Cheers,

Bruce

Quoted 31 lines

$ git tag --contains 5618c45b
v2.6.37.5

Tom

Quoted 23 lines

Bruce

Quoted 20 lines

Signed-off-by: Seth Heasley
Signed-off-by: Jeff Garzik
Integrated-by: Tom Zanussi

---
   drivers/ata/ahci.c |    1 +
   1 files changed, 1 insertions(+), 0 deletions(-)

drivers/ata/ahci.c +1 -0

index 3288263..dfc0a26 100644
@@ -260,6 +260,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
   	{ PCI_VDEVICE(INTEL, 0x1d02), board_ahci }, /* PBG AHCI */
   	{ PCI_VDEVICE(INTEL, 0x1d04), board_ahci }, /* PBG RAID */
   	{ PCI_VDEVICE(INTEL, 0x1d06), board_ahci }, /* PBG RAID */
+	{ PCI_VDEVICE(INTEL, 0x2826), board_ahci }, /* PBG RAID */
 
   	/* JMicron 360/1/3/5/6, match class to avoid IDE function */
   	{ PCI_VENDOR_ID_JMICRON, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,

Bruce Ashfield

2011-05-27 20:58 UTC #8 lore raw

In reply to [email protected]

Quoted 9 lines · On 11-05-27 04:45 PM, [email protected] wrote:

From: Tom Zanussi<[email protected]>
These upstreamed post-2.6.37 patches are needed by the romley BSP for 2.6.37.
Note that I've removed the e-mail addresses from these posted patches, but the git branch retains them.
Please pull into linux-yocto-2.6.37.

Good timing, I was just in re-working 2.6.37 and
2.6.39, so I'll stack these on top.

changes look good to me, I've fetched this.

It'll go out over the weekend to the kernel repo, and SRCREV updates to follow.

Bruce

Quoted 22 lines

Thanks,
Tom
Pull URL: git://git.yoctoproject.org/linux-yocto-2.6.37-contrib
Branch: tzanussi/romley-new-options-and-refactor-base
Browse: http://git.yoctoproject.org/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=tzanussi/romley-new-options-and-refactor-base
Greg Rose (1):
Remove extra struct page member from the buffer info structure
Seth Heasley (2):
x86/PCI: irq and pci_ids patch for Intel Patsburg
ahci: AHCI mode SATA patch for Intel Patsburg SATA RAID controller
  arch/x86/pci/irq.c        |    3 ++-
  drivers/ata/ahci.c        |    1 +
  drivers/net/igbvf/igbvf.h |    1 -
  include/linux/pci_ids.h   |    3 ++-
  4 files changed, 5 insertions(+), 3 deletions(-)

Tom Zanussi

author

2011-05-27 21:05 UTC #9 lore raw

Quoted 11 lines · Bruce Ashfield

Quoted 9 lines · On 11-05-27 04:45 PM, [email protected] wrote:
From: Tom Zanussi<[email protected]>
These upstreamed post-2.6.37 patches are needed by the romley BSP for 2.6.37.
Note that I've removed the e-mail addresses from these posted patches, but the git branch retains them.
Please pull into linux-yocto-2.6.37.

Quoted 8 lines

Good timing, I was just in re-working 2.6.37 and
2.6.39, so I'll stack these on top.
changes look good to me, I've fetched this.
It'll go out over the weekend to the kernel repo, and SRCREV updates to follow.

Thanks, Bruce!

Tom

Quoted 25 lines

Bruce
Quoted 22 lines
Thanks,
Tom
Pull URL: git://git.yoctoproject.org/linux-yocto-2.6.37-contrib
Branch: tzanussi/romley-new-options-and-refactor-base
Browse: http://git.yoctoproject.org/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=tzanussi/romley-new-options-and-refactor-base
Greg Rose (1):
Remove extra struct page member from the buffer info structure
Seth Heasley (2):
x86/PCI: irq and pci_ids patch for Intel Patsburg
ahci: AHCI mode SATA patch for Intel Patsburg SATA RAID controller
  arch/x86/pci/irq.c        |    3 ++-
  drivers/ata/ahci.c        |    1 +
  drivers/net/igbvf/igbvf.h |    1 -
  include/linux/pci_ids.h   |    3 ++-
  4 files changed, 5 insertions(+), 3 deletions(-)

Darren Hart

2011-05-28 03:07 UTC #10 lore raw

In reply to [email protected]

Quoted 7 lines · On 05/27/2011 01:45 PM, [email protected] wrote:

From: Tom Zanussi <[email protected]>
These upstreamed post-2.6.37 patches are needed by the romley BSP for 2.6.37.
Note that I've removed the e-mail addresses from these posted patches, but the git branch retains them.

I understand the reason, but this should no longer be necessary. The new send-pull-request script only matches on "^Signed-off-by" and "^[Cc][Cc]:", and you can do a dry run by answering "no" when prompted and you can see where it would try and send the patches. If you notice that a commit adding patches to recipe pulls in emails included in the patches, PLEASE let me know. This should no longer be the case.

--
Darren

Quoted 28 lines

Please pull into linux-yocto-2.6.37.
Thanks,
Tom
Pull URL: git://git.yoctoproject.org/linux-yocto-2.6.37-contrib
Branch: tzanussi/romley-new-options-and-refactor-base
Browse: http://git.yoctoproject.org/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=tzanussi/romley-new-options-and-refactor-base
Greg Rose (1):
Remove extra struct page member from the buffer info structure
Seth Heasley (2):
x86/PCI: irq and pci_ids patch for Intel Patsburg
ahci: AHCI mode SATA patch for Intel Patsburg SATA RAID controller
 arch/x86/pci/irq.c        |    3 ++-
 drivers/ata/ahci.c        |    1 +
 drivers/net/igbvf/igbvf.h |    1 -
 include/linux/pci_ids.h   |    3 ++-
 4 files changed, 5 insertions(+), 3 deletions(-)
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

Signature · 3 lines

Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Tom Zanussi

author

2011-05-28 03:21 UTC #11 lore raw

Quoted 9 lines · Darren

Quoted 7 lines · On 05/27/2011 01:45 PM, [email protected] wrote:
From: Tom Zanussi <[email protected]>
These upstreamed post-2.6.37 patches are needed by the romley BSP for 2.6.37.
Note that I've removed the e-mail addresses from these posted patches, but the git branch retains them.

Quoted 7 lines

I understand the reason, but this should no longer be necessary. The new send-pull-request script only matches on "^Signed-off-by" and "^[Cc][Cc]:", and you can do a dry run by answering "no" when prompted and you can see where it would try and send the patches. If you notice that a commit adding patches to recipe pulls in emails included in the patches, PLEASE let me know. This should no longer be the case.

I didn't try that, just decided I didn't want to risk it, but did try it now and get:

Send this email? ([y]es|[n]o|[q]uit|[a]ll): n
(mbox) Adding cc: Seth Heasley from line 'From: Seth Heasley'
(body) Adding cc: Seth Heasley from line 'Signed-off-by: Seth Heasley' (body) Adding cc: Jeff Garzik from line 'Signed-off-by: Jeff Garzik'
Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842.
W: unable to extract a valid address from: Seth Heasley
W: unable to extract a valid address from: Seth Heasley
W: unable to extract a valid address from: Jeff Garzik
W: unable to extract a valid address from: Seth Heasley
W: unable to extract a valid address from: Seth Heasley
W: unable to extract a valid address from: Jeff Garzik

It looks like it is trying to cc the e-mails in the patch, or am I reading that wrong?

The poky/master commit I'm using is:

1169f1b066d0028bd2ef7915440450bd42ef165e

Tom

Quoted 33 lines

--
Darren
Quoted 28 lines
Please pull into linux-yocto-2.6.37.
Thanks,
Tom
Pull URL: git://git.yoctoproject.org/linux-yocto-2.6.37-contrib
Branch: tzanussi/romley-new-options-and-refactor-base
Browse: http://git.yoctoproject.org/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=tzanussi/romley-new-options-and-refactor-base
Greg Rose (1):
Remove extra struct page member from the buffer info structure
Seth Heasley (2):
x86/PCI: irq and pci_ids patch for Intel Patsburg
ahci: AHCI mode SATA patch for Intel Patsburg SATA RAID controller
 arch/x86/pci/irq.c        |    3 ++-
 drivers/ata/ahci.c        |    1 +
 drivers/net/igbvf/igbvf.h |    1 -
 include/linux/pci_ids.h   |    3 ++-
 4 files changed, 5 insertions(+), 3 deletions(-)
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

Darren Hart

2011-05-28 05:14 UTC #12 lore raw

Quoted 18 lines · Tom

Quoted 9 lines · Darren
Quoted 7 lines · On 05/27/2011 01:45 PM, [email protected] wrote:
From: Tom Zanussi <[email protected]>
These upstreamed post-2.6.37 patches are needed by the romley BSP for 2.6.37.
Note that I've removed the e-mail addresses from these posted patches, but the git branch retains them.
Quoted 7 lines
I understand the reason, but this should no longer be necessary. The new send-pull-request script only matches on "^Signed-off-by" and "^[Cc][Cc]:", and you can do a dry run by answering "no" when prompted and you can see where it would try and send the patches. If you notice that a commit adding patches to recipe pulls in emails included in the patches, PLEASE let me know. This should no longer be the case.

Quoted 7 lines

I didn't try that, just decided I didn't want to risk it, but did try it now and get:
Send this email? ([y]es|[n]o|[q]uit|[a]ll): n
(mbox) Adding cc: Seth Heasley from line 'From: Seth Heasley' (body) Adding cc: Seth Heasley from line 'Signed-off-by: Seth Heasley' (body) Adding cc: Jeff Garzik from line 'Signed-off-by: Jeff Garzik'

Ah... that's really unfortunate. I fixed our script from harvesting those, but git send-email still picks them out :-(

Thanks for testing and confirming the behavior.

--
Darren

Quoted 63 lines

Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842. Use of uninitialized value $cc in string eq at /usr/lib/git-core/git-send-email line 842.
W: unable to extract a valid address from: Seth Heasley
W: unable to extract a valid address from: Seth Heasley
W: unable to extract a valid address from: Jeff Garzik
W: unable to extract a valid address from: Seth Heasley
W: unable to extract a valid address from: Seth Heasley
W: unable to extract a valid address from: Jeff Garzik
It looks like it is trying to cc the e-mails in the patch, or am I reading that wrong?
The poky/master commit I'm using is:
1169f1b066d0028bd2ef7915440450bd42ef165e
Tom
Quoted 33 lines
--
Darren
Quoted 28 lines
Please pull into linux-yocto-2.6.37.
Thanks,
Tom
Pull URL: git://git.yoctoproject.org/linux-yocto-2.6.37-contrib
Branch: tzanussi/romley-new-options-and-refactor-base
Browse: http://git.yoctoproject.org/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=tzanussi/romley-new-options-and-refactor-base
Greg Rose (1):
Remove extra struct page member from the buffer info structure
Seth Heasley (2):
x86/PCI: irq and pci_ids patch for Intel Patsburg
ahci: AHCI mode SATA patch for Intel Patsburg SATA RAID controller
 arch/x86/pci/irq.c        |    3 ++-
 drivers/ata/ahci.c        |    1 +
 drivers/net/igbvf/igbvf.h |    1 -
 include/linux/pci_ids.h   |    3 ++-
 4 files changed, 5 insertions(+), 3 deletions(-)
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

Signature · 3 lines

Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel