Skip to contentSkip to conversation

V 3.0-rc1: [REPORT] OMAP MMC and CONSOLE Regression

PATCH Santosh Shilimkar 2 participants 3 messages May 30, 2011 – May 31, 2011

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Santosh Shilimkar

author
#0 lore raw

While trying out V3.0-rc1, I noticed couple of regressions. Am posting this in case anybody come across same issues.

1.OMAP MMC code keep throwing "Pbias Voltage is not same as LDO" error continuously.

Balaji is planning post right fix for the same, but just in case you get around this issue,

arch/arm/mach-omap2/hsmmc.c +9 -1
index b2f30be..94ae400 100644
@@ -145,6 +145,7 @@ static void omap4_hsmmc1_after_set_reg(struct device *dev, int slot,
 				 int power_on, int vdd)
 {
 	u32 reg;
+	unsigned long timeout;
 
 	if (power_on) {
 		reg = omap4_ctrl_pad_readl(control_pbias_offset);

@@ -158,7 +159,14 @@ static void omap4_hsmmc1_after_set_reg(struct device *dev, int slot,
 			OMAP4_USBC1_ICUSB_PWRDNZ_MASK);
 		omap4_ctrl_pad_writel(reg, control_pbias_offset);
 		/* 4 microsec delay for comparator to generate an error*/
-		udelay(4);
+		timeout = jiffies + msecs_to_jiffies(500);
+		do {
+			reg = omap4_ctrl_pad_readl(control_pbias_offset);
+			if (!(reg & OMAP4_MMC1_PBIASLITE_VMODE_ERROR_MASK))
+				break;
+			mdelay(1);
+		} while (!time_after(jiffies, timeout));
+
 		reg = omap4_ctrl_pad_readl(control_pbias_offset);
 		if (reg & OMAP4_MMC1_PBIASLITE_VMODE_ERROR_MASK) {
 			pr_err("Pbias Voltage is not same as LDO\n");

2. can't open /dev/ttyO2: No such file or directory

This is not obvious console entry missing problem in FS. Need to look at this further.

#1 lore raw
Quoted 9 lines · Santosh Shilimkar

While trying out V3.0-rc1, I noticed couple of regressions. Am posting this in case anybody come across same issues.

1.OMAP MMC code keep throwing "Pbias Voltage is not same as LDO" error continuously.

Balaji is planning post right fix for the same, but just in case you get around this issue,

Hi Santosh,
You can find MMC pbias fix here
http://www.spinics.net/lists/linux-omap/msg51735.html

Quoted 29 lines
arch/arm/mach-omap2/hsmmc.c +1 -0
index b2f30be..94ae400 100644
@@ -145,6 +145,7 @@ static void omap4_hsmmc1_after_set_reg(struct device
 *dev, int slot,
                                 int power_on, int vdd)
  {
        u32 reg;
+       unsigned long timeout;
 
        if (power_on) {

               reg = omap4_ctrl_pad_readl(control_pbias_offset);

arch/arm/mach-omap2/hsmmc.c +8 -1
@@ -158,7 +159,14 @@ static void omap4_hsmmc1_after_set_reg(struct device
 *dev, int slot,
                        OMAP4_USBC1_ICUSB_PWRDNZ_MASK);
                omap4_ctrl_pad_writel(reg, control_pbias_offset);
                /* 4 microsec delay for comparator to generate an error*/
-               udelay(4);
+               timeout = jiffies + msecs_to_jiffies(500);
+               do {
+                       reg = omap4_ctrl_pad_readl(control_pbias_offset);
+                       if (!(reg & OMAP4_MMC1_PBIASLITE_VMODE_ERROR_MASK))
+                               break;
+                       mdelay(1);
+               } while (!time_after(jiffies, timeout));
+
                reg = omap4_ctrl_pad_readl(control_pbias_offset);
                if (reg & OMAP4_MMC1_PBIASLITE_VMODE_ERROR_MASK) {
Quoted 2 lines

                       pr_err("Pbias Voltage is not same as LDO\n");

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#2 lore raw
Quoted 8 lines · Balaji
Quoted 6 lines · Santosh Shilimkar

While trying out V3.0-rc1, I noticed couple of regressions. Am posting this in case anybody come across same issues.

1.OMAP MMC code keep throwing "Pbias Voltage is not same as LDO" error continuously.

Quoted 8 lines
Quoted 3 lines

Balaji is planning post right fix for the same, but just in case you get around this issue,

Hi Santosh,
You can find MMC pbias fix here
http://www.spinics.net/lists/linux-omap/msg51735.html

Thanks Balaji.

Regards
Santosh