tcmode-default: disable ARMv7 Optimization for qt4-x11-free

PATCH In review Saul Wold 4 participants 8 messages Jun 1, 2011

lore

Share & tools

lore

Saul Wold

author

2011-06-01 05:30 UTC #0 lore raw

PATCH 1/1 tcmode-default: disable ARMv7 Optimization for qt4-x11-free

[YOCTO #1030]

This diables the ARMv7 optimizations that cause the compiler to fail with the following error

| ../../include/QtCore/../../src/corelib/arch/qatomic_arm.h: In function 'void qt_removeObject(QObject*)':
| ../../include/QtCore/../../src/corelib/arch/qatomic_arm.h:361:35: error: output number 1 not directly addressable

Signed-off-by Saul Wold <[email protected]>

---
 meta/conf/distro/include/tcmode-default.inc |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

meta/conf/distro/include/tcmode-default.inc +0 -0

index 6eb34ef..6393ffd 100644
@@ -29,6 +29,7 @@ PREFERRED_VERSION_u-boot-mkimage-native_powerpc ?= "2009.08"
 # Temporary workaround for gcc 4.6.0 ICE with beagleboard
 # gcc bug: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47719
 TARGET_CC_ARCH_arm_pn-mesa-xlib :=

"${@'${TARGET_CC_ARCH}'.replace('armv7-a','armv5')}" +TARGET_CC_ARCH_arm_pn-qt4-x11-free := "${@'${TARGET_CC_ARCH}'.replace('armv7-a','armv5')}"

PREFERRED_VERSION_gcc ?= "${GCCVERSION}"
PREFERRED_VERSION_gcc-cross ?= "${GCCVERSION}"

Signature · 9 lines

1.7.4.1


-- 
    Sau!

Saul Wold
Yocto Component Wrangler @ Intel
Yocto Project / Poky Build System

Khem Raj

2011-06-01 06:00 UTC #1 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 9 lines · Saul Wold

[YOCTO #1030]
This diables the ARMv7 optimizations that cause the compiler to fail with the following error
| ../../include/QtCore/../../src/corelib/arch/qatomic_arm.h: In function 'void qt_removeObject(QObject*)':
| ../../include/QtCore/../../src/corelib/arch/qatomic_arm.h:361:35:
error: output number 1 not directly addressable

this is a coding error you can fix the source code I guess instead of pessimising the whole package

Quoted 14 lines

Signed-off-by Saul Wold <[email protected]>
---
 meta/conf/distro/include/tcmode-default.inc |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
meta/conf/distro/include/tcmode-default.inc +0 -0
index 6eb34ef..6393ffd 100644
@@ -29,6 +29,7 @@ PREFERRED_VERSION_u-boot-mkimage-native_powerpc ?=
"2009.08"
# Temporary workaround for gcc 4.6.0 ICE with beagleboard

Quoted 8 lines

 # gcc bug: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47719
 TARGET_CC_ARCH_arm_pn-mesa-xlib :=
"${@'${TARGET_CC_ARCH}'.replace('armv7-a','armv5')}"
+TARGET_CC_ARCH_arm_pn-qt4-x11-free :=
"${@'${TARGET_CC_ARCH}'.replace('armv7-a','armv5')}"

PREFERRED_VERSION_gcc ?= "${GCCVERSION}"
PREFERRED_VERSION_gcc-cross ?= "${GCCVERSION}"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3l1KwACgkQuwUzVZGdMxTBZACfTxYiNgPVbFuBDVzzLy8p2Vtr NuQAn3MQg54GfX/s0+lyb7qXMn8BAcay
=gOaO
-----END PGP SIGNATURE-----

Martin Jansa

2011-06-01 06:14 UTC #2 lore raw

Quoted 9 lines · Khem Raj

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 5 lines · Saul Wold
[YOCTO #1030]
This diables the ARMv7 optimizations that cause the compiler to fail with the following error

Quoted 7 lines

Quoted 4 lines
| ../../include/QtCore/../../src/corelib/arch/qatomic_arm.h: In function 'void qt_removeObject(QObject*)':
| ../../include/QtCore/../../src/corelib/arch/qatomic_arm.h:361:35:
error: output number 1 not directly addressable
this is a coding error you can fix the source code I guess instead of pessimising the whole package

FWIW: I haven't seen it in my armv7-a builds (nokia900), but I'm using gcc-4.6 from meta-oe.

Regards,

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Khem Raj

2011-06-01 06:18 UTC #3 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 15 lines · Martin Jansa

Quoted 14 lines · Khem Raj
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 9 lines · Saul Wold
[YOCTO #1030]
This diables the ARMv7 optimizations that cause the compiler to fail with the following error
| ../../include/QtCore/../../src/corelib/arch/qatomic_arm.h: In function 'void qt_removeObject(QObject*)':
| ../../include/QtCore/../../src/corelib/arch/qatomic_arm.h:361:35:
error: output number 1 not directly addressable

Quoted 8 lines

Quoted 2 lines
this is a coding error you can fix the source code I guess instead of pessimising the whole package
FWIW: I haven't seen it in my armv7-a builds (nokia900), but I'm using gcc-4.6 from meta-oe.
Regards,

this may give some hints on how to fix it in qt-x11
https://bugs.launchpad.net/ubuntu/+source/qt4-x11/+bug/673085
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3l2NQACgkQuwUzVZGdMxQ27gCeKEorKdMnEwd3rRqLAqQ6LX+s 90kAn3yx+/omTFUbM214frXzdDNQKEFR
=dO6F
-----END PGP SIGNATURE-----

Khem Raj

2011-06-01 06:25 UTC #4 lore raw

In reply to Martin Jansa

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 15 lines · Martin Jansa

Quoted 14 lines · Khem Raj
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 9 lines · Saul Wold
[YOCTO #1030]
This diables the ARMv7 optimizations that cause the compiler to fail with the following error
| ../../include/QtCore/../../src/corelib/arch/qatomic_arm.h: In function 'void qt_removeObject(QObject*)':
| ../../include/QtCore/../../src/corelib/arch/qatomic_arm.h:361:35:
error: output number 1 not directly addressable

Quoted 6 lines

Quoted 2 lines
this is a coding error you can fix the source code I guess instead of pessimising the whole package
FWIW: I haven't seen it in my armv7-a builds (nokia900), but I'm using gcc-4.6 from meta-oe.

this is because gcc 4.6 in meta-oe has fix for it its this patch here
http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01477.html

a patch developed by linaro folks but now is committed to FSF as well. this patch has not been backported to FSF 4.6 branch

Quoted 2 lines

Regards,

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3l2oUACgkQuwUzVZGdMxQa1ACfaHP5ur/Dlh78nAPI9ViqPaK1 G60An3/34c1z9ZoM3y8o62fvke32xI9J
=hDdS
-----END PGP SIGNATURE-----

Phil Blundell

2011-06-01 10:49 UTC #5 lore raw

Quoted 6 lines · Khem Raj

Quoted 5 lines · Martin Jansa
Quoted 4 lines · Khem Raj
Quoted 2 lines · Saul Wold
| ../../include/QtCore/../../src/corelib/arch/qatomic_arm.h:361:35:
error: output number 1 not directly addressable

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
this is a coding error you can fix the source code I guess instead of pessimising the whole package
FWIW: I haven't seen it in my armv7-a builds (nokia900), but I'm using gcc-4.6 from meta-oe.
this is because gcc 4.6 in meta-oe has fix for it its this patch here
http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01477.html

I'm a bit confused by this. In the first quote above you said that this was a coding error and ought to be fixed in qt, but now you seem to be saying that it's a compiler bug and should be fixed in gcc. If it's the latter, can we get that patch applied to the oe-core version of gcc?

Either way, I agree, working around this by just frobbing the architecture options seems like a bad idea.

Saul Wold

author

2011-06-01 17:54 UTC #6 lore raw

Quoted 21 lines · Phil Blundell

Quoted 6 lines · Khem Raj
Quoted 5 lines · Martin Jansa
Quoted 4 lines · Khem Raj
Quoted 2 lines · Saul Wold
| ../../include/QtCore/../../src/corelib/arch/qatomic_arm.h:361:35:
error: output number 1 not directly addressable
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
this is a coding error you can fix the source code I guess instead of pessimising the whole package
FWIW: I haven't seen it in my armv7-a builds (nokia900), but I'm using gcc-4.6 from meta-oe.
this is because gcc 4.6 in meta-oe has fix for it its this patch here
http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01477.html
I'm a bit confused by this. In the first quote above you said that this was a coding error and ought to be fixed in qt, but now you seem to be saying that it's a compiler bug and should be fixed in gcc. If it's the latter, can we get that patch applied to the oe-core version of gcc?

Quoted 5 lines

Either way, I agree, working around this by just frobbing the architecture options seems like a bad idea.
p.

Khem,

Is there any chance that you would be willing to throw me a patch that address this issue based on the gcc patch? If not. let me know and I will try to muddle my way through it ;-)!

Sau!

Quoted 7 lines

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Khem Raj

2011-06-01 18:35 UTC #7 lore raw

Quoted 30 lines · Saul Wold

Quoted 29 lines · Phil Blundell
Quoted 10 lines · Khem Raj
Quoted 8 lines · Martin Jansa
Quoted 6 lines · Khem Raj
Quoted 3 lines · Saul Wold
| ../../include/QtCore/../../src/corelib/arch/qatomic_arm.h:361:35:
error: output number 1 not directly addressable
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
this is a coding error you can fix the source code I guess instead of pessimising the whole package
FWIW: I haven't seen it in my armv7-a builds (nokia900), but I'm using gcc-4.6 from meta-oe.
this is because gcc 4.6 in meta-oe has fix for it its this patch here
http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01477.html
I'm a bit confused by this. In the first quote above you said that this was a coding error and ought to be fixed in qt, but now you seem to be saying that it's a compiler bug and should be fixed in gcc. If it's the latter, can we get that patch applied to the oe-core version of gcc?
Either way, I agree, working around this by just frobbing the architecture options seems like a bad idea.

Quoted 7 lines

Quoted 2 lines
p.
Khem,
Is there any chance that you would be willing to throw me a patch that address this issue based on the gcc patch? If not. let me know and I will try to muddle my way through it ;-)!

I dont have the environment to reproduce the error. If you can try to apply gcc patch I mentioned to gcc then it should help.

Quoted 11 lines

Sau!
Quoted 7 lines
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core