Skip to contentSkip to conversation

post, memorytest: fix if vstart is not = 0x0

PATCH New Heiko Schocher 3 participants 18 messages Jun 1, 2011 – Jul 28, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 post, memorytest: fix if vstart is not = 0x0

---
 post/drivers/memory.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
post/drivers/memory.c +3 -2
index 3f47449..b7943ef 100644
@@ -500,9 +500,10 @@ int memory_post_test(int flags)
 			unsigned long i;
 			for (i = 0; i < (memsize >> 20) && ret == 0; i++) {
 				if (ret == 0)
-					ret = memory_post_tests(i << 20, 0x800);
+					ret = memory_post_tests(vstart +
+						(i << 20), 0x800);
 				if (ret == 0)
-					ret = memory_post_tests(
+					ret = memory_post_tests(vstart +
 						(i << 20) + 0xff800, 0x800);
 			}
 		}
Signature · 1 line
1.7.4.4
#1 lore raw

PATCH 1/1 post, arm, memorytest: add support for arm based boards

---
 post/drivers/memory.c |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)
post/drivers/memory.c +20 -0
index b7943ef..47b312d 100644
@@ -455,10 +455,30 @@ static int memory_post_tests (unsigned long start, unsigned long size)
 __attribute__((weak))
 int arch_memory_test_prepare(u32 *vstart, u32 *size, phys_addr_t *phys_offset)
 {
+#if defined(CONFIG_ARM)
+	bd_t *bd = gd->bd;
+	int i;
+
+	*size = 0;
+	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
+		if (i == 0) {
+			*vstart = bd->bi_dram[0].start;
+			*size += bd->bi_dram[i].size;
+		} else {
+			if (bd->bi_dram[i].start ==
+			(bd->bi_dram[i - 1].start + bd->bi_dram[i - 1].size)) {
+				*size += bd->bi_dram[i].size;
+			} else {
+				break;
+			}
+		}
+	}
+#else
 	bd_t *bd = gd->bd;
 	*vstart = CONFIG_SYS_SDRAM_BASE;
 	*size = (bd->bi_memsize >= 256 << 20 ?
 			256 << 20 : bd->bi_memsize) - (1 << 20);
+#endif
 
 	/* Limit area to be tested with the board info struct */
 	if ((*vstart) + (*size) > (ulong)bd)
Signature · 1 line
1.7.4.4
#2 lore raw

PATCH 1/1 post, arm, memorytest: add support for arm based boards

Dear Heiko Schocher,

Quoted 10 lines · In message <[email protected]> you wrote:
---
 post/drivers/memory.c |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)
post/drivers/memory.c +0 -0
index b7943ef..47b312d 100644

post/drivers/memory.c static int memory_post_tests (unsigned long start, unsigned long size) · line 458

Quoted 4 lines
post/drivers/memory.c +1 -0
@@ -455,10 +455,30 @@ static int memory_post_tests (unsigned long start, unsigned long size)
 __attribute__((weak))
 int arch_memory_test_prepare(u32 *vstart, u32 *size, phys_addr_t *phys_offset)
 {
+#if defined(CONFIG_ARM)

This is a weak function, so there should be no need to have #ifdef's in there.

Just define your own code as you need it.

post/drivers/memory.c static int memory_post_tests (unsigned long start, unsigned long size) · line 466

Quoted 8 lines
post/drivers/memory.c +8 -0
+	bd_t *bd = gd->bd;
+	int i;
+
+	*size = 0;
+	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
+		if (i == 0) {
+			*vstart = bd->bi_dram[0].start;
+			*size += bd->bi_dram[i].size;

This is a constant part and should be moved out of the loop. Then you can also get rid of th if...else clause.

post/drivers/memory.c static int memory_post_tests (unsigned long start, unsigned long size) · line 472

Quoted 6 lines
post/drivers/memory.c +6 -0
+		} else {
+			if (bd->bi_dram[i].start ==
+			(bd->bi_dram[i - 1].start + bd->bi_dram[i - 1].size)) {
+				*size += bd->bi_dram[i].size;
+			} else {
+				break;

So how do you handle non-contiguous memory banks? It appears these are quite frequent on ARM these days.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Beware of bugs in the above code; I have only proved it correct, not
tried it."                                             - Donald Knuth
#3 lore raw

PATCH 1/1 post, arm, memorytest: add support for arm based boards

Hello Wolfgang,

Quoted 21 lines · Wolfgang Denk

Dear Heiko Schocher,

Quoted 10 lines · In message <[email protected]> you wrote:
---
 post/drivers/memory.c |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)
post/drivers/memory.c +0 -0
index b7943ef..47b312d 100644

post/drivers/memory.c static int memory_post_tests (unsigned long start, unsigned long size) · line 458

Quoted 4 lines
post/drivers/memory.c +1 -0
@@ -455,10 +455,30 @@ static int memory_post_tests (unsigned long start, unsigned long size)
 __attribute__((weak))
 int arch_memory_test_prepare(u32 *vstart, u32 *size, phys_addr_t *phys_offset)
 {
+#if defined(CONFIG_ARM)

This is a weak function, so there should be no need to have #ifdef's in there.

Quoted 1 line

Just define your own code as you need it.

Yes (I did this for my case, as I use it in nand_spl code, and therefore I need a "own" function, because there I have no bd ) ... but, for arm there is no bd->bi_memsize! ... so this file fails compiling. Independent, if it gets replaced by another function.

Quoted 11 lines

post/drivers/memory.c static int memory_post_tests (unsigned long start, unsigned long size) · line 466

Quoted 8 lines
post/drivers/memory.c +8 -0
+	bd_t *bd = gd->bd;
+	int i;
+
+	*size = 0;
+	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
+		if (i == 0) {
+			*vstart = bd->bi_dram[0].start;
+			*size += bd->bi_dram[i].size;

This is a constant part and should be moved out of the loop. Then you can also get rid of th if...else clause.

Yep, you are right! Change this.

Quoted 9 lines

post/drivers/memory.c static int memory_post_tests (unsigned long start, unsigned long size) · line 472

Quoted 6 lines
post/drivers/memory.c +6 -0
+		} else {
+			if (bd->bi_dram[i].start ==
+			(bd->bi_dram[i - 1].start + bd->bi_dram[i - 1].size)) {
+				*size += bd->bi_dram[i].size;
+			} else {
+				break;

So how do you handle non-contiguous memory banks? It appears these are quite frequent on ARM these days.

Actually, I could not handle this. Ok, I add a comment, that this function is actually only valid for contiguous mem banks.

Thanks!

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#4 lore raw

PATCH 1/1 post, arm, memorytest: add support for arm based boards

Quoted 16 lines · On Wednesday, June 01, 2011 02:54:30 Heiko Schocher wrote:
Quoted 15 lines · Wolfgang Denk

post/drivers/memory.c static int memory_post_tests (unsigned long start, · line 461

Quoted 10 lines · Heiko Schocher
post/drivers/memory.c +1 -0
@@ -455,10 +455,30 @@ static int memory_post_tests (unsigned long start,
 unsigned long size)
 
 __attribute__((weak))
 int arch_memory_test_prepare(u32 *vstart, u32 *size, phys_addr_t
 *phys_offset) {
 
+#if defined(CONFIG_ARM)

This is a weak function, so there should be no need to have #ifdef's in there.

Quoted 7 lines
Quoted 1 line

Just define your own code as you need it.

Yes (I did this for my case, as I use it in nand_spl code, and therefore I need a "own" function, because there I have no bd ) ... but, for arm there is no bd->bi_memsize! ... so this file fails compiling. Independent, if it gets replaced by another function.

so add bi_memsize to arm ? it's the only arch that lacks it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110601/f6f6a2f3/attachment.pgp

#5 lore raw

PATCH 1/1 post, arm, memorytest: add support for arm based boards

Hello Mike,

Quoted 16 lines · Mike Frysinger
Quoted 15 lines · On Wednesday, June 01, 2011 02:54:30 Heiko Schocher wrote:
Quoted 14 lines · Wolfgang Denk

post/drivers/memory.c static int memory_post_tests (unsigned long start, · line 461

Quoted 10 lines · Heiko Schocher
post/drivers/memory.c +1 -0
@@ -455,10 +455,30 @@ static int memory_post_tests (unsigned long start,
 unsigned long size)
 
 __attribute__((weak))
 int arch_memory_test_prepare(u32 *vstart, u32 *size, phys_addr_t
 *phys_offset) {
 
+#if defined(CONFIG_ARM)

This is a weak function, so there should be no need to have #ifdef's in there.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

Just define your own code as you need it.

Yes (I did this for my case, as I use it in nand_spl code, and therefore I need a "own" function, because there I have no bd ) ... but, for arm there is no bd->bi_memsize! ... so this file fails compiling. Independent, if it gets replaced by another function.

so add bi_memsize to arm ? it's the only arch that lacks it.

Hmm.. I thought of that too, but wouldn;t it be better to use gd->ram_size in post/drivers/memory.c, as this is defined in global_data for all archs?

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#6 lore raw

PATCH 1/1 post, arm, memorytest: add support for arm based boards

Dear Heiko Schocher,

Quoted 4 lines · In message <[email protected]> you wrote:

Hmm.. I thought of that too, but wouldn;t it be better to use gd->ram_size in post/drivers/memory.c, as this is defined in global_data for all archs?

Indeed. Can you do this, please?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A list is only as strong as its weakest link.            -- Don Knuth
#7 lore raw

PATCH 1/1 post, arm, memorytest: add support for arm based boards

In reply to Heiko Schocher
Quoted 6 lines · On Thursday, June 02, 2011 01:53:42 Heiko Schocher wrote:
Quoted 1 line · Mike Frysinger

so add bi_memsize to arm ? it's the only arch that lacks it.

Hmm.. I thought of that too, but wouldn;t it be better to use gd->ram_size in post/drivers/memory.c, as this is defined in global_data for all archs?

makes me wonder why we have bd->bi_memsize in the first place.

and how can this possibly work ?
arch/arm/lib/board.c:

	sprintf ((char *)memsz, "%ldk", (bd->bi_memsize / 1024) - pram);

-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110602/483f10af/attachment.pgp

#8 lore raw

PATCH 1/1 post, arm, memorytest: add support for arm based boards

Hello Mike,

Quoted 7 lines · Mike Frysinger
Quoted 5 lines · On Thursday, June 02, 2011 01:53:42 Heiko Schocher wrote:
Quoted 1 line · Mike Frysinger

so add bi_memsize to arm ? it's the only arch that lacks it.

Hmm.. I thought of that too, but wouldn;t it be better to use gd->ram_size in post/drivers/memory.c, as this is defined in global_data for all archs?

Quoted 6 lines

makes me wonder why we have bd->bi_memsize in the first place.

and how can this possibly work ?
arch/arm/lib/board.c:

	sprintf ((char *)memsz, "%ldk", (bd->bi_memsize / 1024) - pram);

-mike

Yep, good question ... maybe, no arm based board has defined

"#if defined(CONFIG_PRAM) || defined(CONFIG_LOGBUFFER)"

?

I can make a fix and change this to gd->ram_size?

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#9 lore raw

PATCH 1/1 post, arm, memorytest: add support for arm based boards

Dear Heiko Schocher,

Quoted 4 lines · In message <[email protected]> you wrote:

Yep, good question ... maybe, no arm based board has defined

"#if defined(CONFIG_PRAM) || defined(CONFIG_LOGBUFFER)"

That's actually very likely. ARM systems tended to be simple and not use any such fancy features.

Quoted 1 line

I can make a fix and change this to gd->ram_size?

Please do!

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
My brother sent me a postcard the other day with this  big  sattelite
photo  of the entire earth on it. On the back it said: "Wish you were
here".                                                - Steven Wright
#10 lore raw

PATCH 1/1 post, memory test: add memory_post_test() to include file

In reply to Heiko Schocher

This include is needed, if this memory test is used "outside" from post code, for example booting with nand_spl, and using this memory test before copying u-boot code to RAM and jumping to it.

---
 include/post.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/post.h +1 -0
index 519cef1..cda6e76 100644
@@ -187,6 +187,7 @@ extern int post_hotkeys_pressed(void);
 #define CONFIG_SYS_POST_CODEC		0x00200000
 #define CONFIG_SYS_POST_COPROC		0x00400000
 
+int memory_post_test(int flags);
 #endif /* CONFIG_POST */
 
 #endif /* _POST_H */
Signature · 1 line
1.7.4.4
#11 lore raw

PATCH 1/1 post, memory test: add memory_post_test() to include file

Dear Heiko Schocher,

Quoted 9 lines · In message <[email protected]> you wrote:

This include is needed, if this memory test is used "outside" from post code, for example booting with nand_spl, and using this memory test before copying u-boot code to RAM and jumping to it.

---
 include/post.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The price of curiosity is a terminal experience.
                         - Terry Pratchett, _The Dark Side of the Sun_
#12 lore raw

PATCH 1/1 post, memory test: add memory_post_test() to include file

Dear Heiko,

Quoted 9 lines · In message <[email protected]> you wrote:

This include is needed, if this memory test is used "outside" from post code, for example booting with nand_spl, and using this memory test before copying u-boot code to RAM and jumping to it.

---
 include/post.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

This got applied as commit f18714d, but obviously this patch has not been tested before as it is breaking a ton of boards:

...
Configuring for NETTA_ISDN - Board: NETTA, Options: NETTA_ISDN=1
include/post.h: Assembler messages:
include/post.h:190: Error: Unrecognized opcode: `int'
make[2]: *** [lib_powerpc/asm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
include/post.h: Assembler messages:
include/post.h:190: Error: Unrecognized opcode: `int'
make[2]: *** [lib_powerpc/asm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [lib_powerpc/libpostpowerpc.o] Error 2
make: *** [libpost.o] Error 2
ppc_6xx-size: 'u-boot': No such file
Configuring for NETTA_ISDN_6412 - Board: NETTA, Options: NETTA_ISDN=1,NETTA_6412=1 include/post.h: Assembler messages:
include/post.h:190: Error: Unrecognized opcode: `int'
make[2]: *** [lib_powerpc/asm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
include/post.h: Assembler messages:
include/post.h:190: Error: Unrecognized opcode: `int'
make[2]: *** [lib_powerpc/asm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [lib_powerpc/libpostpowerpc.o] Error 2
make: *** [libpost.o] Error 2
ppc_6xx-size: 'u-boot': No such file
Configuring for NETTA_ISDN_6412_SWAPHOOK - Board: NETTA, Options: NETTA_ISDN=1,NETTA_6412=1,NETTA_SWAPHOOK=1 include/post.h: Assembler messages:
include/post.h:190: Error: Unrecognized opcode: `int'
make[2]: *** [lib_powerpc/asm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
include/post.h: Assembler messages:
include/post.h:190: Error: Unrecognized opcode: `int'
make[2]: *** [lib_powerpc/asm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [lib_powerpc/libpostpowerpc.o] Error 2
make: *** [libpost.o] Error 2
ppc_6xx-size: 'u-boot': No such file
Configuring for NETTA_ISDN_SWAPHOOK - Board: NETTA, Options: NETTA_ISDN=1,NETTA_SWAPHOOK=1 include/post.h: Assembler messages:
include/post.h:190: Error: Unrecognized opcode: `int'
make[2]: *** [lib_powerpc/asm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
include/post.h: Assembler messages:
include/post.h:190: Error: Unrecognized opcode: `int'
make[2]: *** [lib_powerpc/asm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [lib_powerpc/libpostpowerpc.o] Error 2
make: *** [libpost.o] Error 2
ppc_6xx-size: 'u-boot': No such file
Configuring for NETTA_SWAPHOOK - Board: NETTA, Options: NETTA_SWAPHOOK=1
include/post.h: Assembler messages:
include/post.h:190: Error: Unrecognized opcode: `int'
make[2]: *** [lib_powerpc/asm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
include/post.h: Assembler messages:
include/post.h:190: Error: Unrecognized opcode: `int'
make[2]: *** [lib_powerpc/asm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [lib_powerpc/libpostpowerpc.o] Error 2
make: *** [libpost.o] Error 2
ppc_6xx-size: 'u-boot': No such file
...
Configuring for KUP4X board...
include/post.h: Assembler messages:
include/post.h:190: Error: Unrecognized opcode: `int'
make[2]: *** [lib_powerpc/asm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
include/post.h: Assembler messages:
include/post.h:190: Error: Unrecognized opcode: `int'
...

Please fix!!

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
We fight only when there is no other choice. We prefer  the  ways  of
peaceful contact.
	-- Kirk, "Spectre of the Gun", stardate 4385.3
#13 lore raw

PATCH 1/1 post, memory test: add memory_post_test() to include file

Dear Heiko,

Quoted 14 lines · In message <[email protected]> I wrote:
Quoted 9 lines · In message <[email protected]> you wrote:

This include is needed, if this memory test is used "outside" from post code, for example booting with nand_spl, and using this memory test before copying u-boot code to RAM and jumping to it.

---
 include/post.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

This got applied as commit f18714d, but obviously this patch has not been tested before as it is breaking a ton of boards:

...

Quoted 1 line

Please fix!!

To keep the number of non-compiling commits small and being able to apply more patches now I decided not to wait for your fix, but to revert the broken commit.

Please resubmit the (fixed) patch.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I find this a nice feature but it is not according to  the  documen-
tation. Or is it a BUG?"   "Let's call it an accidental feature. :-)"
                       - Larry Wall in <[email protected]>
#14 lore raw

PATCH 1/1 post, memory test: add memory_post_test() to include file

Hello Wolfgang,

Quoted 15 lines · Wolfgang Denk

Dear Heiko,

Quoted 6 lines · In message <[email protected]> I wrote:
Quoted 5 lines · In message <[email protected]> you wrote:

This include is needed, if this memory test is used "outside" from post code, for example booting with nand_spl, and using this memory test before copying u-boot code to RAM and jumping to it.

Quoted 6 lines
Quoted 4 lines
---
 include/post.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

This got applied as commit f18714d, but obviously this patch has not been tested before as it is breaking a ton of boards:

Quoted 8 lines

...

Quoted 1 line

Please fix!!

To keep the number of non-compiling commits small and being able to apply more patches now I decided not to wait for your fix, but to revert the broken commit.

Please resubmit the (fixed) patch.

Argh, did a "MAKEALL arm" only ... Sorry for the inconvinience! I look at this ASAP.

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#15 lore raw

PATCH v2 1/1 post, memory test: add memory_post_test() to include file

In reply to Heiko Schocher

This include is needed, if this memory test is used "outside" from post code, for example booting with nand_spl, and using this memory test before copying u-boot code to RAM and jumping to it.

---
changes for v2:
- make MAKEALL clean as Wolfgang Denk suggested
- rebased against 7130a579fdba5dd1bf99508fb0b1d13317542109

 include/post.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/post.h +1 -0
index 3f259b7..3d23d22 100644
@@ -147,6 +147,7 @@ unsigned long post_time_ms (unsigned long base);
 extern struct post_test post_list[];
 extern unsigned int post_list_size;
 extern int post_hotkeys_pressed(void);
+extern int memory_post_test(int flags);
 
 /*
  *  If GCC is configured to use a version of GAS that supports
Signature · 1 line
1.7.6
#16 lore raw

PATCH v2 1/1 post, memory test: add memory_post_test() to include file

Dear Heiko Schocher,

Quoted 7 lines · In message <[email protected]> you wrote:

This include is needed, if this memory test is used "outside" from post code, for example booting with nand_spl, and using this memory test before copying u-boot code to RAM and jumping to it.

Quoted 8 lines

---
changes for v2:
- make MAKEALL clean as Wolfgang Denk suggested
- rebased against 7130a579fdba5dd1bf99508fb0b1d13317542109

 include/post.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Any technology distinguishable from magic is insufficiently advanced.
#17 lore raw

PATCH 1/1 post, memorytest: fix if vstart is not = 0x0

In reply to Heiko Schocher

Dear Heiko Schocher,

Quoted 4 lines · In message <[email protected]> you wrote:
---
 post/drivers/memory.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Don't hit a man when he's down - kick him; it's easier.